From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 90932A49F for ; Wed, 24 Jan 2018 10:16:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 01:16:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,406,1511856000"; d="scan'208";a="22177273" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jan 2018 01:16:32 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 01:16:31 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 01:16:31 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Wed, 24 Jan 2018 17:16:08 +0800 From: "Liu, Yong" To: "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [patch v1] fix coremask issue Thread-Index: AQHTlPLFtJoaJVNQvEaXVHZMBslUHKOCvWAA Date: Wed, 24 Jan 2018 09:16:07 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F59692@SHSMSX103.ccr.corp.intel.com> References: <1516784889-26590-1-git-send-email-gangx.xu@intel.com> In-Reply-To: <1516784889-26590-1-git-send-email-gangx.xu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQwNDU5OTktZWVlZC00MWE4LWE0MDUtNWY3NjYwY2UwNTgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJMejhrT0dWTTU4RGdyaEJcL0dhZndBVVQrSDUzMmVBZ3lRWkdWK1Q2eGNCb0ZuXC9oMTgrRlFwRFlRbzlET2ZRdXAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [patch v1] fix coremask issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 09:16:34 -0000 Gang, In this suite, I do not think CONFIG_RTE_LOG_DP_LEVEL is needed.=20 Please check whether it still can work without datapath log level modificat= ion. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Wednesday, January 24, 2018 5:08 PM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [patch v1] fix coremask issue >=20 > remove CONFIG_RTE_LOG_LEVEL, use CONFIG_RTE_LOG_DP_LEVEL=3DRTE_LOG_DEBUG > modify log-level=3D"lib.eal,8" mean open eal library debug log. >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_coremask.py | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) >=20 > diff --git a/tests/TestSuite_coremask.py b/tests/TestSuite_coremask.py > index a28266a..d3773cb 100644 > --- a/tests/TestSuite_coremask.py > +++ b/tests/TestSuite_coremask.py > @@ -17,7 +17,7 @@ from test_case import TestCase > # Test class. > # >=20 > -command_line =3D """./%s/app/test -c %s -n %d --log-level 8""" > +command_line =3D """./%s/app/test -c %s -n %d --log-level=3D"lib.eal,8" = """ >=20 >=20 > class TestCoremask(TestCase): > @@ -39,8 +39,8 @@ class TestCoremask(TestCase): > self.mem_channel =3D self.dut.get_memory_channels() >=20 > self.all_cores =3D self.dut.get_core_list("all") > - self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=3D.*$/" > - + "CONFIG_RTE_LOG_LEVEL=3DRTE_LOG_DEBUG/' > config/common_base", "# ", 30) > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_DP_LEVEL=3D.*$= /" > + + "CONFIG_RTE_LOG_DP_LEVEL=3DRTE_LOG_DEBUG/' > config/common_base", "# ", 30) >=20 > self.dut.skip_setup =3D False > self.dut.build_install_dpdk(self.target) > @@ -64,7 +64,6 @@ class TestCoremask(TestCase): > self.mem_channel) >=20 > out =3D self.dut.send_expect(command, "RTE>>", 10) > - > self.verify("EAL: Detected lcore %s as core" % core in out, > "Core %s not detected" % core) >=20 > @@ -83,7 +82,6 @@ class TestCoremask(TestCase): > command =3D command_line % (self.target, core_mask, > self.mem_channel) >=20 > out =3D self.dut.send_expect(command, "RTE>>", 10) > - > self.verify("EAL: Master lcore 1 is ready" in out, > "Core 1 not ready") >=20 > @@ -104,7 +102,7 @@ class TestCoremask(TestCase): > Check coremask parsing for more cores than available. > """ >=20 > - command_line =3D """./%s/app/test -c %s -n %d --log-level 8 2>&1 > |tee out""" > + command_line =3D """./%s/app/test -c %s -n %d --log- > level=3D"lib.eal,8" 2>&1 |tee out""" >=20 > # Default big coremask value 128 > big_coremask_size =3D 128 > @@ -131,7 +129,6 @@ class TestCoremask(TestCase): > self.dut.send_expect(command, "RTE>>", 10) > except: > out =3D self.dut.send_expect("cat out", "# ") > - > self.verify("EAL: invalid coremask" in out, > "Small core mask set") >=20 > @@ -178,8 +175,8 @@ class TestCoremask(TestCase): > """ > Run after each test suite. > """ > - self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_LEVEL=3D.*$/" > - + "CONFIG_RTE_LOG_LEVEL=3DRTE_LOG_INFO/' > config/common_base", "# ", 30) > + self.dut.send_expect("sed -i -e 's/CONFIG_RTE_LOG_DP_LEVEL=3D.*$= /" > + + "CONFIG_RTE_LOG_DP_LEVEL=3DRTE_LOG_INFO/' > config/common_base", "# ", 30) >=20 > #self.dut.skip_setup =3D False > self.dut.build_install_dpdk(self.target) > -- > 1.9.3