From: "Liu, Yong" <yong.liu@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH]: Add port start, stop action and fix tx offload change.
Date: Thu, 25 Jan 2018 08:05:32 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F5A6CD@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1516841738-17026-1-git-send-email-xueqin.lin@intel.com>
Thanks Xueqin, Applied.
Please align with recommended commit subject format and strict each commit line in 72 characters.
Regards,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Thursday, January 25, 2018 8:56 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH]: Add port start, stop action and fix tx offload
> change.
>
> 1. Add port stop and start for csum and tx offload configuration due to
> commit 597f9fafe13b.
> 2. Add --tx-offloads=0x8000 to let jumboframe DEV_TX_OFFLOAD_MULTI_SEGS
> set and tx checksum offloads set.
>
> ---
> tests/TestSuite_tx_preparation.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index 5916526..eea95c1 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -89,11 +89,12 @@ class TestTX_preparation(TestCase):
> self.dut_testpmd = PmdOutput(self.dut)
> # use one port test the case
> self.dut_testpmd.start_testpmd(
> - "Default", " --portmask=1 --port-topology=chained --max-
> pkt-len=%s" %Max_mtu)
> + "Default", " --portmask=1 --port-topology=chained --max-
> pkt-len=%s --tx-offloads=0x8000" %Max_mtu)
> self.dmac = self.dut_testpmd.get_port_mac(0)
> self.dut_testpmd.execute_cmd('set fwd csum')
> self.dut_testpmd.execute_cmd('set verbose 1')
> #enable ip/udp/tcp hardware checksum
> + self.dut_testpmd.execute_cmd('port stop all')
> self.dut_testpmd.execute_cmd('csum set ip hw 0')
> self.dut_testpmd.execute_cmd('csum set tcp hw 0')
> self.dut_testpmd.execute_cmd('csum set udp hw 0')
> @@ -168,6 +169,7 @@ class TestTX_preparation(TestCase):
> ftag functional test
> """
> self.dut_testpmd.execute_cmd('tso set 0 0')
> + self.dut_testpmd.execute_cmd('port start all')
> self.dut_testpmd.execute_cmd('start')
>
> self.send_packet_verify()
> @@ -179,6 +181,7 @@ class TestTX_preparation(TestCase):
> ftag functional test
> """
> self.dut_testpmd.execute_cmd('tso set %s 0' %TSO_value)
> + self.dut_testpmd.execute_cmd('port start all')
> self.dut_testpmd.execute_cmd('start')
>
> self.send_packet_verify(1)
> --
> 2.5.5
prev parent reply other threads:[~2018-01-25 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 0:55 Xueqin Lin
2018-01-25 8:05 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62F5A6CD@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).