test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH]: Add port start, stop action and fix tx offload change.
@ 2018-01-25  0:55 Xueqin Lin
  2018-01-25  8:05 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: Xueqin Lin @ 2018-01-25  0:55 UTC (permalink / raw)
  To: dts; +Cc: Xueqin Lin

 1. Add port stop and start for csum and tx offload configuration due to commit 597f9fafe13b. 
 2. Add --tx-offloads=0x8000 to let jumboframe DEV_TX_OFFLOAD_MULTI_SEGS set and tx checksum offloads set.

---
 tests/TestSuite_tx_preparation.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index 5916526..eea95c1 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -89,11 +89,12 @@ class TestTX_preparation(TestCase):
         self.dut_testpmd = PmdOutput(self.dut)
         # use one port test the case
         self.dut_testpmd.start_testpmd(
-                "Default", " --portmask=1 --port-topology=chained --max-pkt-len=%s" %Max_mtu)
+                "Default", " --portmask=1 --port-topology=chained --max-pkt-len=%s --tx-offloads=0x8000" %Max_mtu)
         self.dmac = self.dut_testpmd.get_port_mac(0)
         self.dut_testpmd.execute_cmd('set fwd csum')
         self.dut_testpmd.execute_cmd('set verbose 1')
         #enable ip/udp/tcp hardware checksum
+        self.dut_testpmd.execute_cmd('port stop all')
         self.dut_testpmd.execute_cmd('csum set ip hw 0')
         self.dut_testpmd.execute_cmd('csum set tcp hw 0')
         self.dut_testpmd.execute_cmd('csum set udp hw 0')
@@ -168,6 +169,7 @@ class TestTX_preparation(TestCase):
         ftag functional test
         """
         self.dut_testpmd.execute_cmd('tso set 0 0')
+        self.dut_testpmd.execute_cmd('port start all')
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify()
@@ -179,6 +181,7 @@ class TestTX_preparation(TestCase):
         ftag functional test
         """
         self.dut_testpmd.execute_cmd('tso set %s 0' %TSO_value)
+        self.dut_testpmd.execute_cmd('port start all')
         self.dut_testpmd.execute_cmd('start')
 
         self.send_packet_verify(1)
-- 
2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH]: Add port start, stop action and fix tx offload change.
  2018-01-25  0:55 [dts] [PATCH]: Add port start, stop action and fix tx offload change Xueqin Lin
@ 2018-01-25  8:05 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-01-25  8:05 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin

Thanks Xueqin, Applied.
Please align with recommended commit subject format and strict each commit line in 72 characters.

Regards,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Thursday, January 25, 2018 8:56 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH]: Add port start, stop action and fix tx offload
> change.
> 
>  1. Add port stop and start for csum and tx offload configuration due to
> commit 597f9fafe13b.
>  2. Add --tx-offloads=0x8000 to let jumboframe DEV_TX_OFFLOAD_MULTI_SEGS
> set and tx checksum offloads set.
> 
> ---
>  tests/TestSuite_tx_preparation.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index 5916526..eea95c1 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -89,11 +89,12 @@ class TestTX_preparation(TestCase):
>          self.dut_testpmd = PmdOutput(self.dut)
>          # use one port test the case
>          self.dut_testpmd.start_testpmd(
> -                "Default", " --portmask=1 --port-topology=chained --max-
> pkt-len=%s" %Max_mtu)
> +                "Default", " --portmask=1 --port-topology=chained --max-
> pkt-len=%s --tx-offloads=0x8000" %Max_mtu)
>          self.dmac = self.dut_testpmd.get_port_mac(0)
>          self.dut_testpmd.execute_cmd('set fwd csum')
>          self.dut_testpmd.execute_cmd('set verbose 1')
>          #enable ip/udp/tcp hardware checksum
> +        self.dut_testpmd.execute_cmd('port stop all')
>          self.dut_testpmd.execute_cmd('csum set ip hw 0')
>          self.dut_testpmd.execute_cmd('csum set tcp hw 0')
>          self.dut_testpmd.execute_cmd('csum set udp hw 0')
> @@ -168,6 +169,7 @@ class TestTX_preparation(TestCase):
>          ftag functional test
>          """
>          self.dut_testpmd.execute_cmd('tso set 0 0')
> +        self.dut_testpmd.execute_cmd('port start all')
>          self.dut_testpmd.execute_cmd('start')
> 
>          self.send_packet_verify()
> @@ -179,6 +181,7 @@ class TestTX_preparation(TestCase):
>          ftag functional test
>          """
>          self.dut_testpmd.execute_cmd('tso set %s 0' %TSO_value)
> +        self.dut_testpmd.execute_cmd('port start all')
>          self.dut_testpmd.execute_cmd('start')
> 
>          self.send_packet_verify(1)
> --
> 2.5.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-25  8:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-25  0:55 [dts] [PATCH]: Add port start, stop action and fix tx offload change Xueqin Lin
2018-01-25  8:05 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).