test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Lu, PeipeiX" <peipeix.lu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/fdir: fix fdir case on sagepond
Date: Thu, 25 Jan 2018 08:51:45 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F5A855@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1516869812-28973-1-git-send-email-peipeix.lu@intel.com>

Peipei,
Please modify your commit log for make it clear. Like which case not support on sagepond and which case is supported.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Thursday, January 25, 2018 4:44 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/fdir: fix fdir case on sagepond
> 
>  Add sagepond nic to test fdir, fix fdir case on sagepind.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  conf/test_case_checklist.json | 9 ++++++---
>  tests/TestSuite_fdir.py       | 6 +++---
>  2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 38cca5a..860485f 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -1754,7 +1754,8 @@
>                  "ALL"
>              ],
>              "NIC": [
> -                "niantic"
> +                "niantic",
> +                "sagepond"
>              ],
>              "Target": [
>                  "ALL"
> @@ -1769,7 +1770,8 @@
>                  "ALL"
>              ],
>              "NIC": [
> -                "niantic"
> +                "niantic",
> +                "sagepond"
>              ],
>              "Target": [
>                  "ALL"
> @@ -1784,7 +1786,8 @@
>                  "ALL"
>              ],
>              "NIC": [
> -                "niantic"
> +                "niantic",
> +                "sagepond"
>              ],
>              "Target": [
>                  "ALL"
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
> index 44f1e96..80593e3 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -223,7 +223,7 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          Fdir get flexbytes and payload according NIC
>          """
> 
> -        if(self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g"]):
> +        if(self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g", "sagepond"]):
>              if not sctp:
>                  self.flexbytes =
> "0x11,0x11,0x22,0x22,0x33,0x33,0x44,0x44,0x55,0x55,0x66,0x66,0x77,0x77,0x8
> 8,0x88"
>              else:
> @@ -318,7 +318,7 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          if self.nic in ["niantic"]:
>              # Niantic ipv6 only support signature mode
>              self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i --
> portmask=%s --disable-rss  --rxq=4 --txq=4 --nb-cores=4  --nb-ports=1 --
> pkt-filter-mode=signature" % (self.target, self.coreMask,
> utils.create_mask([self.dut_ports[0]])), "testpmd>", 120)
> -        elif self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g"]:
> +        elif self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g", "sagepond"]:
>              # Fortville ipv6 support perfect mode
>              self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i --
> portmask=%s --disable-rss  --rxq=4 --txq=4 --nb-cores=4  --nb-ports=1 --
> pkt-filter-mode=perfect" % (self.target, self.coreMask,
> utils.create_mask([self.dut_ports[0]])), "testpmd>", 120)
>          self.dut.send_expect("set verbose 1", "testpmd>")
> @@ -603,7 +603,7 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          if self.nic in ["niantic"]:
>              # Niantic ipv6 only support signature mode
>              self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i --
> portmask=%s --disable-rss  --rxq=4 --txq=4 --nb-cores=4  --nb-ports=1 --
> pkt-filter-mode=signature" % (self.target, self.coreMask,
> utils.create_mask([self.dut_ports[0]])), "testpmd>", 120)
> -        elif self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g"]:
> +        elif self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortpark_TLV", "fortville_25g", "sagepond"]:
>              # fortville ipv6 support perfect mode
>              self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i --
> portmask=%s --disable-rss --rxq=4 --txq=4 --nb-cores=4 --nb-ports=1 --pkt-
> filter-mode=perfect" % (self.target, self.coreMask,
> utils.create_mask([self.dut_ports[0]])), "testpmd>", 120)
>          self.dut.send_expect("set verbose 1", "testpmd>")
> --
> 1.9.3

  reply	other threads:[~2018-01-25  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  8:43 lu,peipei
2018-01-25  8:51 ` Liu, Yong [this message]
2018-01-25  9:05 lu,peipei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62F5A855@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=peipeix.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).