test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] fix RX TX different
@ 2018-01-29  6:31 xu,gang
  2018-01-29  6:37 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2018-01-29  6:31 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index f81c3d5..e0af041 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -146,9 +146,6 @@ class TestShutdownApi(TestCase):
             # some NIC will always include tx crc
             rx_bytes_exp -= 4
             tx_bytes_exp -= 4
-            if vlan is True:
-                # vlan strip default is on
-                tx_bytes_exp -= 4
          
         # fortville nic enable send lldp packet function when port setup
         # now the tx-packets size is lldp_size(110) * n + forward packe size
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] fix RX TX different
  2018-01-29  6:31 [dts] [PATCH V1] fix RX TX different xu,gang
@ 2018-01-29  6:37 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-01-29  6:37 UTC (permalink / raw)
  To: Xu, GangX, dts; +Cc: Xu, GangX

Gang,
Please explain more about this change. Like why it need before and why useless now.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> Sent: Monday, January 29, 2018 2:31 PM
> To: dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: [dts] [PATCH V1] fix RX TX different
> 
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py
> index f81c3d5..e0af041 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -146,9 +146,6 @@ class TestShutdownApi(TestCase):
>              # some NIC will always include tx crc
>              rx_bytes_exp -= 4
>              tx_bytes_exp -= 4
> -            if vlan is True:
> -                # vlan strip default is on
> -                tx_bytes_exp -= 4
> 
>          # fortville nic enable send lldp packet function when port setup
>          # now the tx-packets size is lldp_size(110) * n + forward packe
> size
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-29  6:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29  6:31 [dts] [PATCH V1] fix RX TX different xu,gang
2018-01-29  6:37 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).