Re: [dts] [PATCH V4] stop port before csum set

["Liu, Yong" <yong.liu@intel.com>]

Lijuan, thanks for clear.

> -----Original Message-----
> From: Tu, LijuanX A
> Sent: Tuesday, January 30, 2018 10:28 AM
> To: Liu, Yong <yong.liu@intel.com>; Xu, GangX <gangx.xu@intel.com>;
> dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: RE: [dts] [PATCH V4] stop port before csum set
> 
> Hi Marvin,
> 
> In this case ,we don't need set csum related offload when start testpmd.
> When we run command "csum set ip/udp/tcp/sctp hw $port_id", dpdk will set
> csum offload.
> And we run command "csum set ip/udp/tcp/sctp sw $port_id", dpdk will
> remove csum offload.
> 
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Tuesday, January 30, 2018 10:14 AM
> To: Xu, GangX <gangx.xu@intel.com>; dts@dpdk.org
> Cc: Xu, GangX <gangx.xu@intel.com>
> Subject: Re: [dts] [PATCH V4] stop port before csum set
> 
> Gang,
> You forgot to add tx offloads in this patch.
> 
> +                                  "--port-topology=loop --tx-
> offloads=0x1e", socket=self.ports_socket)
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
> > Sent: Monday, January 29, 2018 6:15 PM
> > To: dts@dpdk.org
> > Cc: Xu, GangX <gangx.xu@intel.com>
> > Subject: [dts] [PATCH V4] stop port before csum set
> >
> > Need to stop port before configure csum.
> > refer dpdk commit : 597f9fafe13b
> >
> > Signed-off-by: xu,gang <gangx.xu@intel.com>
> > ---
> >  tests/TestSuite_checksum_offload.py | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/tests/TestSuite_checksum_offload.py
> > b/tests/TestSuite_checksum_offload.py
> > index 5f5547f..4183ead 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase):
> >          self.dut.send_expect("set fwd csum", "testpmd>")
> >
> >      def checksum_enablehw(self, port):
> > +            self.dut.send_expect("port stop all", "testpmd>")
> >              self.dut.send_expect("csum set ip hw %d" % port, "testpmd>")
> >              self.dut.send_expect("csum set udp hw %d" % port,
> "testpmd>")
> >              self.dut.send_expect("csum set tcp hw %d" % port,
> "testpmd>")
> >              self.dut.send_expect("csum set sctp hw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("port start all", "testpmd>")
> >
> >      def checksum_enablesw(self, port):
> > +            self.dut.send_expect("port stop all", "testpmd>")
> >              self.dut.send_expect("csum set ip sw %d" % port, "testpmd>")
> >              self.dut.send_expect("csum set udp sw %d" % port,
> "testpmd>")
> >              self.dut.send_expect("csum set tcp sw %d" % port,
> "testpmd>")
> >              self.dut.send_expect("csum set sctp sw %d" % port,
> "testpmd>")
> > +            self.dut.send_expect("port start all", "testpmd>")
> > +
> >
> >      def get_chksum_values(self, packets_expected):
> >          """
> > --
> > 1.9.3