From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id AB4522B84 for ; Fri, 2 Feb 2018 04:41:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2018 19:41:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,445,1511856000"; d="scan'208";a="26689750" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 01 Feb 2018 19:41:32 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 19:41:32 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Feb 2018 19:41:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Fri, 2 Feb 2018 11:41:30 +0800 From: "Liu, Yong" To: "Zhao, MeijuanX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests/vf_offload : enable hw vlan Thread-Index: AQHTm9ALj86z37d7gU+hRvRSxAM6d6OQa54g//99JQCAAI5WoA== Date: Fri, 2 Feb 2018 03:41:29 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F7FC79@SHSMSX103.ccr.corp.intel.com> References: <1517539635-38714-1-git-send-email-meijuanx.zhao@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62F7FBBD@SHSMSX103.ccr.corp.intel.com> <9866F1E5CE768A45B24F6603C6EF54DE012EA4E3@shsmsx102.ccr.corp.intel.com> In-Reply-To: <9866F1E5CE768A45B24F6603C6EF54DE012EA4E3@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTA1ZmQ3NTctM2VkOS00NTZlLWEwYzQtZDI1M2I5NjFiZGViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJheEFJY1VydEw0YzdQWVJQSGFUR3l5RGNnN05tSWpKdFVoM2RpREdkYnk3ak1ZUVpJNFBqQlJkK0xKTDhLR24wIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vf_offload : enable hw vlan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 03:41:34 -0000 Meijuan, I understood that testpmd default Rx offload setting has been changed. My question is that previous Rx vlan offloading is disable for the case, an= d now why you changed it to enabled by parameter "enable-hw-vlan" ?=20 Thanks, Marvin > -----Original Message----- > From: Zhao, MeijuanX > Sent: Friday, February 02, 2018 11:10 AM > To: Liu, Yong ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] tests/vf_offload : enable hw vlan >=20 > on the basis of yao lei's email yesterday : >=20 > 1. > In previous, testpmd will enable DEV_RX_OFFLOAD_VLAN_FILTER and > DEV_RX_OFFLOAD_VLAN_STRIP by default. > Now, they are default off. We need declare them in the testpmd parameter > by adding: > --enable-hw-vlan-filter > --enable-hw-vlan-strip >=20 > 2. Following four testpmd parameter are dropped now because the vlan rx > offload are default off. > --disable-hw-vlan > --disable-hw-vlan-filter > --disable-hw-vlan-strip > --disable-hw-vlan-extend >=20 > Instead, four new parameter are added. > --enable-hw-vlan > --enable-hw-vlan-filter > --enable-hw-vlan-strip > --enable-hw-vlan-extend >=20 > -----Original Message----- > From: Liu, Yong > Sent: Friday, February 2, 2018 11:01 AM > To: Zhao, MeijuanX ; dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: RE: [dts] [PATCH V1] tests/vf_offload : enable hw vlan >=20 > Meijuan, > Why change the default setting for RX VLAN offloading? Previous setting i= s > disable and why you enabled it? >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan > > Sent: Friday, February 02, 2018 10:47 AM > > To: dts@dpdk.org > > Cc: Zhao, MeijuanX > > Subject: [dts] [PATCH V1] tests/vf_offload : enable hw vlan > > > > need enable hw vlan when setup testpmd, you can refer to dpdk commit > > 8b9bd0ef > > > > Signed-off-by: zhao,meijuan > > --- > > tests/TestSuite_vf_offload.py | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/TestSuite_vf_offload.py > > b/tests/TestSuite_vf_offload.py index c1983ca..dbae6f9 100644 > > --- a/tests/TestSuite_vf_offload.py > > +++ b/tests/TestSuite_vf_offload.py > > @@ -208,7 +208,7 @@ class TestVfOffload(TestCase): > > verify forwarded packets have correct checksum > > """ > > self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=3D%s= " % > > - (self.portMask) + "--disable-hw- > > vlan --enable-rx-cksum " + "" + > > + (self.portMask) + > > + "--enable-hw-vlan > > --enable-rx-cksum " + "" + > > "--port-topology=3Dloop") > > self.vm0_testpmd.execute_cmd('set fwd csum') > > > > @@ -258,7 +258,7 @@ class TestVfOffload(TestCase): > > """ > > > > self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=3D%s= " % > > - (self.portMask) + "--disable-hw- > > vlan --enable-rx-cksum " + > > + (self.portMask) + > > + "--enable-hw-vlan > > --enable-rx-cksum " + > > "--port-topology=3Dloop") > > self.vm0_testpmd.execute_cmd('set fwd csum') > > > > -- > > 1.9.3