test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters
@ 2018-02-06  9:45 zhu,shuai
  2018-02-07  8:22 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: zhu,shuai @ 2018-02-06  9:45 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

Perhaps the older version is used in PKT_RX_VLAN_PKT, and now the version exists PKT_RX_VLAN.
Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vlan_ethertype_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py
index 98bbfe6..8e6dd49 100644
--- a/tests/TestSuite_vlan_ethertype_config.py
+++ b/tests/TestSuite_vlan_ethertype_config.py
@@ -189,7 +189,7 @@ class TestVlanEthertypeConfig(TestCase):
                 self.vlan_send_packet(rx_vlan, tpid)
                 out = self.dut.get_session_output()
                 self.verify(
-                    "PKT_RX_VLAN_PKT" in out, "Vlan recognized error:" + str(out))
+                    "PKT_RX_VLAN" in out, "Vlan recognized error:" + str(out))
 
     def test_vlan_filter_on_off(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters
  2018-02-06  9:45 [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters zhu,shuai
@ 2018-02-07  8:22 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-02-07  8:22 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Hi Shuai,
This change was merged into DPDK from commit 380a7aab.
Please also add this information your commit log and send it again.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, February 06, 2018 5:46 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/vlan_ethertype_config Modify the
> parameters
> 
> Perhaps the older version is used in PKT_RX_VLAN_PKT, and now the version
> exists PKT_RX_VLAN.
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vlan_ethertype_config.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vlan_ethertype_config.py
> b/tests/TestSuite_vlan_ethertype_config.py
> index 98bbfe6..8e6dd49 100644
> --- a/tests/TestSuite_vlan_ethertype_config.py
> +++ b/tests/TestSuite_vlan_ethertype_config.py
> @@ -189,7 +189,7 @@ class TestVlanEthertypeConfig(TestCase):
>                  self.vlan_send_packet(rx_vlan, tpid)
>                  out = self.dut.get_session_output()
>                  self.verify(
> -                    "PKT_RX_VLAN_PKT" in out, "Vlan recognized error:" +
> str(out))
> +                    "PKT_RX_VLAN" in out, "Vlan recognized error:" +
> str(out))
> 
>      def test_vlan_filter_on_off(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters
  2018-02-07  8:41 Peng Yuan
@ 2018-02-08 14:19 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-02-08 14:19 UTC (permalink / raw)
  To: Peng Yuan, dts; +Cc: zhu,shuai

Shuai,
You fix can work is caused of the translation of Rx offload flags is 
changed.
You can check the details in commit 380a7aab.  Applied your patch with 
commit modified.

Thanks,
Marvin

On 02/07/2018 04:41 PM, Peng Yuan wrote:
> From: "zhu,shuai"<shuaix.zhu@intel.com>
>
> Perhaps the older version is used in PKT_RX_VLAN_PKT, and now the version exists PKT_RX_VLAN.commit 380a7aab.
> Signed-off-by: zhu,shuai<shuaix.zhu@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters
@ 2018-02-07  8:41 Peng Yuan
  2018-02-08 14:19 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: Peng Yuan @ 2018-02-07  8:41 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

From: "zhu,shuai" <shuaix.zhu@intel.com>

Perhaps the older version is used in PKT_RX_VLAN_PKT, and now the version exists PKT_RX_VLAN.commit 380a7aab.
Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vlan_ethertype_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py
index 98bbfe6..8e6dd49 100644
--- a/tests/TestSuite_vlan_ethertype_config.py
+++ b/tests/TestSuite_vlan_ethertype_config.py
@@ -189,7 +189,7 @@ class TestVlanEthertypeConfig(TestCase):
                 self.vlan_send_packet(rx_vlan, tpid)
                 out = self.dut.get_session_output()
                 self.verify(
-                    "PKT_RX_VLAN_PKT" in out, "Vlan recognized error:" + str(out))
+                    "PKT_RX_VLAN" in out, "Vlan recognized error:" + str(out))
 
     def test_vlan_filter_on_off(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-08  6:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06  9:45 [dts] [PATCH V1] tests/vlan_ethertype_config Modify the parameters zhu,shuai
2018-02-07  8:22 ` Liu, Yong
2018-02-07  8:41 Peng Yuan
2018-02-08 14:19 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).