From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7EAC61B765 for ; Thu, 8 Feb 2018 08:46:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Feb 2018 23:46:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,477,1511856000"; d="scan'208";a="29810936" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 07 Feb 2018 23:46:28 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 23:46:28 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Feb 2018 23:46:28 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 15:46:26 +0800 From: "Liu, Yong" To: "Han, YingyaX" , "dts@dpdk.org" CC: "Pei, Yulong" , "Lin, Xueqin" Thread-Topic: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan Thread-Index: AQHTnmmP5vtkrSz8QUidfpnpQkdKdaOaB3NQ//+VVgCAAIbdkA== Date: Thu, 8 Feb 2018 07:46:26 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F9C4E0@SHSMSX103.ccr.corp.intel.com> References: <1517825456-42304-1-git-send-email-yingyax.han@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62F9C397@SHSMSX103.ccr.corp.intel.com> <9AC1400278453341942179604C2BF126D64C04@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <9AC1400278453341942179604C2BF126D64C04@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWMxZWQyMjYtOWRhOC00ZDZiLWEzYjctYjhhZjY4ZTdjODA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJGOGhmcERxK2haUld1VVB1SEppY3lPemdcL0h0S0poSkhmV0U2WVwveER6RE93aWVycEd6ZHE0OXpZdVwvY3VReVVFIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 07:46:33 -0000 Yingya, QinQ filter case can work without DEV_RX_OFFLOAD_VLAN flag. I assume that p= acket type case will like it. Please check the output of packet type, what kind of packet will be dumped = when rx vlan offloading is disabled? Thanks, Marvin > -----Original Message----- > From: Han, YingyaX > Sent: Thursday, February 08, 2018 3:39 PM > To: Liu, Yong ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan >=20 > I checked this case on several different platforms and DEV_RX_OFFLOAD_VLA= N > must to be set. > Thanks , > yingya > -----Original Message----- > From: Liu, Yong > Sent: Thursday, February 8, 2018 2:06 PM > To: Han, YingyaX ; dts@dpdk.org > Cc: Han, YingyaX > Subject: RE: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan >=20 > Yingya, > In test_qinq_pack_type case, testpmd will enable qinq and meanwhile > DEV_RX_OFFLOAD_VLAN_EXTEND flag will be set. > Can you check whether DEV_RX_OFFLOAD_VLAN is must for this case? >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > > Sent: Monday, February 05, 2018 6:11 PM > > To: dts@dpdk.org > > Cc: Han, YingyaX > > Subject: [dts] [PATCH V1]tests/qinq_filter:enable hw vlan > > > > need enable hw vlan parameter,because default value is off > > Signed-off-by: han,yingya > > --- > > tests/TestSuite_qinq_filter.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/TestSuite_qinq_filter.py > > b/tests/TestSuite_qinq_filter.py index 3f9c1ac..d1310a5 100644 > > --- a/tests/TestSuite_qinq_filter.py > > +++ b/tests/TestSuite_qinq_filter.py > > @@ -146,7 +146,7 @@ class TestQinqFilter(TestCase): > > """ > > > > self.dut.send_expect(r'./%s/app/testpmd -c %s -n 4 -- -i \ > > - --portmask=3D%s --port-topology=3Dloop = \ > > + --portmask=3D%s --enable-hw-vlan --port= - > > topology=3Dloop \ > > --rxq=3D4 --txq=3D4 --disable-rss' % > > (self.target, self.coreMask, self.portMask), > > "testpmd> ") > > self.dut.send_expect("vlan set qinq on %s" % dutRxPortId, > > "testpmd> ") > > -- > > 1.9.3