test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_kernel fix some vlan issue
@ 2018-02-09  8:01 zhao,meijuan
  2018-02-11  1:28 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: zhao,meijuan @ 2018-02-09  8:01 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

need enable vlan strip filter parameter,
you can refer to dpdk 8b9bd0e

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_kernel.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
index c5c150f..eb317b9 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -108,7 +108,7 @@ class TestVfKernel(TestCase):
 
         self.dut_testpmd = PmdOutput(self.dut)
         self.dut_testpmd.start_testpmd(
-            "Default", "--rxq=4 --txq=4 --port-topology=chained")
+            "Default", "--rxq=4 --txq=4 --port-topology=chained --enable-hw-vlan-strip --enable-hw-vlan-filter")
         # dpdk-2208
         # since there is no forward engine on DPDK PF to forward or drop packet in packet pool,
         # so finally the pool will be full, then no more packet will be
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_kernel fix some vlan issue
  2018-02-09  8:01 [dts] [PATCH V1] tests/vf_kernel fix some vlan issue zhao,meijuan
@ 2018-02-11  1:28 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-02-11  1:28 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Hi Meijuan,
This change is only needed for vlan related case and there's no need to change default settings for all VF test cases.
You can also do such things dynamically in testpmd, like command "port config all hw-vlan-filter|hw-vlan-strip on".

And if you indeed want to change the preconditions for all cases, you need to update the test plan.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Friday, February 09, 2018 4:02 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_kernel fix some vlan issue
> 
> need enable vlan strip filter parameter,
> you can refer to dpdk 8b9bd0e
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_kernel.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index c5c150f..eb317b9 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -108,7 +108,7 @@ class TestVfKernel(TestCase):
> 
>          self.dut_testpmd = PmdOutput(self.dut)
>          self.dut_testpmd.start_testpmd(
> -            "Default", "--rxq=4 --txq=4 --port-topology=chained")
> +            "Default", "--rxq=4 --txq=4 --port-topology=chained --enable-
> hw-vlan-strip --enable-hw-vlan-filter")
>          # dpdk-2208
>          # since there is no forward engine on DPDK PF to forward or drop
> packet in packet pool,
>          # so finally the pool will be full, then no more packet will be
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-11  1:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09  8:01 [dts] [PATCH V1] tests/vf_kernel fix some vlan issue zhao,meijuan
2018-02-11  1:28 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).