From: "Liu, Yong" <yong.liu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed
Date: Tue, 13 Feb 2018 05:15:05 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F9ECF4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1518420805-54567-1-git-send-email-shuaix.zhu@intel.com>
Shuai,
DTS framework will guarantee that self.drivername has been insmoded. There's no need to install it in the suite.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Monday, February 12, 2018 3:33 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix
> qinq_packet_filter_VF_queues vfiopci failed
>
> diff --git a/tests/TestSuite_qinq_filter.py
> b/tests/TestSuite_qinq_filter.py
> index 3f9c1ac..01b3b96 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -121,17 +121,31 @@ class TestQinqFilter(TestCase):
> fw.write(word)
> fw.close()
>
> + def install_igb_uio(self):
> + self.dut.send_expect("modprobe uio", "#", 70)
> + out = self.dut.send_expect("lsmod | grep igb_uio", "#")
> + if "igb_uio" in out:
> + self.dut.send_expect("rmmod -f igb_uio", "#", 70)
> + self.dut.send_expect("insmod ./" + self.target +
> "/kmod/igb_uio.ko", "#", 60)
> +
> + out = self.dut.send_expect("lsmod | grep igb_uio", "#")
> + assert ("igb_uio" in out), "Failed to insmod igb_uio"
> +
> +
> def config_vfs(self, port_id, vfs):
> """
> if vfs is 0, call destroy_sriov_vfs_by_port in dut for destory vf.
> if vfs > 0, call generate_sriov_vfs_by_port generate vf and bind
> igb_uio to vf
> """
> if vfs:
> + self.install_igb_uio()
> self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')
> for port in self.dut.ports_info[port_id]['vfs_port']:
> - port.bind_driver('igb_uio')
> + # port.bind_driver('igb_uio')
Since this line is useless, please remove it.
> + port.bind_driver(self.drivername)
> else:
> self.dut.destroy_sriov_vfs_by_port(port_id)
> +
> self.dut.ports_info[port_id]['port'].bind_driver(self.drivername)
>
>
> def set_up(self):
> --
> 1.9.3
prev parent reply other threads:[~2018-02-13 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 7:33 zhu,shuai
2018-02-13 5:15 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62F9ECF4@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=shuaix.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).