[dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed

[dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed

[zhu,shuai]

diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py
index 3f9c1ac..01b3b96 100644
--- a/tests/TestSuite_qinq_filter.py
+++ b/tests/TestSuite_qinq_filter.py
@@ -121,17 +121,31 @@ class TestQinqFilter(TestCase):
             fw.write(word)
         fw.close()
 
+    def install_igb_uio(self):
+        self.dut.send_expect("modprobe uio", "#", 70)
+        out = self.dut.send_expect("lsmod | grep igb_uio", "#")
+        if "igb_uio" in out:
+            self.dut.send_expect("rmmod -f igb_uio", "#", 70)
+        self.dut.send_expect("insmod ./" + self.target + "/kmod/igb_uio.ko", "#", 60)
+
+        out = self.dut.send_expect("lsmod | grep igb_uio", "#")
+        assert ("igb_uio" in out), "Failed to insmod igb_uio"
+
+
     def config_vfs(self, port_id, vfs):
         """
         if vfs is 0, call destroy_sriov_vfs_by_port in dut for destory vf.
         if vfs > 0, call generate_sriov_vfs_by_port generate vf and bind igb_uio to vf
         """
         if vfs:
+            self.install_igb_uio()
             self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')
             for port in self.dut.ports_info[port_id]['vfs_port']:
-                port.bind_driver('igb_uio')
+               # port.bind_driver('igb_uio')
+                port.bind_driver(self.drivername)
         else:
             self.dut.destroy_sriov_vfs_by_port(port_id)
+            self.dut.ports_info[port_id]['port'].bind_driver(self.drivername)
         
         
     def set_up(self):
-- 
1.9.3

Re: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed

[Liu, Yong]

Shuai,
DTS framework will guarantee that self.drivername has been insmoded. There's no need to install it in the suite.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Monday, February 12, 2018 3:33 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix
> qinq_packet_filter_VF_queues vfiopci failed
> 
> diff --git a/tests/TestSuite_qinq_filter.py
> b/tests/TestSuite_qinq_filter.py
> index 3f9c1ac..01b3b96 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -121,17 +121,31 @@ class TestQinqFilter(TestCase):
>              fw.write(word)
>          fw.close()
> 
> +    def install_igb_uio(self):
> +        self.dut.send_expect("modprobe uio", "#", 70)
> +        out = self.dut.send_expect("lsmod | grep igb_uio", "#")
> +        if "igb_uio" in out:
> +            self.dut.send_expect("rmmod -f igb_uio", "#", 70)
> +        self.dut.send_expect("insmod ./" + self.target +
> "/kmod/igb_uio.ko", "#", 60)
> +
> +        out = self.dut.send_expect("lsmod | grep igb_uio", "#")
> +        assert ("igb_uio" in out), "Failed to insmod igb_uio"
> +
> +
>      def config_vfs(self, port_id, vfs):
>          """
>          if vfs is 0, call destroy_sriov_vfs_by_port in dut for destory vf.
>          if vfs > 0, call generate_sriov_vfs_by_port generate vf and bind
> igb_uio to vf
>          """
>          if vfs:
> +            self.install_igb_uio()
>              self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio')
>              for port in self.dut.ports_info[port_id]['vfs_port']:
> -                port.bind_driver('igb_uio')
> +               # port.bind_driver('igb_uio')

Since this line is useless, please remove it.

> +                port.bind_driver(self.drivername)
>          else:
>              self.dut.destroy_sriov_vfs_by_port(port_id)
> +
> self.dut.ports_info[port_id]['port'].bind_driver(self.drivername)
> 
> 
>      def set_up(self):
> --
> 1.9.3