From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 54E851B301 for ; Tue, 13 Feb 2018 06:15:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2018 21:15:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,506,1511856000"; d="scan'208";a="17992795" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 12 Feb 2018 21:15:08 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 21:15:08 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Feb 2018 21:15:08 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.125]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 13:15:06 +0800 From: "Liu, Yong" To: "Zhu, ShuaiX" , "dts@dpdk.org" CC: "Zhu, ShuaiX" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed Thread-Index: AQHTo9OogY/tmOZNw0aJ/yDFfXK9p6Ohytyg Date: Tue, 13 Feb 2018 05:15:05 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62F9ECF4@SHSMSX103.ccr.corp.intel.com> References: <1518420805-54567-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1518420805-54567-1-git-send-email-shuaix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFkMTI1N2EtYWQxZi00ZTgwLWJiNGYtMzdhMThlZWI5YjQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKb2pkQjhEWFhcL1wvSit0V3dWcllTclR5ODU2elBPdHU5XC9ucWg5QURKOWJlYmU3ZzllWHU0UEtQXC9CRU5ZYWZxNSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix qinq_packet_filter_VF_queues vfiopci failed X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 05:15:10 -0000 Shuai, DTS framework will guarantee that self.drivername has been insmoded. There'= s no need to install it in the suite. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai > Sent: Monday, February 12, 2018 3:33 PM > To: dts@dpdk.org > Cc: Zhu, ShuaiX > Subject: [dts] [PATCH V1] tests/TestSuite_qinq_filter.py:fix > qinq_packet_filter_VF_queues vfiopci failed >=20 > diff --git a/tests/TestSuite_qinq_filter.py > b/tests/TestSuite_qinq_filter.py > index 3f9c1ac..01b3b96 100644 > --- a/tests/TestSuite_qinq_filter.py > +++ b/tests/TestSuite_qinq_filter.py > @@ -121,17 +121,31 @@ class TestQinqFilter(TestCase): > fw.write(word) > fw.close() >=20 > + def install_igb_uio(self): > + self.dut.send_expect("modprobe uio", "#", 70) > + out =3D self.dut.send_expect("lsmod | grep igb_uio", "#") > + if "igb_uio" in out: > + self.dut.send_expect("rmmod -f igb_uio", "#", 70) > + self.dut.send_expect("insmod ./" + self.target + > "/kmod/igb_uio.ko", "#", 60) > + > + out =3D self.dut.send_expect("lsmod | grep igb_uio", "#") > + assert ("igb_uio" in out), "Failed to insmod igb_uio" > + > + > def config_vfs(self, port_id, vfs): > """ > if vfs is 0, call destroy_sriov_vfs_by_port in dut for destory v= f. > if vfs > 0, call generate_sriov_vfs_by_port generate vf and bind > igb_uio to vf > """ > if vfs: > + self.install_igb_uio() > self.dut.generate_sriov_vfs_by_port(port_id, vfs, 'igb_uio') > for port in self.dut.ports_info[port_id]['vfs_port']: > - port.bind_driver('igb_uio') > + # port.bind_driver('igb_uio') Since this line is useless, please remove it. > + port.bind_driver(self.drivername) > else: > self.dut.destroy_sriov_vfs_by_port(port_id) > + > self.dut.ports_info[port_id]['port'].bind_driver(self.drivername) >=20 >=20 > def set_up(self): > -- > 1.9.3