Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop

["Li, WenjieX A" <wenjiex.a.li@intel.com>]

Hi Lijuan,

Will break the loop if the link status is still down after 10 seconds.  

            port_time_up = 0
            while (port_time_up <= 10) and ("Link status: down" in out):
                time.sleep(1)
                out = self.dut.send_expect("show port info %s" % port_id, "testpmd> ")
                port_time_up += 1
                self.verify("Link status: down" not in out, "Port %s Link down, please check your link" % port_id)

BR,
Wenjie

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Saturday, February 2, 2019 5:31 PM
> To: Zhu, WenhuiX <wenhuix.zhu@intel.com>; dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> Subject: Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop
> 
> Hi wenhui,
> 
> Do you forget to set a condition to break the loop? I assumed you 'd like to
> break the loop if the Link status is up.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
> > Sent: Saturday, February 2, 2019 9:42 AM
> > To: dts@dpdk.org
> > Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
> > Subject: [dts] [PATCH V4] tests/dual_vlan Change the verify outside
> > the loop
> >
> > Verification should be outside the loop of the query port
> >
> > Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
> > ---
> >  tests/TestSuite_dual_vlan.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_dual_vlan.py
> > b/tests/TestSuite_dual_vlan.py index d7fba3d..42497ef 100644
> > --- a/tests/TestSuite_dual_vlan.py
> > +++ b/tests/TestSuite_dual_vlan.py
> > @@ -192,7 +192,7 @@ class TestDualVlan(TestCase):
> >                  time.sleep(1)
> >                  out = self.dut.send_expect("show port info %s" % port_id, "testpmd>
> ")
> >                  port_time_up += 1
> > -                self.verify("Link status: down" not in out, "Port %s Link down, please
> > check your link" % port_id)
> > +            self.verify("Link status: down" not in out, "Port %s Link
> > + down, please check your link" % port_id)
> >
> >      def multimode_test(self, caseIndex):
> >          """
> > --
> > 2.17.2