From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CF1072B87 for ; Fri, 8 Mar 2019 07:07:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 22:07:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,454,1544515200"; d="scan'208";a="139060938" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2019 22:07:36 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 7 Mar 2019 22:07:35 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.121]) with mapi id 14.03.0415.000; Fri, 8 Mar 2019 14:07:33 +0800 From: "Li, WenjieX A" To: "Tu, Lijuan" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Thread-Index: AQHU1NCxtBbW8l6mCkeHIYw1QGPD5KYBPwpw Date: Fri, 8 Mar 2019 06:07:33 +0000 Message-ID: <8688172CD5C0B74590FAE19D9579F94B5365CB61@SHSMSX103.ccr.corp.intel.com> References: <1551841442-21029-1-git-send-email-wenjiex.a.li@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 06:07:38 -0000 According to dpdk commit: a9de470, the autotests app was removed to the "ap= p" folder, and there is no separate build task necessary for building the a= utotests using "make test-build" while "make" covering the autotests build. After compile dpdk with below commands, the related apps will be generated = at x86_64-native-linuxapp-gcc/app/. #cd dpdk #export RTE_TARGET=3Dx86_64-native-linuxapp-gcc #export RTE_SDK=3D`pwd` #make -j 86 install T=3Dx86_64-native-linuxapp-gcc > -----Original Message----- > From: Tu, Lijuan > Sent: Thursday, March 7, 2019 6:30 PM > To: Li, WenjieX A ; dts@dpdk.org > Cc: Li, WenjieX A > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app >=20 > Could you explain why it's unnecessary to build dpdk/test anymore? >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > > Sent: Wednesday, March 6, 2019 11:04 AM > > To: dts@dpdk.org > > Cc: Li, WenjieX A > > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > > build_install_dpdk_test_app > > > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build > > dpdk/test anymore. > > > > Signed-off-by: Wenjie Li > > --- > > framework/project_dpdk.py | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py > > index > > 2ad01e8..6035c68 100644 > > --- a/framework/project_dpdk.py > > +++ b/framework/project_dpdk.py > > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > > # compile > > out =3D self.send_expect("make -j %d install T=3D%s %s" % > > (self.number_of_cores, target, extra_options), "# ", build= _time) > > - #should not check test app compile status, because if test com= pile fail, > > - #all unit test can't exec, but others case will exec successfu= lly > > - self.build_install_dpdk_test_app(target, build_time) > > - > > if("Error" in out or "No rule to make" in out): > > self.logger.error("ERROR - try without '-j'") > > # if Error try to execute make without -j option > > out =3D self.send_expect("make install T=3D%s %s" % (targe= t, > > extra_options), "# ", 120) > > - self.build_install_dpdk_test_app(target, build_time) > > > > assert ("Error" not in out), "Compilation error..." > > assert ("No rule to make" not in out), "No rule to make error.= .." > > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > > out =3D self.send_expect("make -j %d install T=3D%s CC=3Dgcc48= " % > > (self.number_of_cores, > > t= arget), > > "#", build_time) > > - #should not check test app compile status, because if test com= pile fail, > > - #all unit test can't exec, but others case will exec sucessful= l > > - self.build_install_dpdk_test_app(target, build_time, os_type= =3D"freebsd") > > - > > if("Error" in out or "No rule to make" in out): > > self.logger.error("ERROR - try without '-j'") > > # if Error try to execute make without -j option > > out =3D self.send_expect("make install T=3D%s CC=3Dgcc48" = % target, > > "#", build_time) > > - self.build_install_dpdk_test_app(target, build_time, os_ty= pe=3D"freebsd") > > > > assert ("Error" not in out), "Compilation error..." > > assert ("No rule to make" not in out), "No rule to make error.= .." > > > > - def build_install_dpdk_test_app(self, target, build_time, os_type= =3D"linux"): > > - cmd_build_test =3D "make -j %d -C test/" % (self.number_of_cor= es) > > - if os_type =3D=3D "freebsd": > > - cmd_build_test =3D "make -j %d -C test/ CC=3Dgcc48" % > > (self.number_of_cores) > > - > > - self.send_expect(cmd_build_test, "# ", build_time) > > - app_list =3D ['./test/test/test', './test/test-acl/testacl', '= ./test/test- > > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > > - for app in app_list: > > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# "= , 30) > > - > > def prepare_package(self): > > if not self.skip_setup: > > assert (os.path.isfile(self.package) is True), "Invalid pa= ckage" > > -- > > 2.17.2