test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Li, WenjieX A" <wenjiex.a.li@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] test/unit_test_eal: bind ports before verifying result
Date: Fri, 19 Apr 2019 05:03:23 +0000	[thread overview]
Message-ID: <8688172CD5C0B74590FAE19D9579F94B536A9454@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1555649998-13234-1-git-send-email-wenjiex.a.li@intel.com>

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Friday, April 19, 2019 1:00 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] test/unit_test_eal: bind ports before verifying result
> 
> Should bind the ports before verifying result; otherwise, if the case failed, the
> ports are still unbound, it will affect the later tests.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_unit_tests_eal.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
> index 2249113..07d788f 100644
> --- a/tests/TestSuite_unit_tests_eal.py
> +++ b/tests/TestSuite_unit_tests_eal.py
> @@ -321,8 +321,8 @@ class TestUnitTestsEal(TestCase):
>          # on FreeBSD need more time than other OS
>          out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
>          self.dut.send_expect("quit", "# ")
> -        self.verify("Test OK" in out, "Test failed")
>          self.dut.bind_interfaces_linux(driver=self.drivername)
> +        self.verify("Test OK" in out, "Test failed")
> 
>      def test_alarm(self):
>          """
> --
> 2.17.2


  reply	other threads:[~2019-04-19  5:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  4:59 Wenjie Li
2019-04-19  5:03 ` Li, WenjieX A [this message]
2019-04-22 23:45 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8688172CD5C0B74590FAE19D9579F94B536A9454@SHSMSX103.ccr.corp.intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).