From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3F1F1A00E6 for ; Fri, 17 May 2019 03:27:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C556397D; Fri, 17 May 2019 03:27:04 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4253E326C for ; Fri, 17 May 2019 03:27:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 18:27:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,477,1549958400"; d="scan'208";a="172600918" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2019 18:27:01 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:27:00 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 18:27:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.70]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Fri, 17 May 2019 09:26:58 +0800 From: "Li, WenjieX A" To: "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts][PATCH V1] tests/tso: should stop ports before set csum Thread-Index: AQHVDE9KSAwJYuePckiCivsVE+bowqZuhnRw Date: Fri, 17 May 2019 01:26:58 +0000 Message-ID: <8688172CD5C0B74590FAE19D9579F94B536E5DFC@SHSMSX103.ccr.corp.intel.com> References: <1558056527-52378-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1558056527-52378-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/tso: should stop ports before set csum X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Reviewed-by: Wenjie > -----Original Message----- > From: Li, WenjieX A > Sent: Friday, May 17, 2019 9:29 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts][PATCH V1] tests/tso: should stop ports before set csum >=20 > 1. should stop ports before set csum and start ports after the settings 2= . there is > no clear indication of which network card is not supported, will not chec= k the nic > type anymore 3. add tear_down and tear_down_all 4. delete unless > comment/code >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_tso.py | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) >=20 > diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py index > 6735169..5e0dbd5 100644 > --- a/tests/TestSuite_tso.py > +++ b/tests/TestSuite_tso.py > @@ -51,13 +51,6 @@ class TestTSO(TestCase): > """ > Run at the start of each test suite. > """ > - # this feature support Fortville, Niantic > - self.verify(self.nic in ["kawela_2", "niantic", "bartonhills", "= 82545EM", > - "82540EM", "springfountain", "fortville= _eagle", > - "fortville_spirit", "fortville_spirit_s= ingle", > - "redrockcanyou", "atwood", "boulderrapi= d", > "fortpark_TLV","fortville_25g","hi1822", "cavium_a063"], > - "NIC Unsupported: " + str(self.nic)) > - > # Based on h/w type, choose how many ports to use > self.dut_ports =3D self.dut.get_ports(self.nic) >=20 > @@ -72,12 +65,6 @@ class TestTSO(TestCase): > self.frame_sizes =3D [128, 1458] > self.rxfreet_values =3D [0, 8, 16, 32, 64, 128] >=20 > - # self.test_cycles =3D [{'cores': '1S/1C/1T', 'Mpps': {}, 'pct':= {}}, > - # {'cores': '1S/1C/2T', 'Mpps': {}, 'pct': {= }}, > - # {'cores': '1S/2C/1T', 'Mpps': {}, 'pct': {= }}, > - # {'cores': '1S/2C/2T', 'Mpps': {}, 'pct': {= }}, > - # {'cores': '1S/4C/2T', 'Mpps': {}, 'pct': {= }} > - # ] > self.test_cycles =3D [{'cores': '1S/1C/2T', 'Mpps': {}, 'pct': {= }}] >=20 > self.table_header =3D ['Frame Size'] @@ -87,8 +74,6 @@ class > TestTSO(TestCase): >=20 > self.blacklist =3D "" >=20 > - # self.coreMask =3D utils.create_mask(cores) > - > self.headers_size =3D HEADER_SIZE['eth'] + HEADER_SIZE[ > 'ip'] + HEADER_SIZE['tcp'] >=20 > @@ -160,6 +145,7 @@ class TestTSO(TestCase): > cmd =3D "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=3D512 --txd= =3D512 -- > burst=3D32 --rxfreet=3D64 --mbcache=3D128 --portmask=3D%s --txpt=3D36 --t= xht=3D0 -- > txwt=3D0 --txfreet=3D32 --txrst=3D32 " % (self.target, self.coreMask, > self.dut.get_memory_channels(), self.blacklist, self.portMask) > self.dut.send_expect(cmd, "testpmd> ", 120) > self.dut.send_expect("set verbose 1", "testpmd> ", 120) > + self.dut.send_expect("port stop all", "testpmd> ", 120) > self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "t= estpmd> ", > 120) > self.dut.send_expect("csum set udp hw %d" % self.dut_ports[0], "= testpmd> > ", 120) > self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "= testpmd> > ", 120) @@ -176,6 +162,7 @@ class TestTSO(TestCase): >=20 > self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "test= pmd> ", > 120) > self.dut.send_expect("set fwd csum", "testpmd> ", 120) > + self.dut.send_expect("port start all", "testpmd> ", 120) > self.dut.send_expect("start", "testpmd> ") >=20 > self.tester.scapy_foreground() > @@ -226,6 +213,7 @@ class TestTSO(TestCase): > cmd =3D "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=3D512 --txd= =3D512 -- > burst=3D32 --rxfreet=3D64 --mbcache=3D128 --portmask=3D%s --txpt=3D36 --t= xht=3D0 -- > txwt=3D0 --txfreet=3D32 --txrst=3D32 " % (self.target, self.coreMask, > self.dut.get_memory_channels(), self.blacklist, self.portMask) > self.dut.send_expect(cmd, "testpmd> ", 120) > self.dut.send_expect("set verbose 1", "testpmd> ", 120) > + self.dut.send_expect("port stop all", "testpmd> ", 120) > self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "t= estpmd> ", > 120) > self.dut.send_expect("csum set udp hw %d" % self.dut_ports[0], "= testpmd> > ", 120) > self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "= testpmd> > ", 120) @@ -242,6 +230,7 @@ class TestTSO(TestCase): >=20 > self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "test= pmd> ", > 120) > self.dut.send_expect("set fwd csum", "testpmd> ", 120) > + self.dut.send_expect("port start all", "testpmd> ", 120) > self.dut.send_expect("start", "testpmd> ") >=20 > self.tester.scapy_foreground() > @@ -295,6 +284,7 @@ class TestTSO(TestCase): > self.rst_report(command_line + "\n\n", frame=3DTrue, annex= =3DTrue) >=20 > self.dut.send_expect(command_line, "testpmd> ", 120) > + self.dut.send_expect("port stop all", "testpmd> ", 120) > self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0]= , "testpmd> > ", 120) > self.dut.send_expect("csum set udp hw %d" % self.dut_ports[0= ], > "testpmd> ", 120) > self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0= ], "testpmd> > ", 120) @@ -309,6 +299,7 @@ class TestTSO(TestCase): > self.dut.send_expect("csum parse-tunnel on %d" % self.dut_po= rts[1], > "testpmd> ", 120) > self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "= testpmd> ", > 120) > self.dut.send_expect("set fwd csum", "testpmd> ", 120) > + self.dut.send_expect("port start all", "testpmd> ", 120) > self.dut.send_expect("start", "testpmd> ") > for frame_size in self.frame_sizes: > wirespeed =3D self.wirespeed(self.nic, frame_size, 2) @@= -350,3 +341,15 > @@ class TestTSO(TestCase): > self.result_table_add(table_row) >=20 > self.result_table_print() > + def tear_down(self): > + """ > + Run after each test case. > + """ > + self.dut.kill_all() > + time.sleep(2) > + > + def tear_down_all(self): > + """ > + Run after each test suite. > + """ > + pass > -- > 2.17.2