[dts] [PATCH V1] framework: add set_env_variable when reconnet dut

test suite reviews and discussions
 help / color / mirror / Atom feed

* [dts] [PATCH V1] framework: add set_env_variable when reconnet dut
@ 2019-05-30  0:00 lihong
  2019-05-30  7:31 ` Li, WenjieX A
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: lihong @ 2019-05-30  0:00 UTC (permalink / raw)
  To: dts; +Cc: zhaoyan.chen, lihong

When dts lost the session with DUT, it will try to reconnet to DUT,
but it will lose the env config, so add the env config when reconnet
to DUT.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/project_dpdk.py | 11 +++++++----
 framework/test_case.py    |  1 +
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index 6035c68..f113f3e 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -64,10 +64,7 @@ class DPDKdut(Dut):
         self.set_toolchain(target)
 
         # set env variable
-        # These have to be setup all the time. Some tests need to compile
-        # example apps by themselves and will fail otherwise.
-        self.send_expect("export RTE_TARGET=" + target, "#")
-        self.send_expect("export RTE_SDK=`pwd`", "#")
+        self.set_env_variable()
 
         self.set_rxtx_mode()
 
@@ -88,6 +85,12 @@ class DPDKdut(Dut):
             self.bind_interfaces_linux(drivername)
         self.extra_nic_setup()
 
+    def set_env_variable(self):
+        # These have to be setup all the time. Some tests need to compile
+        # example apps by themselves and will fail otherwise.
+        self.send_expect("export RTE_TARGET=" + self.target, "#")
+        self.send_expect("export RTE_SDK=`pwd`", "#")
+
     def setup_modules(self, target, drivername, drivermode):
         """
         Install DPDK required kernel module on DUT.
diff --git a/framework/test_case.py b/framework/test_case.py
index 27d236b..c028492 100644
--- a/framework/test_case.py
+++ b/framework/test_case.py
@@ -135,6 +135,7 @@ class TestCase(object):
             crb.reconnect_session()
             if 'dut' in str(type(crb)):
                 crb.send_expect("cd %s" % crb.base_dir, "#")
+                crb.set_env_variable()
 
         try:
             result = crb.alt_session.check_available()
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] framework: add set_env_variable when reconnet dut
  2019-05-30  0:00 [dts] [PATCH V1] framework: add set_env_variable when reconnet dut lihong
@ 2019-05-30  7:31 ` Li, WenjieX A
  2019-05-30  7:56 ` Chen, Zhaoyan
  2019-06-05  2:09 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Li, WenjieX A @ 2019-05-30  7:31 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Chen, Zhaoyan, Ma, LihongX

Reviewed-by: Wenjie <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, May 30, 2019 8:01 AM
> To: dts@dpdk.org
> Cc: Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework: add set_env_variable when reconnet dut
> 
> When dts lost the session with DUT, it will try to reconnet to DUT, but it will lose
> the env config, so add the env config when reconnet to DUT.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/project_dpdk.py | 11 +++++++----
>  framework/test_case.py    |  1 +
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 6035c68..f113f3e 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -64,10 +64,7 @@ class DPDKdut(Dut):
>          self.set_toolchain(target)
> 
>          # set env variable
> -        # These have to be setup all the time. Some tests need to compile
> -        # example apps by themselves and will fail otherwise.
> -        self.send_expect("export RTE_TARGET=" + target, "#")
> -        self.send_expect("export RTE_SDK=`pwd`", "#")
> +        self.set_env_variable()
> 
>          self.set_rxtx_mode()
> 
> @@ -88,6 +85,12 @@ class DPDKdut(Dut):
>              self.bind_interfaces_linux(drivername)
>          self.extra_nic_setup()
> 
> +    def set_env_variable(self):
> +        # These have to be setup all the time. Some tests need to compile
> +        # example apps by themselves and will fail otherwise.
> +        self.send_expect("export RTE_TARGET=" + self.target, "#")
> +        self.send_expect("export RTE_SDK=`pwd`", "#")
> +
>      def setup_modules(self, target, drivername, drivermode):
>          """
>          Install DPDK required kernel module on DUT.
> diff --git a/framework/test_case.py b/framework/test_case.py index
> 27d236b..c028492 100644
> --- a/framework/test_case.py
> +++ b/framework/test_case.py
> @@ -135,6 +135,7 @@ class TestCase(object):
>              crb.reconnect_session()
>              if 'dut' in str(type(crb)):
>                  crb.send_expect("cd %s" % crb.base_dir, "#")
> +                crb.set_env_variable()
> 
>          try:
>              result = crb.alt_session.check_available()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] framework: add set_env_variable when reconnet dut
  2019-05-30  0:00 [dts] [PATCH V1] framework: add set_env_variable when reconnet dut lihong
  2019-05-30  7:31 ` Li, WenjieX A
@ 2019-05-30  7:56 ` Chen, Zhaoyan
  2019-06-05  2:09 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Chen, Zhaoyan @ 2019-05-30  7:56 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Chen, Zhaoyan

Acked-by: Zhaoyan Chen <zhaoyan.chen@intel.com>

-----Original Message-----
From: Ma, LihongX 
Sent: Thursday, May 30, 2019 8:01 AM
To: dts@dpdk.org
Cc: Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ma, LihongX <lihongx.ma@intel.com>
Subject: [dts][PATCH V1] framework: add set_env_variable when reconnet dut

When dts lost the session with DUT, it will try to reconnet to DUT, but it will lose the env config, so add the env config when reconnet to DUT.

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 framework/project_dpdk.py | 11 +++++++----
 framework/test_case.py    |  1 +
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index 6035c68..f113f3e 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -64,10 +64,7 @@ class DPDKdut(Dut):
         self.set_toolchain(target)
 
         # set env variable
-        # These have to be setup all the time. Some tests need to compile
-        # example apps by themselves and will fail otherwise.
-        self.send_expect("export RTE_TARGET=" + target, "#")
-        self.send_expect("export RTE_SDK=`pwd`", "#")
+        self.set_env_variable()
 
         self.set_rxtx_mode()
 
@@ -88,6 +85,12 @@ class DPDKdut(Dut):
             self.bind_interfaces_linux(drivername)
         self.extra_nic_setup()
 
+    def set_env_variable(self):
+        # These have to be setup all the time. Some tests need to compile
+        # example apps by themselves and will fail otherwise.
+        self.send_expect("export RTE_TARGET=" + self.target, "#")
+        self.send_expect("export RTE_SDK=`pwd`", "#")
+
     def setup_modules(self, target, drivername, drivermode):
         """
         Install DPDK required kernel module on DUT.
diff --git a/framework/test_case.py b/framework/test_case.py index 27d236b..c028492 100644
--- a/framework/test_case.py
+++ b/framework/test_case.py
@@ -135,6 +135,7 @@ class TestCase(object):
             crb.reconnect_session()
             if 'dut' in str(type(crb)):
                 crb.send_expect("cd %s" % crb.base_dir, "#")
+                crb.set_env_variable()
 
         try:
             result = crb.alt_session.check_available()
--
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] framework: add set_env_variable when reconnet dut
  2019-05-30  0:00 [dts] [PATCH V1] framework: add set_env_variable when reconnet dut lihong
  2019-05-30  7:31 ` Li, WenjieX A
  2019-05-30  7:56 ` Chen, Zhaoyan
@ 2019-06-05  2:09 ` Tu, Lijuan
  2 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-06-05  2:09 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Chen, Zhaoyan, Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, May 30, 2019 8:01 AM
> To: dts@dpdk.org
> Cc: Chen, Zhaoyan <zhaoyan.chen@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework: add set_env_variable when reconnet
> dut
> 
> When dts lost the session with DUT, it will try to reconnet to DUT, but it will
> lose the env config, so add the env config when reconnet to DUT.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/project_dpdk.py | 11 +++++++----
>  framework/test_case.py    |  1 +
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 6035c68..f113f3e 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -64,10 +64,7 @@ class DPDKdut(Dut):
>          self.set_toolchain(target)
> 
>          # set env variable
> -        # These have to be setup all the time. Some tests need to compile
> -        # example apps by themselves and will fail otherwise.
> -        self.send_expect("export RTE_TARGET=" + target, "#")
> -        self.send_expect("export RTE_SDK=`pwd`", "#")
> +        self.set_env_variable()
> 
>          self.set_rxtx_mode()
> 
> @@ -88,6 +85,12 @@ class DPDKdut(Dut):
>              self.bind_interfaces_linux(drivername)
>          self.extra_nic_setup()
> 
> +    def set_env_variable(self):
> +        # These have to be setup all the time. Some tests need to compile
> +        # example apps by themselves and will fail otherwise.
> +        self.send_expect("export RTE_TARGET=" + self.target, "#")
> +        self.send_expect("export RTE_SDK=`pwd`", "#")
> +
>      def setup_modules(self, target, drivername, drivermode):
>          """
>          Install DPDK required kernel module on DUT.
> diff --git a/framework/test_case.py b/framework/test_case.py index
> 27d236b..c028492 100644
> --- a/framework/test_case.py
> +++ b/framework/test_case.py
> @@ -135,6 +135,7 @@ class TestCase(object):
>              crb.reconnect_session()
>              if 'dut' in str(type(crb)):
>                  crb.send_expect("cd %s" % crb.base_dir, "#")
> +                crb.set_env_variable()
> 
>          try:
>              result = crb.alt_session.check_available()
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-05  2:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30  0:00 [dts] [PATCH V1] framework: add set_env_variable when reconnet dut lihong
2019-05-30  7:31 ` Li, WenjieX A
2019-05-30  7:56 ` Chen, Zhaoyan
2019-06-05  2:09 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).