Re: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w

["Li, WenjieX A" <wenjiex.a.li@intel.com>]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Tuesday, August 20, 2019 3:09 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests/enable_package_download_in_ice_driver:add all
> ports with -w
> 
> Should add ALL ports with -w parameter.
> If the nic has 4 ports, all ports should be bind with -w; otherwise, the ports will
> be down in testpmd.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py
> b/tests/TestSuite_enable_package_download_in_ice_driver.py
> index 9197198..b225ef3 100644
> --- a/tests/TestSuite_enable_package_download_in_ice_driver.py
> +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
> @@ -54,9 +54,6 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>          self.tester_p0_mac = self.tester.get_mac(localPort0)
>          self.dut_testpmd = PmdOutput(self.dut)
> 
> -        self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0])
> -        self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1])
> -
>          self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg'
>          out = self.dut.send_expect("ls %s" % self.pkg_file, "#")
>          self.verify("No such file or directory" not in out, "Cannot find %s, please
> check you system/driver." % self.pkg_file) @@ -88,10 +85,10 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>              self.dut.send_expect("touch %s" % self.pkg_file, "#")
> 
>      def start_testpmd(self, ice_pkg="true", safe_mode_support="false"):
> +        self.eal_param = ""
>          if safe_mode_support == "true":
> -            self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-
> support=1" % (self.dut_p0_pci, self.dut_p1_pci)
> -        else:
> -            self.eal_param=""
> +            for i in range(len(self.dut_ports)):
> +                self.eal_param = self.eal_param + "-w
> + %s,safe-mode-support=1 " % self.dut.ports_info[i]['pci']
>          out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --
> txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE),
> eal_param=self.eal_param)
>          if ice_pkg == "false":
>              if safe_mode_support == "true":
> --
> 2.17.1