From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 510FDA2EFC for ; Mon, 16 Sep 2019 10:36:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A0D51C119; Mon, 16 Sep 2019 10:36:05 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 253481C08C for ; Mon, 16 Sep 2019 10:36:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 01:36:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="180366829" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2019 01:36:00 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 01:36:00 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.140]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Mon, 16 Sep 2019 16:35:58 +0800 From: "Li, WenjieX A" To: "Mo, YufengX" , "dts@dpdk.org" , "Peng, ZhihongX" , "Zhang, YanX A" CC: "Yu, PingX" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to Thread-Index: AQHVbFVdJbErBjKPh0CJOPTHm1dxEKct+QuggAABxjA= Date: Mon, 16 Sep 2019 08:35:58 +0000 Message-ID: <8688172CD5C0B74590FAE19D9579F94B53799EDB@SHSMSX103.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: multipart/mixed; boundary="_002_8688172CD5C0B74590FAE19D9579F94B53799EDBSHSMSX103ccrcor_" MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --_002_8688172CD5C0B74590FAE19D9579F94B53799EDBSHSMSX103ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable FYI > -----Original Message----- > From: Mo, YufengX > Sent: Monday, September 16, 2019 4:32 PM > To: dts@dpdk.org; Peng, ZhihongX ; Li, WenjieX A > ; Zhang, YanX A > Cc: Yu, PingX > Subject: RE: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func in= crease > kill testpmd statement. check_packet_transmission func exiting abnormally > willcause testpmd to not exit. The next test case continues to use untest= ed > testpmd, causing the test case to >=20 > Hi, peng zhihong >=20 > Li,wenjie has one patch to do the same thing. Could you sync with him? >=20 > [dts] [PATCH V1] tests/ipgre: optimize script >=20 > BRs > Yufen, Mo >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong > > Sent: Monday, September 16, 2019 10:10 PM > > To: dts@dpdk.org > > Cc: Peng, ZhihongX ; Peng@dpdk.org > > Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func > > increase kill testpmd statement. check_packet_transmission func exiting > abnormally willcause testpmd to not exit. The next test case continues to= use > untested testpmd, causing the test case to f... > > > > From: "Peng, ZhihongX" > > > > Signed-off-by: Peng, ZhihongX > > --- > > tests/TestSuite_ipgre.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index > > d74ac05..d1db8df 100644 > > --- a/tests/TestSuite_ipgre.py > > +++ b/tests/TestSuite_ipgre.py > > @@ -439,6 +439,7 @@ class TestIpgre(TestCase): > > Run after each test case. > > Nothing to do. > > """ > > + self.dut.kill_all() > > pass > > > > def tear_down_all(self): > > -- > > 2.17.1 --_002_8688172CD5C0B74590FAE19D9579F94B53799EDBSHSMSX103ccrcor_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Mon, 16 Sep 2019 08:35:58 GMT"; modification-date="Mon, 16 Sep 2019 08:35:58 GMT" Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by SHSMSX154.ccr.corp.intel.com (10.239.6.54) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Sep 2019 17:49:00 +0800 Received: from fmsmsx108.amr.corp.intel.com (10.18.124.206) by SHSMSX103.ccr.corp.intel.com (10.239.4.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Sep 2019 17:49:00 +0800 Received: from fmsmga001.fm.intel.com (10.253.24.23) by FMSMSX108.amr.corp.intel.com (10.18.124.215) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Sep 2019 02:48:58 -0700 Received: from unknown (HELO dpdk-wenjielx-KVM193.icx.intel.com) ([10.240.176.193]) by fmsmga001.fm.intel.com with ESMTP; 06 Sep 2019 02:48:57 -0700 From: "Li, WenjieX A" To: "dts@dpdk.org" CC: "Li, WenjieX A" Subject: [dts][PATCH V1] tests/ipgre: optimize script Thread-Topic: [dts][PATCH V1] tests/ipgre: optimize script Thread-Index: AQHVZJhPbRuVI0a/tkyAbLXJEe9+yw== Date: Fri, 6 Sep 2019 18:42:30 +0000 Message-ID: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com> Content-Language: zh-CN X-MS-Exchange-Organization-AuthMechanism: 10 X-MS-Exchange-Organization-AuthSource: FMSMSX108.amr.corp.intel.com X-MS-Has-Attach: X-Message-Flag: Follow up X-MS-TNEF-Correlator: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from tear_down_all to tear_down, since testpmd will be started in every case, if one case is failed, the testpmd is still runnning, this will affect the following cases. Signed-off-by: Wenjie Li --- tests/TestSuite_ipgre.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7fbddf1..e10b0e0 100644 --- a/tests/TestSuite_ipgre.py +++ b/tests/TestSuite_ipgre.py @@ -63,7 +63,7 @@ class TestIpgre(TestCase): """ self.printFlag =3D self._enable_debug ports =3D self.dut.get_ports() - self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "f= ortville_spirit_single", "fortville_25g", "carlsville"], + self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "f= ortville_spirit_single", "fortville_25g", "carlsville", "columbiaville_25g"= , "columbiaville_100g"], "GRE tunnel packet type only support by fortville and = carlsville") self.verify(len(ports) >=3D 1, "Insufficient ports for testing") valports =3D [_ for _ in ports if self.tester.get_local_port(_) != =3D -1] @@ -439,12 +439,11 @@ class TestIpgre(TestCase): Run after each test case. Nothing to do. """ - pass + self.dut.kill_all() def tear_down_all(self): """ Run after each test suite. Nothing to do. """ - self.dut.kill_all() pass -- 2.17.1 --_002_8688172CD5C0B74590FAE19D9579F94B53799EDBSHSMSX103ccrcor_--