[dts] [PATCH V1] tests/fdir: ensure port is up before send packets

[dts] [PATCH V1] tests/fdir: ensure port is up before send packets

[Wenjie Li]

ensure the port is up before send packets; if the port is down, wait for
at most 15s, then return failure with 'link is down'.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_fdir.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
index 9f5a812..d74a06e 100644
--- a/tests/TestSuite_fdir.py
+++ b/tests/TestSuite_fdir.py
@@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
         """
         self.scapyCmds.append(packet)
         self.dut.send_expect("start", "testpmd>")
+
+        self.pmd_output = PmdOutput(self.dut)
+        res = self.pmd_output.wait_link_status_up('all', timeout=15)
+        self.verify(res is True, 'there have port link is down')
+
         self.scapy_execute()
         time.sleep(.5)
         out = self.dut.get_session_output()
-- 
2.17.1

Re: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets

[Li, WenjieX A]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Saturday, October 19, 2019 1:01 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests/fdir: ensure port is up before send packets
> 
> ensure the port is up before send packets; if the port is down, wait for at most
> 15s, then return failure with 'link is down'.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_fdir.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index
> 9f5a812..d74a06e 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          """
>          self.scapyCmds.append(packet)
>          self.dut.send_expect("start", "testpmd>")
> +
> +        self.pmd_output = PmdOutput(self.dut)
> +        res = self.pmd_output.wait_link_status_up('all', timeout=15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.scapy_execute()
>          time.sleep(.5)
>          out = self.dut.get_session_output()
> --
> 2.17.1


[-- Attachment #2: TestFdir.log --]
[-- Type: application/octet-stream, Size: 944573 bytes --]

Re: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Saturday, October 19, 2019 1:01 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets
> 
> ensure the port is up before send packets; if the port is down, wait for at
> most 15s, then return failure with 'link is down'.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_fdir.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index
> 9f5a812..d74a06e 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          """
>          self.scapyCmds.append(packet)
>          self.dut.send_expect("start", "testpmd>")
> +
> +        self.pmd_output = PmdOutput(self.dut)
> +        res = self.pmd_output.wait_link_status_up('all', timeout=15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.scapy_execute()
>          time.sleep(.5)
>          out = self.dut.get_session_output()
> --
> 2.17.1