test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel
@ 2019-02-25  1:49 yaobing
  2019-02-25  2:57 ` Zhu, WenhuiX
  2019-02-25  9:13 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: yaobing @ 2019-02-25  1:49 UTC (permalink / raw)
  To: dts; +Cc: yaobing

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/tso to fit this changement.

Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_tso.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py
index 0a9d66c..8dc84c2 100644
--- a/tests/TestSuite_tso.py
+++ b/tests/TestSuite_tso.py
@@ -165,14 +165,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120)
@@ -231,14 +231,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120)
@@ -300,13 +300,13 @@ class TestTSO(TestCase):
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("set fwd csum", "testpmd> ", 120)
             self.dut.send_expect("start", "testpmd> ")
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel
  2019-02-25  1:49 [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel yaobing
@ 2019-02-25  2:57 ` Zhu, WenhuiX
  2019-02-25  9:13 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-02-25  2:57 UTC (permalink / raw)
  To: Yao, BingX Y, dts; +Cc: Yao, BingX Y

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
Sent: Monday, February 25, 2019 9:49 AM
To: dts@dpdk.org
Cc: Yao, BingX Y <bingx.y.yao@intel.com>
Subject: [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/tso to fit this changement.

Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_tso.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py index 0a9d66c..8dc84c2 100644
--- a/tests/TestSuite_tso.py
+++ b/tests/TestSuite_tso.py
@@ -165,14 +165,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120) @@ -231,14 +231,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120) @@ -300,13 +300,13 @@ class TestTSO(TestCase):
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % 
+ self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("set fwd csum", "testpmd> ", 120)
             self.dut.send_expect("start", "testpmd> ")
--
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel
  2019-02-25  1:49 [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel yaobing
  2019-02-25  2:57 ` Zhu, WenhuiX
@ 2019-02-25  9:13 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-02-25  9:13 UTC (permalink / raw)
  To: Yao, BingX Y, dts; +Cc: Yao, BingX Y

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Monday, February 25, 2019 9:49 AM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel
> 
> In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
>     app/testpmd: fix csum parse-tunnel command invocation
>     Based on the documentation and help print, the sub command
>     for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
>     in app/test-pmd/cmdline.c.
> Update tests/tso to fit this changement.
> 
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>  tests/TestSuite_tso.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py index
> 0a9d66c..8dc84c2 100644
> --- a/tests/TestSuite_tso.py
> +++ b/tests/TestSuite_tso.py
> @@ -165,14 +165,14 @@ class TestTSO(TestCase):
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0],
> "testpmd> ", 120)
> +        self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[0], "testpmd> ", 120)
> 
>          self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ",
> 120)
>          self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1],
> "testpmd> ", 120)
> +        self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[1], "testpmd> ", 120)
> 
>          self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ",
> 120)
>          self.dut.send_expect("set fwd csum", "testpmd> ", 120) @@ -231,14
> +231,14 @@ class TestTSO(TestCase):
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0],
> "testpmd> ", 120)
> +        self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[0], "testpmd> ", 120)
> 
>          self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ",
> 120)
>          self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1],
> "testpmd> ", 120)
> +        self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[1], "testpmd> ", 120)
> 
>          self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ",
> 120)
>          self.dut.send_expect("set fwd csum", "testpmd> ", 120) @@ -300,13
> +300,13 @@ class TestTSO(TestCase):
>              self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>              self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
>              self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> -            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0],
> "testpmd> ", 120)
> +            self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[0], "testpmd> ", 120)
>              self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>              self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
>              self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>              self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
>              self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> -            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1],
> "testpmd> ", 120)
> +            self.dut.send_expect("csum parse-tunnel on %d" %
> + self.dut_ports[1], "testpmd> ", 120)
>              self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ",
> 120)
>              self.dut.send_expect("set fwd csum", "testpmd> ", 120)
>              self.dut.send_expect("start", "testpmd> ")
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-25  9:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25  1:49 [dts] [PATCH V1] tests/tso:change parse_tunnel to parse-tunnel yaobing
2019-02-25  2:57 ` Zhu, WenhuiX
2019-02-25  9:13 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).