From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A7A5E235 for ; Mon, 25 Feb 2019 11:13:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2019 02:13:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,411,1544515200"; d="scan'208";a="129124641" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 25 Feb 2019 02:13:51 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 02:13:49 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 25 Feb 2019 02:13:48 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.109]) with mapi id 14.03.0415.000; Mon, 25 Feb 2019 18:13:47 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop Thread-Index: AQHUupf0Fwj7aydUuEW3YcVYzjMK26XwcFzg Date: Mon, 25 Feb 2019 10:13:46 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA26CA2@SHSMSX101.ccr.corp.intel.com> References: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjVjOGU5ZWEtY2IwZC00Mjg5LTg3YzItYTA1ZTZjMjhjOGJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK3dPTWxONlJMV01pTFBcL2l4QWtlQnNydXpCY1ZcL3RsaVJ6VDNaOEhMOWFkajVLUUU5dFpnVWR6cnFlTGl6bGhsIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 10:13:53 -0000 Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Saturday, February 2, 2019 9:42 AM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the l= oop >=20 > Verification should be outside the loop of the query port >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_dual_vlan.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py = index > d7fba3d..42497ef 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -192,7 +192,7 @@ class TestDualVlan(TestCase): > time.sleep(1) > out =3D self.dut.send_expect("show port info %s" % port_= id, "testpmd> ") > port_time_up +=3D 1 > - self.verify("Link status: down" not in out, "Port %s Lin= k down, please > check your link" % port_id) > + self.verify("Link status: down" not in out, "Port %s Link > + down, please check your link" % port_id) >=20 > def multimode_test(self, caseIndex): > """ > -- > 2.17.2