test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dts] [PATCH V2]tests: change the pass criteria for kni statistic
Date: Thu, 7 Mar 2019 10:16:55 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6B3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1551794475-87562-1-git-send-email-lei.a.yao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lei
> Sent: Tuesday, March 5, 2019 10:01 PM
> To: dts@dpdk.org
> Cc: Yao, Lei A <lei.a.yao@intel.com>
> Subject: [dts] [PATCH V2]tests: change the pass criteria for kni statistic
> 
> From: Lei Yao <lei.a.yao@intel.com>
> 
> On some platform, because the LLDP packets, the packet statisic number will
> not be so accurate
> 
> Signed-off-by: Lei Yao <lei.a.yao@intel.com>
> ---
>  tests/TestSuite_kni.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index
> 2581802..641d8b0 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -767,22 +767,22 @@ class TestKni(TestCase):
>              self.tester.scapy_append('srcmac = "%s"' % tx_mac)
> 
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s")' %
> tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src = srcmac,dst=dstmac)/("X"*46)],iface="%s")' %
> tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/("X"*46)],iface="%s",count=200)' % tx_interface)
>              self.tester.scapy_execute()
> 
>              out = self.dut.send_expect("ifconfig %s" % virtual_interface, "# ")
>              m = re.search(rx_match, out)
>              rx_packets = int(m.group(1))
> 
> -            self.verify(rx_packets == (previous_rx_packets + 5),
> +            self.verify(rx_packets == (previous_rx_packets + 1000),
>                          "Rx statistics error in iface %s" % virtual_interface)
> 
>          self.dut.kill_all()
> --
> 2.7.4

      reply	other threads:[~2019-03-07 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 14:01 Lei
2019-03-07 10:16 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6B3@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lei.a.yao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).