test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2]tests: change the pass criteria for kni statistic
@ 2019-03-05 14:01 Lei
  2019-03-07 10:16 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lei @ 2019-03-05 14:01 UTC (permalink / raw)
  To: dts; +Cc: Lei Yao

From: Lei Yao <lei.a.yao@intel.com>

On some platform, because the LLDP packets, the packet statisic
number will not be so accurate

Signed-off-by: Lei Yao <lei.a.yao@intel.com>
---
 tests/TestSuite_kni.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index 2581802..641d8b0 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -767,22 +767,22 @@ class TestKni(TestCase):
             self.tester.scapy_append('srcmac = "%s"' % tx_mac)
 
             self.tester.scapy_append(
-                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s")' % tx_interface)
+                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s",count=200)' % tx_interface)
             self.tester.scapy_append(
-                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s")' % tx_interface)
+                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s",count=200)' % tx_interface)
             self.tester.scapy_append(
-                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s")' % tx_interface)
+                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s",count=200)' % tx_interface)
             self.tester.scapy_append(
-                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s")' % tx_interface)
+                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s",count=200)' % tx_interface)
             self.tester.scapy_append(
-                'sendp([Ether(src = srcmac,dst=dstmac)/("X"*46)],iface="%s")' % tx_interface)
+                'sendp([Ether(src = srcmac,dst=dstmac)/("X"*46)],iface="%s",count=200)' % tx_interface)
             self.tester.scapy_execute()
 
             out = self.dut.send_expect("ifconfig %s" % virtual_interface, "# ")
             m = re.search(rx_match, out)
             rx_packets = int(m.group(1))
 
-            self.verify(rx_packets == (previous_rx_packets + 5),
+            self.verify(rx_packets == (previous_rx_packets + 1000),
                         "Rx statistics error in iface %s" % virtual_interface)
 
         self.dut.kill_all()
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2]tests: change the pass criteria for kni statistic
  2019-03-05 14:01 [dts] [PATCH V2]tests: change the pass criteria for kni statistic Lei
@ 2019-03-07 10:16 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-03-07 10:16 UTC (permalink / raw)
  To: Yao, Lei A, dts; +Cc: Yao, Lei A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lei
> Sent: Tuesday, March 5, 2019 10:01 PM
> To: dts@dpdk.org
> Cc: Yao, Lei A <lei.a.yao@intel.com>
> Subject: [dts] [PATCH V2]tests: change the pass criteria for kni statistic
> 
> From: Lei Yao <lei.a.yao@intel.com>
> 
> On some platform, because the LLDP packets, the packet statisic number will
> not be so accurate
> 
> Signed-off-by: Lei Yao <lei.a.yao@intel.com>
> ---
>  tests/TestSuite_kni.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index
> 2581802..641d8b0 100644
> --- a/tests/TestSuite_kni.py
> +++ b/tests/TestSuite_kni.py
> @@ -767,22 +767,22 @@ class TestKni(TestCase):
>              self.tester.scapy_append('srcmac = "%s"' % tx_mac)
> 
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/UDP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/TCP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src =
> srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s")' % tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/ICMP()/("X"*28)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src = srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s")' %
> tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/IP()/("X"*38)],iface="%s",count=200)' %
> + tx_interface)
>              self.tester.scapy_append(
> -                'sendp([Ether(src = srcmac,dst=dstmac)/("X"*46)],iface="%s")' %
> tx_interface)
> +                'sendp([Ether(src =
> + srcmac,dst=dstmac)/("X"*46)],iface="%s",count=200)' % tx_interface)
>              self.tester.scapy_execute()
> 
>              out = self.dut.send_expect("ifconfig %s" % virtual_interface, "# ")
>              m = re.search(rx_match, out)
>              rx_packets = int(m.group(1))
> 
> -            self.verify(rx_packets == (previous_rx_packets + 5),
> +            self.verify(rx_packets == (previous_rx_packets + 1000),
>                          "Rx statistics error in iface %s" % virtual_interface)
> 
>          self.dut.kill_all()
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-07 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 14:01 [dts] [PATCH V2]tests: change the pass criteria for kni statistic Lei
2019-03-07 10:16 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).