From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app
Date: Thu, 7 Mar 2019 10:29:48 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1551841442-21029-1-git-send-email-wenjiex.a.li@intel.com>
Could you explain why it's unnecessary to build dpdk/test anymore?
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Wednesday, March 6, 2019 11:04 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V2] framwork/project_dpdk: remove
> build_install_dpdk_test_app
>
> DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build dpdk/test
> anymore.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
> framework/project_dpdk.py | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 2ad01e8..6035c68 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -217,15 +217,10 @@ class DPDKdut(Dut):
> # compile
> out = self.send_expect("make -j %d install T=%s %s" %
> (self.number_of_cores, target, extra_options), "# ", build_time)
> - #should not check test app compile status, because if test compile fail,
> - #all unit test can't exec, but others case will exec successfully
> - self.build_install_dpdk_test_app(target, build_time)
> -
> if("Error" in out or "No rule to make" in out):
> self.logger.error("ERROR - try without '-j'")
> # if Error try to execute make without -j option
> out = self.send_expect("make install T=%s %s" % (target, extra_options),
> "# ", 120)
> - self.build_install_dpdk_test_app(target, build_time)
>
> assert ("Error" not in out), "Compilation error..."
> assert ("No rule to make" not in out), "No rule to make error..."
> @@ -244,30 +239,15 @@ class DPDKdut(Dut):
> out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> target),
> "#", build_time)
> - #should not check test app compile status, because if test compile fail,
> - #all unit test can't exec, but others case will exec sucessfull
> - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd")
> -
> if("Error" in out or "No rule to make" in out):
> self.logger.error("ERROR - try without '-j'")
> # if Error try to execute make without -j option
> out = self.send_expect("make install T=%s CC=gcc48" % target,
> "#", build_time)
> - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd")
>
> assert ("Error" not in out), "Compilation error..."
> assert ("No rule to make" not in out), "No rule to make error..."
>
> - def build_install_dpdk_test_app(self, target, build_time, os_type="linux"):
> - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores)
> - if os_type == "freebsd":
> - cmd_build_test = "make -j %d -C test/ CC=gcc48" %
> (self.number_of_cores)
> -
> - self.send_expect(cmd_build_test, "# ", build_time)
> - app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-
> pipeline/testpipeline', './test/cmdline_test/cmdline_test']
> - for app in app_list:
> - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30)
> -
> def prepare_package(self):
> if not self.skip_setup:
> assert (os.path.isfile(self.package) is True), "Invalid package"
> --
> 2.17.2
next prev parent reply other threads:[~2019-03-07 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 3:04 Wenjie Li
2019-03-06 5:55 ` Zhu, ShuaiX
2019-03-07 10:29 ` Tu, Lijuan [this message]
2019-03-08 6:07 ` Li, WenjieX A
2019-03-09 6:54 ` Rami Rosen
2019-03-14 8:46 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=wenjiex.a.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).