From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DD44D1DA4 for ; Thu, 7 Mar 2019 11:29:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 02:29:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="139909322" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 07 Mar 2019 02:29:51 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 7 Mar 2019 02:29:51 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 7 Mar 2019 02:29:50 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000; Thu, 7 Mar 2019 18:29:49 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Thread-Index: AQHU08jAuUmyawZpwU68M6l2OlsL+aX/+asw Date: Thu, 7 Mar 2019 10:29:48 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com> References: <1551841442-21029-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1551841442-21029-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGM4NmJiYmEtOGFjYy00YTZiLTg1MjMtN2U5NDBjNTE5NGRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic0xSSzlpamZ2N3RRd3RkejF6RXhYYk1ITmtxbGlqdjF1K3lDaU91bVFhYVBRRzZoUmhPUWM1c2dUOURwb1pxZyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 10:29:53 -0000 Could you explain why it's unnecessary to build dpdk/test anymore? > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Wednesday, March 6, 2019 11:04 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app >=20 > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build dpdk/te= st > anymore. >=20 > Signed-off-by: Wenjie Li > --- > framework/project_dpdk.py | 20 -------------------- > 1 file changed, 20 deletions(-) >=20 > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index > 2ad01e8..6035c68 100644 > --- a/framework/project_dpdk.py > +++ b/framework/project_dpdk.py > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > # compile > out =3D self.send_expect("make -j %d install T=3D%s %s" % > (self.number_of_cores, target, extra_options), "# ", build_t= ime) > - #should not check test app compile status, because if test compi= le fail, > - #all unit test can't exec, but others case will exec successfull= y > - self.build_install_dpdk_test_app(target, build_time) > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out =3D self.send_expect("make install T=3D%s %s" % (target,= extra_options), > "# ", 120) > - self.build_install_dpdk_test_app(target, build_time) >=20 > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error...= " > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > out =3D self.send_expect("make -j %d install T=3D%s CC=3Dgcc48" = % > (self.number_of_cores, > tar= get), > "#", build_time) > - #should not check test app compile status, because if test compi= le fail, > - #all unit test can't exec, but others case will exec sucessfull > - self.build_install_dpdk_test_app(target, build_time, os_type=3D"= freebsd") > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out =3D self.send_expect("make install T=3D%s CC=3Dgcc48" % = target, > "#", build_time) > - self.build_install_dpdk_test_app(target, build_time, os_type= =3D"freebsd") >=20 > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error...= " >=20 > - def build_install_dpdk_test_app(self, target, build_time, os_type=3D= "linux"): > - cmd_build_test =3D "make -j %d -C test/" % (self.number_of_cores= ) > - if os_type =3D=3D "freebsd": > - cmd_build_test =3D "make -j %d -C test/ CC=3Dgcc48" % > (self.number_of_cores) > - > - self.send_expect(cmd_build_test, "# ", build_time) > - app_list =3D ['./test/test/test', './test/test-acl/testacl', './= test/test- > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > - for app in app_list: > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", = 30) > - > def prepare_package(self): > if not self.skip_setup: > assert (os.path.isfile(self.package) is True), "Invalid pack= age" > -- > 2.17.2