* [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app @ 2019-03-06 3:04 Wenjie Li 2019-03-06 5:55 ` Zhu, ShuaiX 2019-03-07 10:29 ` Tu, Lijuan 0 siblings, 2 replies; 6+ messages in thread From: Wenjie Li @ 2019-03-06 3:04 UTC (permalink / raw) To: dts; +Cc: Wenjie Li DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build dpdk/test anymore. Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com> --- framework/project_dpdk.py | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index 2ad01e8..6035c68 100644 --- a/framework/project_dpdk.py +++ b/framework/project_dpdk.py @@ -217,15 +217,10 @@ class DPDKdut(Dut): # compile out = self.send_expect("make -j %d install T=%s %s" % (self.number_of_cores, target, extra_options), "# ", build_time) - #should not check test app compile status, because if test compile fail, - #all unit test can't exec, but others case will exec successfully - self.build_install_dpdk_test_app(target, build_time) - if("Error" in out or "No rule to make" in out): self.logger.error("ERROR - try without '-j'") # if Error try to execute make without -j option out = self.send_expect("make install T=%s %s" % (target, extra_options), "# ", 120) - self.build_install_dpdk_test_app(target, build_time) assert ("Error" not in out), "Compilation error..." assert ("No rule to make" not in out), "No rule to make error..." @@ -244,30 +239,15 @@ class DPDKdut(Dut): out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores, target), "#", build_time) - #should not check test app compile status, because if test compile fail, - #all unit test can't exec, but others case will exec sucessfull - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") - if("Error" in out or "No rule to make" in out): self.logger.error("ERROR - try without '-j'") # if Error try to execute make without -j option out = self.send_expect("make install T=%s CC=gcc48" % target, "#", build_time) - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") assert ("Error" not in out), "Compilation error..." assert ("No rule to make" not in out), "No rule to make error..." - def build_install_dpdk_test_app(self, target, build_time, os_type="linux"): - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores) - if os_type == "freebsd": - cmd_build_test = "make -j %d -C test/ CC=gcc48" % (self.number_of_cores) - - self.send_expect(cmd_build_test, "# ", build_time) - app_list = ['./test/test/test', './test/test-acl/testacl', './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test'] - for app in app_list: - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) - def prepare_package(self): if not self.skip_setup: assert (os.path.isfile(self.package) is True), "Invalid package" -- 2.17.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app 2019-03-06 3:04 [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Wenjie Li @ 2019-03-06 5:55 ` Zhu, ShuaiX 2019-03-07 10:29 ` Tu, Lijuan 1 sibling, 0 replies; 6+ messages in thread From: Zhu, ShuaiX @ 2019-03-06 5:55 UTC (permalink / raw) To: Li, WenjieX A, dts; +Cc: Li, WenjieX A, Zhu, ShuaiX Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com> > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Wednesday, March 6, 2019 11:04 AM > To: dts@dpdk.org > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build dpdk/test > anymore. > > Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com> > --- > framework/project_dpdk.py | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index > 2ad01e8..6035c68 100644 > --- a/framework/project_dpdk.py > +++ b/framework/project_dpdk.py > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > # compile > out = self.send_expect("make -j %d install T=%s %s" % > (self.number_of_cores, target, extra_options), "# ", > build_time) > - #should not check test app compile status, because if test compile > fail, > - #all unit test can't exec, but others case will exec successfully > - self.build_install_dpdk_test_app(target, build_time) > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out = self.send_expect("make install T=%s %s" % (target, > extra_options), "# ", 120) > - self.build_install_dpdk_test_app(target, build_time) > > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error..." > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > out = self.send_expect("make -j %d install T=%s CC=gcc48" % > (self.number_of_cores, > > target), > "#", build_time) > - #should not check test app compile status, because if test compile > fail, > - #all unit test can't exec, but others case will exec sucessfull > - self.build_install_dpdk_test_app(target, build_time, > os_type="freebsd") > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out = self.send_expect("make install T=%s CC=gcc48" % > target, > "#", build_time) > - self.build_install_dpdk_test_app(target, build_time, > os_type="freebsd") > > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error..." > > - def build_install_dpdk_test_app(self, target, build_time, > os_type="linux"): > - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores) > - if os_type == "freebsd": > - cmd_build_test = "make -j %d -C test/ CC=gcc48" % > (self.number_of_cores) > - > - self.send_expect(cmd_build_test, "# ", build_time) > - app_list = ['./test/test/test', './test/test-acl/testacl', > './test/test-pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > - for app in app_list: > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) > - > def prepare_package(self): > if not self.skip_setup: > assert (os.path.isfile(self.package) is True), "Invalid package" > -- > 2.17.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app 2019-03-06 3:04 [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Wenjie Li 2019-03-06 5:55 ` Zhu, ShuaiX @ 2019-03-07 10:29 ` Tu, Lijuan 2019-03-08 6:07 ` Li, WenjieX A 1 sibling, 1 reply; 6+ messages in thread From: Tu, Lijuan @ 2019-03-07 10:29 UTC (permalink / raw) To: Li, WenjieX A, dts; +Cc: Li, WenjieX A Could you explain why it's unnecessary to build dpdk/test anymore? > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Wednesday, March 6, 2019 11:04 AM > To: dts@dpdk.org > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build dpdk/test > anymore. > > Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com> > --- > framework/project_dpdk.py | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index > 2ad01e8..6035c68 100644 > --- a/framework/project_dpdk.py > +++ b/framework/project_dpdk.py > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > # compile > out = self.send_expect("make -j %d install T=%s %s" % > (self.number_of_cores, target, extra_options), "# ", build_time) > - #should not check test app compile status, because if test compile fail, > - #all unit test can't exec, but others case will exec successfully > - self.build_install_dpdk_test_app(target, build_time) > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out = self.send_expect("make install T=%s %s" % (target, extra_options), > "# ", 120) > - self.build_install_dpdk_test_app(target, build_time) > > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error..." > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > out = self.send_expect("make -j %d install T=%s CC=gcc48" % > (self.number_of_cores, > target), > "#", build_time) > - #should not check test app compile status, because if test compile fail, > - #all unit test can't exec, but others case will exec sucessfull > - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") > - > if("Error" in out or "No rule to make" in out): > self.logger.error("ERROR - try without '-j'") > # if Error try to execute make without -j option > out = self.send_expect("make install T=%s CC=gcc48" % target, > "#", build_time) > - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") > > assert ("Error" not in out), "Compilation error..." > assert ("No rule to make" not in out), "No rule to make error..." > > - def build_install_dpdk_test_app(self, target, build_time, os_type="linux"): > - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores) > - if os_type == "freebsd": > - cmd_build_test = "make -j %d -C test/ CC=gcc48" % > (self.number_of_cores) > - > - self.send_expect(cmd_build_test, "# ", build_time) > - app_list = ['./test/test/test', './test/test-acl/testacl', './test/test- > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > - for app in app_list: > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) > - > def prepare_package(self): > if not self.skip_setup: > assert (os.path.isfile(self.package) is True), "Invalid package" > -- > 2.17.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app 2019-03-07 10:29 ` Tu, Lijuan @ 2019-03-08 6:07 ` Li, WenjieX A 2019-03-09 6:54 ` Rami Rosen 2019-03-14 8:46 ` Tu, Lijuan 0 siblings, 2 replies; 6+ messages in thread From: Li, WenjieX A @ 2019-03-08 6:07 UTC (permalink / raw) To: Tu, Lijuan, dts; +Cc: Li, WenjieX A According to dpdk commit: a9de470, the autotests app was removed to the "app" folder, and there is no separate build task necessary for building the autotests using "make test-build" while "make" covering the autotests build. After compile dpdk with below commands, the related apps will be generated at x86_64-native-linuxapp-gcc/app/. #cd dpdk #export RTE_TARGET=x86_64-native-linuxapp-gcc #export RTE_SDK=`pwd` #make -j 86 install T=x86_64-native-linuxapp-gcc > -----Original Message----- > From: Tu, Lijuan > Sent: Thursday, March 7, 2019 6:30 PM > To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app > > Could you explain why it's unnecessary to build dpdk/test anymore? > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > > Sent: Wednesday, March 6, 2019 11:04 AM > > To: dts@dpdk.org > > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > > build_install_dpdk_test_app > > > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build > > dpdk/test anymore. > > > > Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com> > > --- > > framework/project_dpdk.py | 20 -------------------- > > 1 file changed, 20 deletions(-) > > > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py > > index > > 2ad01e8..6035c68 100644 > > --- a/framework/project_dpdk.py > > +++ b/framework/project_dpdk.py > > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > > # compile > > out = self.send_expect("make -j %d install T=%s %s" % > > (self.number_of_cores, target, extra_options), "# ", build_time) > > - #should not check test app compile status, because if test compile fail, > > - #all unit test can't exec, but others case will exec successfully > > - self.build_install_dpdk_test_app(target, build_time) > > - > > if("Error" in out or "No rule to make" in out): > > self.logger.error("ERROR - try without '-j'") > > # if Error try to execute make without -j option > > out = self.send_expect("make install T=%s %s" % (target, > > extra_options), "# ", 120) > > - self.build_install_dpdk_test_app(target, build_time) > > > > assert ("Error" not in out), "Compilation error..." > > assert ("No rule to make" not in out), "No rule to make error..." > > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > > out = self.send_expect("make -j %d install T=%s CC=gcc48" % > > (self.number_of_cores, > > target), > > "#", build_time) > > - #should not check test app compile status, because if test compile fail, > > - #all unit test can't exec, but others case will exec sucessfull > > - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") > > - > > if("Error" in out or "No rule to make" in out): > > self.logger.error("ERROR - try without '-j'") > > # if Error try to execute make without -j option > > out = self.send_expect("make install T=%s CC=gcc48" % target, > > "#", build_time) > > - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") > > > > assert ("Error" not in out), "Compilation error..." > > assert ("No rule to make" not in out), "No rule to make error..." > > > > - def build_install_dpdk_test_app(self, target, build_time, os_type="linux"): > > - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores) > > - if os_type == "freebsd": > > - cmd_build_test = "make -j %d -C test/ CC=gcc48" % > > (self.number_of_cores) > > - > > - self.send_expect(cmd_build_test, "# ", build_time) > > - app_list = ['./test/test/test', './test/test-acl/testacl', './test/test- > > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > > - for app in app_list: > > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) > > - > > def prepare_package(self): > > if not self.skip_setup: > > assert (os.path.isfile(self.package) is True), "Invalid package" > > -- > > 2.17.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app 2019-03-08 6:07 ` Li, WenjieX A @ 2019-03-09 6:54 ` Rami Rosen 2019-03-14 8:46 ` Tu, Lijuan 1 sibling, 0 replies; 6+ messages in thread From: Rami Rosen @ 2019-03-09 6:54 UTC (permalink / raw) To: Li, WenjieX A; +Cc: Tu, Lijuan, dts [-- Attachment #1: Type: text/plain, Size: 253 bytes --] Hi all, +1 Indeed, the test folder was moved to a different location, and the "test-build" target was removed, by the following recent DPDK patch set by Bruce Richardson: http://mails.dpdk.org/archives/dev/2019-February/125209.html Regards, Rami Rosen [-- Attachment #2: Type: text/html, Size: 525 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app 2019-03-08 6:07 ` Li, WenjieX A 2019-03-09 6:54 ` Rami Rosen @ 2019-03-14 8:46 ` Tu, Lijuan 1 sibling, 0 replies; 6+ messages in thread From: Tu, Lijuan @ 2019-03-14 8:46 UTC (permalink / raw) To: Li, WenjieX A, dts Hi wenjie Applied with comments changed. Could you please kindly add some reason when you contribute a patch. Thanks > -----Original Message----- > From: Li, WenjieX A > Sent: Friday, March 8, 2019 2:08 PM > To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app > > According to dpdk commit: a9de470, the autotests app was removed to the > "app" folder, and there is no separate build task necessary for building the > autotests using "make test-build" while "make" covering the autotests build. > After compile dpdk with below commands, the related apps will be generated at > x86_64-native-linuxapp-gcc/app/. > #cd dpdk > #export RTE_TARGET=x86_64-native-linuxapp-gcc > #export RTE_SDK=`pwd` > #make -j 86 install T=x86_64-native-linuxapp-gcc > > > -----Original Message----- > > From: Tu, Lijuan > > Sent: Thursday, March 7, 2019 6:30 PM > > To: Li, WenjieX A <wenjiex.a.li@intel.com>; dts@dpdk.org > > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > > build_install_dpdk_test_app > > > > Could you explain why it's unnecessary to build dpdk/test anymore? > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > > > Sent: Wednesday, March 6, 2019 11:04 AM > > > To: dts@dpdk.org > > > Cc: Li, WenjieX A <wenjiex.a.li@intel.com> > > > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > > > build_install_dpdk_test_app > > > > > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build > > > dpdk/test anymore. > > > > > > Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com> > > > --- > > > framework/project_dpdk.py | 20 -------------------- > > > 1 file changed, 20 deletions(-) > > > > > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py > > > index > > > 2ad01e8..6035c68 100644 > > > --- a/framework/project_dpdk.py > > > +++ b/framework/project_dpdk.py > > > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > > > # compile > > > out = self.send_expect("make -j %d install T=%s %s" % > > > (self.number_of_cores, target, extra_options), "# ", build_time) > > > - #should not check test app compile status, because if test compile fail, > > > - #all unit test can't exec, but others case will exec successfully > > > - self.build_install_dpdk_test_app(target, build_time) > > > - > > > if("Error" in out or "No rule to make" in out): > > > self.logger.error("ERROR - try without '-j'") > > > # if Error try to execute make without -j option > > > out = self.send_expect("make install T=%s %s" % > > > (target, extra_options), "# ", 120) > > > - self.build_install_dpdk_test_app(target, build_time) > > > > > > assert ("Error" not in out), "Compilation error..." > > > assert ("No rule to make" not in out), "No rule to make error..." > > > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > > > out = self.send_expect("make -j %d install T=%s CC=gcc48" % > > > (self.number_of_cores, > > > target), > > > "#", build_time) > > > - #should not check test app compile status, because if test compile fail, > > > - #all unit test can't exec, but others case will exec sucessfull > > > - self.build_install_dpdk_test_app(target, build_time, os_type="freebsd") > > > - > > > if("Error" in out or "No rule to make" in out): > > > self.logger.error("ERROR - try without '-j'") > > > # if Error try to execute make without -j option > > > out = self.send_expect("make install T=%s CC=gcc48" % target, > > > "#", build_time) > > > - self.build_install_dpdk_test_app(target, build_time, > os_type="freebsd") > > > > > > assert ("Error" not in out), "Compilation error..." > > > assert ("No rule to make" not in out), "No rule to make error..." > > > > > > - def build_install_dpdk_test_app(self, target, build_time, os_type="linux"): > > > - cmd_build_test = "make -j %d -C test/" % (self.number_of_cores) > > > - if os_type == "freebsd": > > > - cmd_build_test = "make -j %d -C test/ CC=gcc48" % > > > (self.number_of_cores) > > > - > > > - self.send_expect(cmd_build_test, "# ", build_time) > > > - app_list = ['./test/test/test', './test/test-acl/testacl', './test/test- > > > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > > > - for app in app_list: > > > - self.send_expect('cp -f %s ./%s/app' % (app, target), "# ", 30) > > > - > > > def prepare_package(self): > > > if not self.skip_setup: > > > assert (os.path.isfile(self.package) is True), "Invalid package" > > > -- > > > 2.17.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-14 8:47 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-06 3:04 [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Wenjie Li 2019-03-06 5:55 ` Zhu, ShuaiX 2019-03-07 10:29 ` Tu, Lijuan 2019-03-08 6:07 ` Li, WenjieX A 2019-03-09 6:54 ` Rami Rosen 2019-03-14 8:46 ` Tu, Lijuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).