Re: [dts] [PATCH V1] tests:add test suite about loadbalancer

["Tu, Lijuan" <lijuan.tu@intel.com>]

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, March 5, 2019 10:27 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] tests:add test suite about loadbalancer
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_loadbalancer.py | 104 ++++++++++++++++++++++++++++++++
>  1 file changed, 104 insertions(+)
>  create mode 100644 tests/TestSuite_loadbalancer.py
> 
> diff --git a/tests/TestSuite_loadbalancer.py b/tests/TestSuite_loadbalancer.py
> new file mode 100644 index 0000000..620dbdc
> --- /dev/null
> +++ b/tests/TestSuite_loadbalancer.py
> @@ -0,0 +1,104 @@
> +# <COPYRIGHT_TAG>
> +
> +"""
> +DPDK Test suite.
> +
> +Test Load Balancer.
> +
> +"""
> +
> +import dts
> +from packet import Packet
> +from test_case import TestCase
> +import time
> +
> +
> +class TestLoadbalancer(TestCase):
> +
> +    def set_up_all(self):
> +        """
> +        Run at the start of each test suite.
> +
> +        Load Balancer prerequisites.
> +        """
> +        # Verify that enough ports are available
> +        global dutPorts
> +        # Based on h/w type, choose how many ports to use
> +        dutPorts = self.dut.get_ports(self.nic)
> +
> +        # Verify that enough ports are available
> +        self.verify(len(dutPorts) >= 4, "Insufficient ports for
> + testing")
> +
> +        global P0, P1, P2, P3, trafficFlow
> +        P0 = self.tester.get_local_port(dutPorts[0])
> +        P1 = self.tester.get_local_port(dutPorts[1])
> +        P2 = self.tester.get_local_port(dutPorts[2])
> +        P3 = self.tester.get_local_port(dutPorts[3])
> + P0, P1, P2, P3 are not easily readable
> +        trafficFlow = {
> +            "F1": [P0, "1.0.0.1"],
> +            "F2": [P1, "1.0.1.1"],
> +            "F3": [P2, "1.0.2.1"],
> +            "F4": [P3, "1.0.3.1"],
> +        }
> +
> +        out = self.dut.send_expect("make -C examples/load_balancer", "#")
> +        self.verify("Error" not in out, "compilation error 1")
> +        self.verify("No such file" not in out, "compilation error 2")
> +
> +    def set_up(self):
> +        """
> +        Run before each test case.
> +        """
> +        pass
> +
> +    def test_load_balancer(self):
> +        """
> +        Verify Load Balancer run successfully
> +        """
> +        cmd = './examples/load_balancer/build/load_balancer -l 3-7 -n 4 -- --rx
> "(0,0,3),(1,0,3),(2,0,3),(3,0,3)" ' \
> +              '--tx "(0,3),(1,3),(2,3),(3,3)" --w "4,5,6,7" ' \
> +              '--lpm "1.0.0.0/24=>0;1.0.1.0/24=>1;1.0.2.0/24=>2;1.0.3.0/24=>3;' \
> +              '" --bsz "(10, 10), (10, 10), (10, 10)" --pos-lb 29'
[Lijuan] It's better to make you code suite for generic platform , so suggest you get cores form API.
> +
> +        self.dut.send_expect(cmd, 'main loop.')
> +
> +        for flow in trafficFlow.keys():
> +            rx_port = trafficFlow[flow][0]
> +
> +            for i in range(len(dutPorts)):
> +                dstport = self.tester.get_local_port(dutPorts[i])
> +                pkt_count = 10
> +                inst =
> + self.tester.tcpdump_sniff_packets(intf=self.tester.get_interface(rx_po
> + rt), timeout=10, count=pkt_count)
> +
> +                pkt = Packet()
> +                dst_mac = self.dut.get_mac_address(dutPorts[rx_port-5])
> +                pkt.config_layer('ether', {'dst': dst_mac})
> +                pkt.config_layer('ipv4', {'src': "0.0.0.0", 'dst': trafficFlow[flow][1]})
> +                pkt.send_pkt(tx_port=self.tester.get_interface(dstport), count=10)
> +                time.sleep(5)  # Wait for the sniffer to finish.
> +
> +                pkts = self.tester.load_tcpdump_sniff_packets(inst)
> +                len_pkts = len(pkts)
> +
> +                if len_pkts == pkt_count:
> +                    result = str([pkts[i].pktgen.pkt.show for i in range(len_pkts)])
> +                    self.verify("Ether" in result, "No packet received")
> +                    self.verify("src=0.0.0.0" + " dst=" + trafficFlow[flow][1] in result,
> "Wrong IP address")
> +                    self.verify("dst=%s" % dst_mac in result, "Recive wrong packet")
[Lijuan] typo: Recive -> Received.
> +                else:
> +                    self.verify("dst=01:00" not in dst_mac, "Packet
> + arrived on an unexpected port")
[Lijuan] Maybe packet missed
> +
> +        self.dut.send_expect("^C", "#")
[Lijuan] if exception happened, how to reach here. The application may be alive while test suite finished.
> +
> +    def tear_down(self):
> +        """
> +        Run after each test case.
> +        """
> +        pass
> +
> +    def tear_down_all(self):
> +        """
> +        Run after each test suite.
> +        """
> +        pass
> --
> 2.17.2