From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4D5BAA0096 for ; Thu, 14 Mar 2019 09:47:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0312374E; Thu, 14 Mar 2019 09:47:00 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BCF212C28 for ; Thu, 14 Mar 2019 09:46:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 01:46:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,477,1544515200"; d="scan'208";a="214054295" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 14 Mar 2019 01:46:58 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 01:46:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 01:46:57 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.74]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 16:46:51 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app Thread-Index: AQHU08jAuUmyawZpwU68M6l2OlsL+aX/+aswgADDF4CACiBTYA== Date: Thu, 14 Mar 2019 08:46:50 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42CF0@SHSMSX101.ccr.corp.intel.com> References: <1551841442-21029-1-git-send-email-wenjiex.a.li@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA3F6FA@SHSMSX101.ccr.corp.intel.com> <8688172CD5C0B74590FAE19D9579F94B5365CB61@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <8688172CD5C0B74590FAE19D9579F94B5365CB61@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjBlMzQxZTQtYjA3NC00NTBiLTk1NDMtMTNiYjE2MGE0NWJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSGtjeUVmblpKWVQxVzZPZ1p0UjA3RnZ2dVpxWlU4VjZSbHpQWUdoRzFVNllYUW5mZ3RHUGN1MlFiRGdiMnFBZyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] framwork/project_dpdk: remove build_install_dpdk_test_app X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi wenjie Applied with comments changed. Could you please kindly add some reason when= you contribute a patch. Thanks > -----Original Message----- > From: Li, WenjieX A > Sent: Friday, March 8, 2019 2:08 PM > To: Tu, Lijuan ; dts@dpdk.org > Cc: Li, WenjieX A > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > build_install_dpdk_test_app >=20 > According to dpdk commit: a9de470, the autotests app was removed to the > "app" folder, and there is no separate build task necessary for building = the > autotests using "make test-build" while "make" covering the autotests bui= ld. > After compile dpdk with below commands, the related apps will be generate= d at > x86_64-native-linuxapp-gcc/app/. > #cd dpdk > #export RTE_TARGET=3Dx86_64-native-linuxapp-gcc > #export RTE_SDK=3D`pwd` > #make -j 86 install T=3Dx86_64-native-linuxapp-gcc >=20 > > -----Original Message----- > > From: Tu, Lijuan > > Sent: Thursday, March 7, 2019 6:30 PM > > To: Li, WenjieX A ; dts@dpdk.org > > Cc: Li, WenjieX A > > Subject: RE: [dts] [PATCH V2] framwork/project_dpdk: remove > > build_install_dpdk_test_app > > > > Could you explain why it's unnecessary to build dpdk/test anymore? > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > > > Sent: Wednesday, March 6, 2019 11:04 AM > > > To: dts@dpdk.org > > > Cc: Li, WenjieX A > > > Subject: [dts] [PATCH V2] framwork/project_dpdk: remove > > > build_install_dpdk_test_app > > > > > > DPDK moved dpdk/test to dpdk/app/test, it is unnecessary to build > > > dpdk/test anymore. > > > > > > Signed-off-by: Wenjie Li > > > --- > > > framework/project_dpdk.py | 20 -------------------- > > > 1 file changed, 20 deletions(-) > > > > > > diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py > > > index > > > 2ad01e8..6035c68 100644 > > > --- a/framework/project_dpdk.py > > > +++ b/framework/project_dpdk.py > > > @@ -217,15 +217,10 @@ class DPDKdut(Dut): > > > # compile > > > out =3D self.send_expect("make -j %d install T=3D%s %s" % > > > (self.number_of_cores, target, extra_options), "# ", bui= ld_time) > > > - #should not check test app compile status, because if test c= ompile fail, > > > - #all unit test can't exec, but others case will exec success= fully > > > - self.build_install_dpdk_test_app(target, build_time) > > > - > > > if("Error" in out or "No rule to make" in out): > > > self.logger.error("ERROR - try without '-j'") > > > # if Error try to execute make without -j option > > > out =3D self.send_expect("make install T=3D%s %s" % > > > (target, extra_options), "# ", 120) > > > - self.build_install_dpdk_test_app(target, build_time) > > > > > > assert ("Error" not in out), "Compilation error..." > > > assert ("No rule to make" not in out), "No rule to make erro= r..." > > > @@ -244,30 +239,15 @@ class DPDKdut(Dut): > > > out =3D self.send_expect("make -j %d install T=3D%s CC=3Dgcc= 48" % > > > (self.number_of_cores, > > > = target), > > > "#", build_time) > > > - #should not check test app compile status, because if test c= ompile fail, > > > - #all unit test can't exec, but others case will exec sucessf= ull > > > - self.build_install_dpdk_test_app(target, build_time, os_type= =3D"freebsd") > > > - > > > if("Error" in out or "No rule to make" in out): > > > self.logger.error("ERROR - try without '-j'") > > > # if Error try to execute make without -j option > > > out =3D self.send_expect("make install T=3D%s CC=3Dgcc48= " % target, > > > "#", build_time) > > > - self.build_install_dpdk_test_app(target, build_time, > os_type=3D"freebsd") > > > > > > assert ("Error" not in out), "Compilation error..." > > > assert ("No rule to make" not in out), "No rule to make erro= r..." > > > > > > - def build_install_dpdk_test_app(self, target, build_time, os_typ= e=3D"linux"): > > > - cmd_build_test =3D "make -j %d -C test/" % (self.number_of_c= ores) > > > - if os_type =3D=3D "freebsd": > > > - cmd_build_test =3D "make -j %d -C test/ CC=3Dgcc48" % > > > (self.number_of_cores) > > > - > > > - self.send_expect(cmd_build_test, "# ", build_time) > > > - app_list =3D ['./test/test/test', './test/test-acl/testacl',= './test/test- > > > pipeline/testpipeline', './test/cmdline_test/cmdline_test'] > > > - for app in app_list: > > > - self.send_expect('cp -f %s ./%s/app' % (app, target), "#= ", 30) > > > - > > > def prepare_package(self): > > > if not self.skip_setup: > > > assert (os.path.isfile(self.package) is True), "Invalid = package" > > > -- > > > 2.17.2