test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dts] [PATCH] test_plans/vf_macfilter: correct case description and	command
Date: Thu, 14 Mar 2019 09:01:17 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42D86@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1551839215-50692-1-git-send-email-xueqin.lin@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Wednesday, March 6, 2019 10:27 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] test_plans/vf_macfilter: correct case description and
> command
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  test_plans/vf_macfilter_test_plan.rst | 42 +++++++++++++++++------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/test_plans/vf_macfilter_test_plan.rst
> b/test_plans/vf_macfilter_test_plan.rst
> index 6f07f28..d93a973 100644
> --- a/test_plans/vf_macfilter_test_plan.rst
> +++ b/test_plans/vf_macfilter_test_plan.rst
> @@ -107,12 +107,12 @@ Test Case 1:
> test_kernel_2pf_2vf_1vm_iplink_macfilter
>        testpmd> start
> 
>  6. Use scapy to send 100 random packets with ip link set MAC to VF, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  7. Also use scapy to send 100 random packets with a wrong MAC to VF, verify
> -   the packets can't be received by one VF and can be forward to another VF
> -   correctly.
> +   the packets can't be received by one VF and also can't be forwarded to
> +   another VF correctly.
> 
>  Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
>  ===================================================
> @@ -189,21 +189,21 @@ Test Case 2:
> test_kernel_2pf_2vf_1vm_mac_add_filter
>     case will be failed for FVL/Fort park NICs.
> 
>  6. Use scapy to send 100 random packets with current VF0's MAC, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  7. Use scapy to send 100 random packets with new added VF0's MAC, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  8. Use scapy to send 100 random packets with a wrong MAC to VF0, verify the
> -   packets can't be received by one VF and can be forward to another VF
> -   correctly.
> +   packets can't be received by one VF and also can't be forwarded to another
> +   VF correctly.
> 
>  Test Case 3: test_dpdk_2pf_2vf_1vm_mac_add_filter
>  ===================================================
> 
> -1. Get the pci device id of DUT, bind them to igb_uio,for example::
> +1. Get the pci device id of DUT, bind them to igb_uio, for example::
> 
>        ./usertools/dpdk-devbind.py -s
> 
> @@ -245,7 +245,7 @@ Test Case 3: test_dpdk_2pf_2vf_1vm_mac_add_filter
>        virsh nodedev-detach pci_0000_81_02_0;
>        virsh nodedev-detach pci_0000_81_0a_0;
> 
> -      ./dpdk_nic_bind.py --st
> +      ./usertools/dpdk-devbind.py -s
> 
>        0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0
> drv=i40e unused=
>        0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1
> drv=i40e unused= @@ -264,7 +264,7 @@ Test Case 3:
> test_dpdk_2pf_2vf_1vm_mac_add_filter
>     bind them to igb_uio driver, and then start testpmd, enable CRC strip on
>     VF, disable promisc mode, add a new MAC to VF0 and then start::
> 
> -      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
> +      ./usertools/dpdk-devbind.py --bind=igb_uio 00:06.0 00:07.0
>        ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w
> 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
> 
>        testpmd> port stop all
> @@ -279,21 +279,21 @@ Test Case 3: test_dpdk_2pf_2vf_1vm_mac_add_filter
>     case will be failed for FVL/Fort park NICs.
> 
>  7. Use scapy to send 100 random packets with current VF0's MAC, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  8. Use scapy to send 100 random packets with new added VF0's MAC, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  9. Use scapy to send 100 random packets with a wrong MAC to VF0, verify the
> -   packets can't be received by one VF and can be forward to another VF
> -   correctly.
> +   packets can't be received by one VF and also can't be forwarded to
> +   another VF correctly.
> 
>  Test Case 4: test_dpdk_2pf_2vf_1vm_iplink_macfilter
>  ===================================================
> 
> -1. Get the pci device id of DUT, bind them to igb_uio,for example::
> +1. Get the pci device id of DUT, bind them to igb_uio, for example::
> 
>        ./usertools/dpdk-devbind.py -s
> 
> @@ -337,7 +337,7 @@ Test Case 4: test_dpdk_2pf_2vf_1vm_iplink_macfilter
>        virsh nodedev-detach pci_0000_81_02_0;
>        virsh nodedev-detach pci_0000_81_0a_0;
> 
> -      ./dpdk_nic_bind.py --st
> +      ./usertools/dpdk-devbind.py -s
> 
>        0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0
> drv=i40e unused=
>        0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1
> drv=i40e unused= @@ -354,9 +354,9 @@ Test Case 4:
> test_dpdk_2pf_2vf_1vm_iplink_macfilter
> 
>  6. Login vm0, got VFs pci device id in vm0, assume they are 00:06.0 & 00:07.0,
>     bind them to igb_uio driver, and then start testpmd, enable CRC strip,
> -   disable promisc mode,set it in mac forward mode::
> +   disable promisc mode, set it in mac forward mode::
> 
> -      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
> +      ./usertools/dpdk-devbind.py --bind=igb_uio 00:06.0 00:07.0
>        ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w
> 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
> 
>        testpmd> port stop all
> @@ -367,9 +367,9 @@ Test Case 4: test_dpdk_2pf_2vf_1vm_iplink_macfilter
>        testpmd> start
> 
>  7. Use scapy to send 100 random packets with ip link set MAC to VF, verify the
> -   packets can be received by one VF and can be forward to another VF
> +   packets can be received by one VF and can be forwarded to another VF
>     correctly.
> 
>  8. Also use scapy to send 100 random packets with a wrong MAC to VF, verify
> -   the packets can't be received by one VF and can be forward to another VF
> -   correctly.
> +   the packets can't be received by one VF and also can't be forwarded to
> +   another VF correctly.
> --
> 2.5.5


      reply	other threads:[~2019-03-14  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06  2:26 Xueqin Lin
2019-03-14  9:01 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA42D86@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).