From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DB4B5A0096 for ; Thu, 14 Mar 2019 10:01:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA7CC324D; Thu, 14 Mar 2019 10:01:31 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8EB9A2C28 for ; Thu, 14 Mar 2019 10:01:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 02:01:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,477,1544515200"; d="scan'208";a="152249769" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 14 Mar 2019 02:01:29 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:01:28 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:01:28 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.121]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 17:01:26 +0800 From: "Tu, Lijuan" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] tests/vf_macfilter: correct case description Thread-Index: AQHU0/aUvHsoCyInuUarZEsMGHzweaYK4Qrw Date: Thu, 14 Mar 2019 09:01:26 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42D92@SHSMSX101.ccr.corp.intel.com> References: <1551839234-50760-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1551839234-50760-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2FlOWNlNWItZTg3Ni00YmY1LWE3YTMtNTNlYTc2Njc0OWZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNHpSd2ltTkJldUQ1MmFSMEJyeXR2THc3allWVmo3KzJ5WjArNGptTXBaQ3ZVZldCanZ3V25iUnl1d3NMcTZDSyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/vf_macfilter: correct case description X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Wednesday, March 6, 2019 10:27 AM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] tests/vf_macfilter: correct case description >=20 > Signed-off-by: Xueqin Lin >=20 > --- > tests/TestSuite_vf_macfilter.py | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilt= er.py > index 063ecda..f7bba1a 100644 > --- a/tests/TestSuite_vf_macfilter.py > +++ b/tests/TestSuite_vf_macfilter.py > @@ -26,7 +26,7 @@ class TestVfMacFilter(TestCase): > self.vf_driver =3D self.get_suite_cfg()['vf_driver'] > if self.vf_driver is None: > self.vf_driver =3D 'pci-stub' > - self.verify(self.vf_driver in self.supported_vf_driver, "Unsppor= ted vf driver") > + self.verify(self.vf_driver in self.supported_vf_driver, > + "Unsupported vf driver") > if self.vf_driver =3D=3D 'pci-stub': > self.vf_assign_method =3D 'pci-assign' > else: > @@ -125,11 +125,11 @@ class TestVfMacFilter(TestCase): > def test_kernel_2pf_2vf_1vm_iplink_macfilter(self): > """ > test case for kernel pf and dpdk vf 2pf_2vf_1vm MAC filter > - scenario > + scenario. > kernel pf will first run 'ip link set pf_interface vf 0 mac > xx:xx:xx:xx:xx:xx', then send packets with this MAC to VF, check > if the MAC filter works. Also send the packets with wrong MAC > - address to VF, check if the VF will not RX the packets. > + address to VF, check the VF will not RX the packets. > """ > self.setup_2pf_2vf_1vm_env(True,driver=3D'') > self.result_verify_iplink(True) @@ -174,25 +174,25 @@ class > TestVfMacFilter(TestCase): > scenario. > kernel pf will not set MAC address and the VF will get a random > generated MAC in the testpmd in VM, and then add VF mac address > - in the testpmd,for example, VF_MAC1 then send packets to the VF > + in the testpmd, for example, VF_MAC1 then send packets to the > + VF > with the random generated MAC and the new added VF_MAC1 and the > expected result is that all packets can be RXed and TXed. > What's more, send packets with a wrong MAC address to the VF wil= l > - not received by the VF. > + not be received by the VF. > """ > self.setup_2pf_2vf_1vm_env(False,driver=3D'') > self.send_packet_and_verify() >=20 > def test_dpdk_2pf_2vf_1vm_mac_add_filter(self): > """ > - test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenari= o > + test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenari= o. > dpdk pf will not set MAC address and the VF will get a random > generated MAC in the testpmd in VM, and then add VF mac address > - in the testpmd,for example, VF_MAC1 then send packets to the VF > + in the testpmd, for example, VF_MAC1 then send packets to the > + VF > with the random generated MAC and the new added VF_MAC1 and the > expected result is that all packets can be RXed and TXed. > - What's more, send packets with a wrong MAC address to the VF wil= l > - not received by the VF. > + What's more, send packets with a wrong MAC address to the VF, ch= eck > + the VF will not RX packets. > """ > self.verify(self.nic.startswith('fortville') =3D=3D True, "NIC i= s [%s], skip this > case" %self.nic) > self.setup_2pf_2vf_1vm_env(False,driver=3D'igb_uio') > @@ -200,12 +200,12 @@ class TestVfMacFilter(TestCase): >=20 > def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self): > """ > - test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenari= o > - dpdk pf will first run 'set vf mac addr 0 0 xx:xx:xx:xx:xx:xx, > - then send packets with this MAC to VF, check if the MAC filter > - send the packets with wrong MAC address to VF, check if the VF w= ill > - not RX the packets works. Also send the packets with wrong MAC > - address to VF, check if the VF will not RX the packets. > + test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenari= o. > + dpdk pf will not set MAC address and the VF will get a random > + generated MAC in the testpmd in VM, then send packets with this > + MAC to VF, check that all packets can be RXed and TXed, send the > + packets with a wrong MAC address to VF, check the VF will not RX > + packets. > """ > self.setup_2pf_2vf_1vm_env(False,driver=3D'igb_uio') > self.result_verify_iplink(False) > -- > 2.5.5