Re: [dts] [PATCH] tests/vf_offload: correct case description and delete un-used function

["Tu, Lijuan" <lijuan.tu@intel.com>]

1, The function checksum_enablesw is called by test_perf_checksum_throughtput.
2, found " --enable-rx-cksum " in testpmd start command line in set_up, that means enabled hardware checksum , the test_checksum_offload_disable actually tested hardware checksum, but we assume it tested software checksum.



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> Sent: Thursday, March 7, 2019 9:53 AM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH] tests/vf_offload: correct case description and delete un-
> used function
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  tests/TestSuite_vf_offload.py | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py index
> cb4b368..a327a7e 100644
> --- a/tests/TestSuite_vf_offload.py
> +++ b/tests/TestSuite_vf_offload.py
> @@ -27,7 +27,7 @@ class TestVfOffload(TestCase):
>          self.vf_driver = self.get_suite_cfg()['vf_driver']
>          if self.vf_driver is None:
>              self.vf_driver = 'pci-stub'
> -        self.verify(self.vf_driver in self.supported_vf_driver, "Unspported vf driver")
> +        self.verify(self.vf_driver in self.supported_vf_driver,
> + "Unsupported vf driver")
>          if self.vf_driver == 'pci-stub':
>              self.vf_assign_method = 'pci-assign'
>          else:
> @@ -125,12 +125,6 @@ class TestVfOffload(TestCase):
>          dut.send_expect("csum set sctp hw %d" % port, "testpmd>")
>          dut.send_expect("port start all", "testpmd>")
> 
> -    def checksum_enablesw(self, port, dut):
> -        dut.send_expect("csum set ip sw %d" % port, "testpmd>")
> -        dut.send_expect("csum set udp sw %d" % port, "testpmd>")
> -        dut.send_expect("csum set tcp sw %d" % port, "testpmd>")
> -        dut.send_expect("csum set sctp sw %d" % port, "testpmd>")
> -
>      def checksum_validate(self, packets_sent, packets_expected):
>          """
>          Validate the checksum.
> @@ -202,10 +196,10 @@ class TestVfOffload(TestCase):
> 
>      def test_checksum_offload_enable(self):
>          """
> -        Enable HW Checksum offload.
> -        Send packet with incorrect checksum,
> -        can rx it and reported the checksum error,
> -        verify forwarded packets have correct checksum
> +        Enable HW checksum offload.
> +        Send packet with incorrect checksum,
> +        can rx it and report the checksum error,
> +        verify forwarded packets have correct checksum.
>          """
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=%s " %
>                                        (self.portMask) + "--enable-rx-cksum " + "" + @@ -252,8
> +246,7 @@ class TestVfOffload(TestCase):
> 
>      def test_checksum_offload_disable(self):
>          """
> -        disable HW checksum offload on tx port, SW Checksum check.
> -        SW Checksum on by default.
> +        Default checksum is SW or enable SW checksum similar to HW checksum.
>          Send same packet with incorrect checksum and verify checksum is valid.
>          """
> 
> @@ -293,7 +286,7 @@ class TestVfOffload(TestCase):
> 
>      def tcpdump_start_sniffing(self, ifaces=[]):
>          """
> -        Starts tcpdump in the background to sniff the tester interface where
> +        Start tcpdump in the background to sniff the tester interface
> + where
>          the packets are transmitted to and from the self.dut.
>          All the captured packets are going to be stored in a file for a
>          post-analysis.
> @@ -306,7 +299,7 @@ class TestVfOffload(TestCase):
> 
>      def tcpdump_stop_sniff(self):
>          """
> -        Stops the tcpdump process running in the background.
> +        Stop the tcpdump process running in the background.
>          """
>          self.tester.send_expect('killall tcpdump', '#')
>          time.sleep(1)
> @@ -315,7 +308,7 @@ class TestVfOffload(TestCase):
> 
>      def tcpdump_command(self, command):
>          """
> -        Sends a tcpdump related command and returns an integer from the output
> +        Send a tcpdump related command and return an integer from the output.
>          """
> 
>          result = self.tester.send_expect(command, '#') @@ -324,7 +317,7 @@
> class TestVfOffload(TestCase):
> 
>      def number_of_packets(self, iface):
>          """
> -        By reading the file generated by tcpdump it counts how many packets were
> +        By reading the file generated by tcpdump it counts how many
> + packets are
>          forwarded by the sample app and received in the self.tester. The sample
> app
>          will add a known MAC address for the test to look for.
>          """
> @@ -335,7 +328,7 @@ class TestVfOffload(TestCase):
> 
>      def test_tso(self):
>          """
> -        TSO IPv4 TCP, IPv6 TCP, VXLan testing
> +        TSO IPv4 TCP, IPv6 TCP testing
>          """
>          tx_interface =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))
>          rx_interface =
> self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1]))
> --
> 2.5.5