From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 159B5A0096 for ; Thu, 14 Mar 2019 10:16:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C70F6374E; Thu, 14 Mar 2019 10:16:10 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EE8CF3572 for ; Thu, 14 Mar 2019 10:16:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 02:16:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,477,1544515200"; d="scan'208";a="141949554" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 14 Mar 2019 02:16:07 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:16:07 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:16:06 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by shsmsx102.ccr.corp.intel.com ([169.254.2.163]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 17:16:04 +0800 From: "Tu, Lijuan" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] tests/vf_offload: correct case description and delete un-used function Thread-Index: AQHU1LsrA3CtKuBBVEWdmeRXWAwj6qYK4Ssw Date: Thu, 14 Mar 2019 09:16:03 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42DCD@SHSMSX101.ccr.corp.intel.com> References: <1551923606-119633-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1551923606-119633-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWEzMTdkZTQtOWQ0YS00ZTJjLTgxZTYtOTQ1ZjQ0Mjc3YjJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiazFiNWhuKzJmS3lFZ1wvcStuXC9LYVdTd21xZjA2emszWmtcL29KbUhXa0Y5bVlBOXk3dFpNa1pFaFZVa00ybmxmYiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/vf_offload: correct case description and delete un-used function X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" 1, The function checksum_enablesw is called by test_perf_checksum_throughtp= ut. 2, found " --enable-rx-cksum " in testpmd start command line in set_up, tha= t means enabled hardware checksum , the test_checksum_offload_disable actua= lly tested hardware checksum, but we assume it tested software checksum. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Thursday, March 7, 2019 9:53 AM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] tests/vf_offload: correct case description and del= ete un- > used function >=20 > Signed-off-by: Xueqin Lin >=20 > --- > tests/TestSuite_vf_offload.py | 29 +++++++++++------------------ > 1 file changed, 11 insertions(+), 18 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.p= y index > cb4b368..a327a7e 100644 > --- a/tests/TestSuite_vf_offload.py > +++ b/tests/TestSuite_vf_offload.py > @@ -27,7 +27,7 @@ class TestVfOffload(TestCase): > self.vf_driver =3D self.get_suite_cfg()['vf_driver'] > if self.vf_driver is None: > self.vf_driver =3D 'pci-stub' > - self.verify(self.vf_driver in self.supported_vf_driver, "Unsppor= ted vf driver") > + self.verify(self.vf_driver in self.supported_vf_driver, > + "Unsupported vf driver") > if self.vf_driver =3D=3D 'pci-stub': > self.vf_assign_method =3D 'pci-assign' > else: > @@ -125,12 +125,6 @@ class TestVfOffload(TestCase): > dut.send_expect("csum set sctp hw %d" % port, "testpmd>") > dut.send_expect("port start all", "testpmd>") >=20 > - def checksum_enablesw(self, port, dut): > - dut.send_expect("csum set ip sw %d" % port, "testpmd>") > - dut.send_expect("csum set udp sw %d" % port, "testpmd>") > - dut.send_expect("csum set tcp sw %d" % port, "testpmd>") > - dut.send_expect("csum set sctp sw %d" % port, "testpmd>") > - > def checksum_validate(self, packets_sent, packets_expected): > """ > Validate the checksum. > @@ -202,10 +196,10 @@ class TestVfOffload(TestCase): >=20 > def test_checksum_offload_enable(self): > """ > - Enable HW Checksum offload. > - Send packet with incorrect checksum, > - can rx it and reported the checksum error, > - verify forwarded packets have correct checksum > + Enable HW checksum offload. > + Send packet with incorrect checksum, > + can rx it and report the checksum error, > + verify forwarded packets have correct checksum. > """ > self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=3D%s "= % > (self.portMask) + "--enable-rx-cks= um " + "" + @@ -252,8 > +246,7 @@ class TestVfOffload(TestCase): >=20 > def test_checksum_offload_disable(self): > """ > - disable HW checksum offload on tx port, SW Checksum check. > - SW Checksum on by default. > + Default checksum is SW or enable SW checksum similar to HW check= sum. > Send same packet with incorrect checksum and verify checksum is = valid. > """ >=20 > @@ -293,7 +286,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_start_sniffing(self, ifaces=3D[]): > """ > - Starts tcpdump in the background to sniff the tester interface w= here > + Start tcpdump in the background to sniff the tester interface > + where > the packets are transmitted to and from the self.dut. > All the captured packets are going to be stored in a file for a > post-analysis. > @@ -306,7 +299,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_stop_sniff(self): > """ > - Stops the tcpdump process running in the background. > + Stop the tcpdump process running in the background. > """ > self.tester.send_expect('killall tcpdump', '#') > time.sleep(1) > @@ -315,7 +308,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_command(self, command): > """ > - Sends a tcpdump related command and returns an integer from the = output > + Send a tcpdump related command and return an integer from the ou= tput. > """ >=20 > result =3D self.tester.send_expect(command, '#') @@ -324,7 +317,= 7 @@ > class TestVfOffload(TestCase): >=20 > def number_of_packets(self, iface): > """ > - By reading the file generated by tcpdump it counts how many pack= ets were > + By reading the file generated by tcpdump it counts how many > + packets are > forwarded by the sample app and received in the self.tester. The= sample > app > will add a known MAC address for the test to look for. > """ > @@ -335,7 +328,7 @@ class TestVfOffload(TestCase): >=20 > def test_tso(self): > """ > - TSO IPv4 TCP, IPv6 TCP, VXLan testing > + TSO IPv4 TCP, IPv6 TCP testing > """ > tx_interface =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0])) > rx_interface =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1])) > -- > 2.5.5