From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F23B0A0096 for ; Thu, 14 Mar 2019 10:33:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E287D3572; Thu, 14 Mar 2019 10:33:40 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 2C32E2C17 for ; Thu, 14 Mar 2019 10:33:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 02:33:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="282556898" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2019 02:33:37 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:33:37 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 02:33:37 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by shsmsx102.ccr.corp.intel.com ([169.254.2.163]) with mapi id 14.03.0415.000; Thu, 14 Mar 2019 17:33:35 +0800 From: "Tu, Lijuan" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] test_plans/vf_daemon: correct grammar and command Thread-Index: AQHU1XvE7Qel1eabeUen/vxMXiv19qYK5vsA Date: Thu, 14 Mar 2019 09:33:34 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA42E1E@SHSMSX101.ccr.corp.intel.com> References: <1552006396-187559-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1552006396-187559-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ4Zjk5MzctYjQyNC00NzMwLWIwYjItYWRlNmUxY2U3MzQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ3hMOFNkRFdndHNKd0JwVjdvZHh0UXE4V3RSb2tOVjNqN0J2Tiswc0lZUGl6QmZHbGpsRnNkWnFlRjJ6YUJxMSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] test_plans/vf_daemon: correct grammar and command X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Friday, March 8, 2019 8:53 AM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] test_plans/vf_daemon: correct grammar and command >=20 > Signed-off-by: Xueqin Lin >=20 > --- > test_plans/vf_daemon_test_plan.rst | 64 ++++++++++++++++++--------------= ----- > - > 1 file changed, 31 insertions(+), 33 deletions(-) >=20 > diff --git a/test_plans/vf_daemon_test_plan.rst > b/test_plans/vf_daemon_test_plan.rst > index 5dd582b..882e811 100644 > --- a/test_plans/vf_daemon_test_plan.rst > +++ b/test_plans/vf_daemon_test_plan.rst > @@ -37,7 +37,7 @@ VFD as SRIOV Policy Manager Tests VFD is SRIOV Policy > Manager (daemon) running on the host allowing configuration not supporte= d by > kernel NIC driver, supports ixgbe and i40e drivers' NIC. Run on the host= for > policy decisions w.r.t. what a -VF can and cannot do to the PF. Only the = DPDK PF > would provide a callback > +VF can and can not do to the PF. Only the DPDK PF would provide a > +callback > to implement these features, the normal kernel drivers would not have th= e > callback so would not support the features. Allow passing information to > application controlling PF when VF message box event received such as tho= se > @@ -70,10 +70,10 @@ by APP to know if they're permitted to be processed. > Prerequisites > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > -1. Host PF in DPDK driver. Create 2 VFs from 1 PF with dpdk driver,take > +1. Host PF in DPDK driver. Create 2 VFs from 1 PF with dpdk driver, > +take > Niantic for example:: >=20 > - ./tools/dpdk-devbind.py -b igb_uio 81:00.0 > + ./usertools/dpdk-devbind.py -b igb_uio 81:00.0 > echo 2 >/sys/bus/pci/devices/0000:81:00.0/max_vfs >=20 > 2. Detach VFs from the host:: > @@ -116,7 +116,7 @@ Test Case 1: Set VLAN insert for VF from PF >=20 > Test Case 2: Set VLAN strip for VF from PF > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -1. Disable VLAN strip for all queues for VF0 from PF:: > +1. Disable vlan strip for all queues for VF0 from PF:: >=20 > testpmd> set vf vlan stripq 0 0 off >=20 > @@ -129,7 +129,7 @@ Test Case 2: Set VLAN strip for VF from PF >=20 > 4. Stop VF0 testpmd and check VF0 can receive packet with configured vla= n id >=20 > -5. Enable VLAN strip for all queues for VF0 from PF:: > +5. Enable vlan strip for all queues for VF0 from PF:: >=20 > testpmd> set vf vlan stripq 0 0 on >=20 > @@ -160,9 +160,9 @@ Test Case 3: Set VLAN antispoof for VF from PF >=20 > 4. Disable vlan filter and strip on VF0 >=20 > -5. Start testpmd on VF0, set it in mac forwarding mode and enable:: > +5. Start testpmd on VF0, set it in mac forwarding mode and enable print:= : >=20 > - verbose output > + testpmd> set verbose 1 >=20 > 6. Send packets with matching/non-matching/no vlan id on tester port >=20 > @@ -242,7 +242,7 @@ Test Case 6: Enable/disable tx loopback >=20 > 2. Set VF0 in rxonly forwarding mode and start testpmd >=20 > -3. tcpdump on the tester port > +3. Tcpdump on the tester port >=20 > 4. Send 10 packets from VF1 to VF0 >=20 > @@ -257,14 +257,14 @@ Test Case 6: Enable/disable tx loopback >=20 > 8. Send packet from VF1 to VF0 >=20 > -9. Stop VF0 testpmd, check VF0 can receive packet,but tester port can't > +9. Stop VF0 testpmd, check VF0 can receive packet, but tester port > +can't > capture packet >=20 >=20 > Test Case 7: Set drop enable bit for all queues > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1. Bind VF1 device to igb_uio driver and start testpmd in chained port > - topology > + topology with 1024 rx descriptor "--rxd=3D1024" >=20 > 2. Disable drop enable bit for all queues from PF:: >=20 > @@ -273,7 +273,8 @@ Test Case 7: Set drop enable bit for all queues 3. O= nly > start VF1 to capture packet, set it in rxonly forwarding mode and > enable verbose output >=20 > -4. Send 200 packets to VF0, make VF0 queue full of packets > +4. Send 2000 packets to VF0, packet number should be more than rx > + descriptor(1024) to make VF0 queue full of packets >=20 > 5. Send 20 packets to VF1 >=20 > @@ -315,25 +316,22 @@ Test Case 8: Set split drop enable bit for VF from = PF >=20 >=20 >=20 > -Test Case 9: Get/Reset stats for VF from PF - > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -1. Add testpmd and some print code in the rte_pmd_i40e_set_vf_vlan_filte= r() > - function(drivers/net/i40e/i40e_ethdev.c) to start test, rebuild the c= ode > - > -2. Get stats output for VF0 from PF, and check RX/TX packets is 0:: > +Test Case 9: Show/Clear stats for VF from PF > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +1. Show stats output for VF0 from PF, and check RX/TX packets is 0:: >=20 > - testpmd> get vf stats 0 0 > + testpmd> show vf stats 0 0 >=20 > -3. Set VF0 in mac forwarding mode and start testpmd > +2. Set VF0 in mac forwarding mode and start testpmd >=20 > -4. Send 10 packets to VF0 and check VF0 can receive 10 packets > +3. Send 10 packets to VF0 and check VF0 can receive 10 packets >=20 > -5. Get stats for VF0 from PF, and check RX/TX packets is 10 > +4. Show stats for VF0 from PF, and check RX/TX packets is 10 >=20 > -6. Reset stats for VF0 from PF, and check PF and VF0 RX/TX packets is 0:= : > +5. Clear stats for VF0 from PF, and check PF and VF0 RX/TX packets is 0:= : >=20 > - testpmd> reset vf stats 0 0 > - testpmd> get vf stats 0 0 > + testpmd> clear vf stats 0 0 > + testpmd> show vf stats 0 0 >=20 >=20 > Test Case 10: enhancement to identify VF MTU change @@ -341,7 +339,7 @@ > Test Case 10: enhancement to identify VF MTU change 1. Set VF0 in mac > forwarding mode and start testpmd >=20 > 2. Default mtu size is 1500, send one packet with length bigger than def= ault > - mtu size, such as 2000 from tester,check VF0 can receive but can't tr= ansmit > + mtu size, such as 2000 from tester, check VF0 can receive but can't > + transmit > packet >=20 > 3. Set VF0 mtu size as 3000, but need to stop then restart port to activ= e mtu:: > @@ -351,7 +349,7 @@ Test Case 10: enhancement to identify VF MTU change > testpmd> port start all > testpmd> start >=20 > -4. Send one packet with length 2000 from tester,check VF0 can receive an= d > +4. Send one packet with length 2000 from tester, check VF0 can receive > +and > transmit packet >=20 > 5. Send one packet with length bigger than configured mtu size, such as = 5000 > @@ -390,16 +388,16 @@ Test Case 12: Broadcast mode >=20 > 2. Disable broadcast mode for VF0 from PF:: >=20 > - testpmd>set vf broadcast 0 0 off > + testpmd> set vf broadcast 0 0 off >=20 > -3. Send packets from tester with broadcast address,ff:ff:ff:ff:ff:ff, an= d check > +3. Send packets from tester with broadcast address, ff:ff:ff:ff:ff:ff, > +and check > VF0 can not receive the packet >=20 > 4. Enable broadcast mode for VF0 from PF:: >=20 > - testpmd>set vf broadcast 0 0 on > + testpmd> set vf broadcast 0 0 on >=20 > -5. Send packets from tester with broadcast address,ff:ff:ff:ff:ff:ff, an= d check > +5. Send packets from tester with broadcast address, ff:ff:ff:ff:ff:ff, > +and check > VF0 can receive the packet >=20 >=20 > @@ -409,15 +407,15 @@ Test Case 13: Multicast mode >=20 > 2. Disable promisc and multicast mode for VF0 from PF:: >=20 > - testpmd>set vf promisc 0 0 off > - testpmd>set vf allmulti 0 0 off > + testpmd> set vf promisc 0 0 off > + testpmd> set vf allmulti 0 0 off >=20 > 3. Send packet from tester to VF0 with multicast MAC, and check VF0 can = not > receive the packet >=20 > 4. Enable multicast mode for VF0 from PF:: >=20 > - testpmd>set vf allmulti 0 0 on > + testpmd> set vf allmulti 0 0 on >=20 > 5. Send packet from tester to VF0 with multicast MAC, and check VF0 can > receive > the packet > -- > 2.5.5