From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Yao, BingX Y" <bingx.y.yao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Yao, BingX Y" <bingx.y.yao@intel.com>
Subject: Re: [dts] [PATCH V1] tests/pmdrss_hash:change hard code
Date: Fri, 15 Mar 2019 06:13:51 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA432C6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1552367414-29273-1-git-send-email-bingx.y.yao@intel.com>
Do you forget to change hardcode of memory channel?
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Tuesday, March 12, 2019 1:10 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1] tests/pmdrss_hash:change hard code
>
> change the corelist adapted to the actual cores instead of hard code
>
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
> tests/TestSuite_pmdrss_hash.py | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
> index 60c9819..fc98922 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -464,8 +464,9 @@ class TestPmdrssHash(TestCase):
> """
> Run before each test case.
> """
> - pass
> -
> + cores = self.dut.get_core_list("all")
> + self.coremask = utils.create_mask(cores)
> +
> def test_toeplitz(self):
> dutPorts = self.dut.get_ports(self.nic)
> localPort = self.tester.get_local_port(dutPorts[0])
> @@ -477,8 +478,8 @@ class TestPmdrssHash(TestCase):
>
> # test with different rss queues
> self.dut.send_expect(
> - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> - (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> + "./%s/app/testpmd -c %s -n %d -- -i --rxq=%d --txq=%d" %
> + (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
>
> for iptype, rsstype in iptypes.items():
> self.dut.send_expect("set verbose 8", "testpmd> ") @@ -514,8 +515,8
> @@ class TestPmdrssHash(TestCase):
>
> # test with different rss queues
> self.dut.send_expect(
> - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> - (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> + "./%s/app/testpmd -c %s -n %d -- -i --rxq=%d --txq=%d" %
> + (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
>
> for iptype, rsstype in iptypes.items():
> self.dut.send_expect("set verbose 8", "testpmd> ") @@ -558,8 +559,8
> @@ class TestPmdrssHash(TestCase):
>
> # test with different rss queues
> self.dut.send_expect(
> - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> - (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> + "./%s/app/testpmd -c %s -n %d -- -i --rxq=%d --txq=%d" %
> + (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
>
> for iptype, rsstype in iptypes.items():
> self.logger.info("***********************%s rss
> test********************************" % iptype) @@ -597,8 +598,8 @@
> class TestPmdrssHash(TestCase):
>
> # test with different rss queues
> self.dut.send_expect(
> - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> - (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> + "./%s/app/testpmd -c %s -n %d -- -i --rxq=%d --txq=%d" %
> + (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
>
> for iptype, rsstype in iptypes.items():
> self.dut.send_expect("set verbose 8", "testpmd> ") @@ -632,7 +633,7
> @@ class TestPmdrssHash(TestCase):
> "fortpark_TLV", "fortville_25g"],
> "NIC Unsupported: " + str(self.nic))
>
> - self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target,
> "testpmd> ", 120)
> + self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i" %
> + (self.target, self.coremask), "testpmd> ", 120)
[Lijuan] Do you forget to change hardcode of memory channel?
> out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
> bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
>
> --
> 2.17.2
next prev parent reply other threads:[~2019-03-15 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 5:10 yaobing
2019-03-12 9:05 ` Zhu, WenhuiX
2019-03-14 5:34 ` Rami Rosen
2019-03-15 6:13 ` Tu, Lijuan [this message]
2019-03-15 7:30 ` Rami Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA432C6@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=bingx.y.yao@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).