From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BC87BA0096 for ; Fri, 15 Mar 2019 07:13:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DFF22C17; Fri, 15 Mar 2019 07:13:57 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3BAF62986 for ; Fri, 15 Mar 2019 07:13:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 23:13:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="282877692" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 14 Mar 2019 23:13:54 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 23:13:54 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 14 Mar 2019 23:13:54 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.80]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 14:13:52 +0800 From: "Tu, Lijuan" To: "Yao, BingX Y" , "dts@dpdk.org" CC: "Yao, BingX Y" Thread-Topic: [dts] [PATCH V1] tests/pmdrss_hash:change hard code Thread-Index: AQHU2JFnM9z+4uy4Ok2kVCIf9DDThaYMOyCA Date: Fri, 15 Mar 2019 06:13:51 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA432C6@SHSMSX101.ccr.corp.intel.com> References: <1552367414-29273-1-git-send-email-bingx.y.yao@intel.com> In-Reply-To: <1552367414-29273-1-git-send-email-bingx.y.yao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDUyOTg2YTEtMjNkMC00Mjc5LTk0YjItOTkwY2EzZDA3ZTVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUjMzTmtKNlFTa2ZBajdnSmxPWnZTaDBocUE1ZXllN1wvVVZKOGQ0SGVLbktpS2YyWHNoS2x1WTBiZkRLbGtYZ0oifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/pmdrss_hash:change hard code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Do you forget to change hardcode of memory channel? > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing > Sent: Tuesday, March 12, 2019 1:10 PM > To: dts@dpdk.org > Cc: Yao, BingX Y > Subject: [dts] [PATCH V1] tests/pmdrss_hash:change hard code >=20 > change the corelist adapted to the actual cores instead of hard code >=20 > Signed-off-by: yaobing > --- > tests/TestSuite_pmdrss_hash.py | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) >=20 > diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash= .py > index 60c9819..fc98922 100644 > --- a/tests/TestSuite_pmdrss_hash.py > +++ b/tests/TestSuite_pmdrss_hash.py > @@ -464,8 +464,9 @@ class TestPmdrssHash(TestCase): > """ > Run before each test case. > """ > - pass > - > + cores =3D self.dut.get_core_list("all") > + self.coremask =3D utils.create_mask(cores) > + > def test_toeplitz(self): > dutPorts =3D self.dut.get_ports(self.nic) > localPort =3D self.tester.get_local_port(dutPorts[0]) > @@ -477,8 +478,8 @@ class TestPmdrssHash(TestCase): >=20 > # test with different rss queues > self.dut.send_expect( > - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=3D0xffffe= --rxq=3D%d -- > txq=3D%d" % > - (self.target, self.dut.get_memory_channels(), queue, queue),= "testpmd> > ", 120) > + "./%s/app/testpmd -c %s -n %d -- -i --rxq=3D%d --txq=3D%d" = % > + (self.target, self.coremask, > + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120) >=20 > for iptype, rsstype in iptypes.items(): > self.dut.send_expect("set verbose 8", "testpmd> ") @@ -514,8= +515,8 > @@ class TestPmdrssHash(TestCase): >=20 > # test with different rss queues > self.dut.send_expect( > - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=3D0xffffe= --rxq=3D%d -- > txq=3D%d" % > - (self.target, self.dut.get_memory_channels(), queue, queue),= "testpmd> > ", 120) > + "./%s/app/testpmd -c %s -n %d -- -i --rxq=3D%d --txq=3D%d" = % > + (self.target, self.coremask, > + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120) >=20 > for iptype, rsstype in iptypes.items(): > self.dut.send_expect("set verbose 8", "testpmd> ") @@ -558,8= +559,8 > @@ class TestPmdrssHash(TestCase): >=20 > # test with different rss queues > self.dut.send_expect( > - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=3D0xffffe= --rxq=3D%d -- > txq=3D%d" % > - (self.target, self.dut.get_memory_channels(), queue, queue),= "testpmd> > ", 120) > + "./%s/app/testpmd -c %s -n %d -- -i --rxq=3D%d --txq=3D%d" = % > + (self.target, self.coremask, > + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120) >=20 > for iptype, rsstype in iptypes.items(): > self.logger.info("***********************%s rss > test********************************" % iptype) @@ -597,8 +598,8 @@ > class TestPmdrssHash(TestCase): >=20 > # test with different rss queues > self.dut.send_expect( > - "./%s/app/testpmd -c fffff -n %d -- -i --coremask=3D0xffffe= --rxq=3D%d -- > txq=3D%d" % > - (self.target, self.dut.get_memory_channels(), queue, queue),= "testpmd> > ", 120) > + "./%s/app/testpmd -c %s -n %d -- -i --rxq=3D%d --txq=3D%d" = % > + (self.target, self.coremask, > + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120) >=20 > for iptype, rsstype in iptypes.items(): > self.dut.send_expect("set verbose 8", "testpmd> ") @@ -632,7= +633,7 > @@ class TestPmdrssHash(TestCase): > "fortpark_TLV", "fortville_25g"], > "NIC Unsupported: " + str(self.nic)) >=20 > - self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.t= arget, > "testpmd> ", 120) > + self.dut.send_expect("./%s/app/testpmd -c %s -n 4 -- -i" % > + (self.target, self.coremask), "testpmd> ", 120) [Lijuan] Do you forget to change hardcode of memory channel? > out =3D self.dut.send_expect("create bonded device 3 0", "testpm= d> ", 30) > bond_device_id =3D int(re.search("port \d+", out).group().split(= " ")[-1].strip()) >=20 > -- > 2.17.2