Re: [dts] [PATCH V3] tests/flow_classify_softnic: update the thread number

Re: [dts] [PATCH V3] tests/flow_classify_softnic: update the thread number

[Li, WenjieX A]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Friday, March 22, 2019 9:58 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V3] tests/flow_classify_softnic: update the thread number
> 
> 1. the thread number should be equal to the port number, update it 2. move
> dut.kill_all() to tear_down() to avoid the interactions between cases
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> 
> V3: change the dts patch name
> V2: add "sed -i ..." to set_ports()
> V1: wrongly add "sed -i ..." to set_table()
> ---
>  tests/TestSuite_flow_classify_softnic.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify_softnic.py
> b/tests/TestSuite_flow_classify_softnic.py
> index 66db5c3..c98e8d0 100644
> --- a/tests/TestSuite_flow_classify_softnic.py
> +++ b/tests/TestSuite_flow_classify_softnic.py
> @@ -109,6 +109,8 @@ class TestFlowClassifySoftnic(TestCase):
>              self.dut.send_expect(cmd, "# ", 20)
>              cmd = "sed -i '4i\link LINK3
> dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci,
> filename)
>              self.dut.send_expect(cmd, "# ", 20)
> +        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d
> + pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" %
> + (self.port_num, filename), "# ", 20)
> +
> 
>      def set_table(self, cmd, filename):
>          """
> @@ -1349,10 +1351,10 @@ class TestFlowClassifySoftnic(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          """
> -        self.dut.kill_all()
> +        pass
> --
> 2.17.2

[dts] [PATCH V3] tests/flow_classify_softnic: update the thread number

[Wenjie Li]

1. the thread number should be equal to the port number, update it
2. move dut.kill_all() to tear_down() to avoid the interactions between cases

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>

V3: change the dts patch name
V2: add "sed -i ..." to set_ports()
V1: wrongly add "sed -i ..." to set_table()
---
 tests/TestSuite_flow_classify_softnic.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py
index 66db5c3..c98e8d0 100644
--- a/tests/TestSuite_flow_classify_softnic.py
+++ b/tests/TestSuite_flow_classify_softnic.py
@@ -109,6 +109,8 @@ class TestFlowClassifySoftnic(TestCase):
             self.dut.send_expect(cmd, "# ", 20)
             cmd = "sed -i '4i\link LINK3 dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci, filename)
             self.dut.send_expect(cmd, "# ", 20)
+        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.port_num, filename), "# ", 20)
+
 
     def set_table(self, cmd, filename):
         """
@@ -1349,10 +1351,10 @@ class TestFlowClassifySoftnic(TestCase):
         """
         Run after each test case.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         """
-        self.dut.kill_all()
+        pass
-- 
2.17.2

Re: [dts] [PATCH V3] tests/flow_classify_softnic: update the thread number

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, March 21, 2019 6:58 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V3] tests/flow_classify_softnic: update the thread number
> 
> 1. the thread number should be equal to the port number, update it 2. move
> dut.kill_all() to tear_down() to avoid the interactions between cases
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> 
> V3: change the dts patch name
> V2: add "sed -i ..." to set_ports()
> V1: wrongly add "sed -i ..." to set_table()
> ---
>  tests/TestSuite_flow_classify_softnic.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify_softnic.py
> b/tests/TestSuite_flow_classify_softnic.py
> index 66db5c3..c98e8d0 100644
> --- a/tests/TestSuite_flow_classify_softnic.py
> +++ b/tests/TestSuite_flow_classify_softnic.py
> @@ -109,6 +109,8 @@ class TestFlowClassifySoftnic(TestCase):
>              self.dut.send_expect(cmd, "# ", 20)
>              cmd = "sed -i '4i\link LINK3
> dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci,
> filename)
>              self.dut.send_expect(cmd, "# ", 20)
> +        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d
> + pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" %
> + (self.port_num, filename), "# ", 20)
> +
> 
>      def set_table(self, cmd, filename):
>          """
> @@ -1349,10 +1351,10 @@ class TestFlowClassifySoftnic(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          """
> -        self.dut.kill_all()
> +        pass
> --
> 2.17.2