test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/pmdrss_hash:change hard code
@ 2019-03-21  3:20 yaobing
  2019-03-22  3:01 ` Zhu, WenhuiX
  2019-03-24 18:14 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: yaobing @ 2019-03-21  3:20 UTC (permalink / raw)
  To: dts; +Cc: yaobing

V1:
change the corelist adapted to the actual cores instead of hard code

V2:
change hardcode of memory channel


Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_pmdrss_hash.py | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index 60c9819..dd22f91 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -464,7 +464,8 @@ class TestPmdrssHash(TestCase):
         """
         Run before each test case.
         """
-        pass
+        cores = self.dut.get_core_list("all")
+        self.coremask = utils.create_mask(cores)
 
     def test_toeplitz(self):
         dutPorts = self.dut.get_ports(self.nic)
@@ -477,8 +478,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -514,8 +515,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -558,8 +559,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.logger.info("***********************%s rss test********************************" % iptype)
@@ -597,8 +598,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ")
@@ -632,7 +633,7 @@ class TestPmdrssHash(TestCase):
                     "fortpark_TLV", "fortville_25g"],
                     "NIC Unsupported: " + str(self.nic))
 
-        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target, "testpmd> ", 120)
+        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i" % (self.target, self.coremask, self.dut.get_memory_channels()), "testpmd> ", 120)
         out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
         bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/pmdrss_hash:change hard code
  2019-03-21  3:20 [dts] [PATCH V2] tests/pmdrss_hash:change hard code yaobing
@ 2019-03-22  3:01 ` Zhu, WenhuiX
  2019-03-24 18:14 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-03-22  3:01 UTC (permalink / raw)
  To: Yao, BingX Y, dts; +Cc: Yao, BingX Y


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
Sent: Thursday, March 21, 2019 11:20 AM
To: dts@dpdk.org
Cc: Yao, BingX Y <bingx.y.yao@intel.com>
Subject: [dts] [PATCH V2] tests/pmdrss_hash:change hard code

V1:
change the corelist adapted to the actual cores instead of hard code

V2:
change hardcode of memory channel


Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_pmdrss_hash.py | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py index 60c9819..dd22f91 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -464,7 +464,8 @@ class TestPmdrssHash(TestCase):
         """
         Run before each test case.
         """
-        pass
+        cores = self.dut.get_core_list("all")
+        self.coremask = utils.create_mask(cores)
 
     def test_toeplitz(self):
         dutPorts = self.dut.get_ports(self.nic) @@ -477,8 +478,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, 
+ self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ") @@ -514,8 +515,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, 
+ self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ") @@ -558,8 +559,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, 
+ self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.logger.info("***********************%s rss test********************************" % iptype) @@ -597,8 +598,8 @@ class TestPmdrssHash(TestCase):
 
         # test with different rss queues
         self.dut.send_expect(
-            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --txq=%d" %
-            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
+            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
+            (self.target, self.coremask, 
+ self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
 
         for iptype, rsstype in iptypes.items():
             self.dut.send_expect("set verbose 8", "testpmd> ") @@ -632,7 +633,7 @@ class TestPmdrssHash(TestCase):
                     "fortpark_TLV", "fortville_25g"],
                     "NIC Unsupported: " + str(self.nic))
 
-        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target, "testpmd> ", 120)
+        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i" % 
+ (self.target, self.coremask, self.dut.get_memory_channels()), 
+ "testpmd> ", 120)
         out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
         bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
 
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/pmdrss_hash:change hard code
  2019-03-21  3:20 [dts] [PATCH V2] tests/pmdrss_hash:change hard code yaobing
  2019-03-22  3:01 ` Zhu, WenhuiX
@ 2019-03-24 18:14 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-03-24 18:14 UTC (permalink / raw)
  To: Yao, BingX Y, dts; +Cc: Yao, BingX Y

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Wednesday, March 20, 2019 8:20 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V2] tests/pmdrss_hash:change hard code
> 
> V1:
> change the corelist adapted to the actual cores instead of hard code
> 
> V2:
> change hardcode of memory channel
> 
> 
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>  tests/TestSuite_pmdrss_hash.py | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
> index 60c9819..dd22f91 100644
> --- a/tests/TestSuite_pmdrss_hash.py
> +++ b/tests/TestSuite_pmdrss_hash.py
> @@ -464,7 +464,8 @@ class TestPmdrssHash(TestCase):
>          """
>          Run before each test case.
>          """
> -        pass
> +        cores = self.dut.get_core_list("all")
> +        self.coremask = utils.create_mask(cores)
> 
>      def test_toeplitz(self):
>          dutPorts = self.dut.get_ports(self.nic) @@ -477,8 +478,8 @@ class
> TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -514,8 +515,8
> @@ class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -558,8 +559,8
> @@ class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.logger.info("***********************%s rss
> test********************************" % iptype) @@ -597,8 +598,8 @@
> class TestPmdrssHash(TestCase):
> 
>          # test with different rss queues
>          self.dut.send_expect(
> -            "./%s/app/testpmd  -c fffff -n %d -- -i --coremask=0xffffe --rxq=%d --
> txq=%d" %
> -            (self.target, self.dut.get_memory_channels(), queue, queue), "testpmd>
> ", 120)
> +            "./%s/app/testpmd  -c %s -n %d -- -i --rxq=%d --txq=%d" %
> +            (self.target, self.coremask,
> + self.dut.get_memory_channels(), queue, queue), "testpmd> ", 120)
> 
>          for iptype, rsstype in iptypes.items():
>              self.dut.send_expect("set verbose 8", "testpmd> ") @@ -632,7 +633,7
> @@ class TestPmdrssHash(TestCase):
>                      "fortpark_TLV", "fortville_25g"],
>                      "NIC Unsupported: " + str(self.nic))
> 
> -        self.dut.send_expect("./%s/app/testpmd -c f -n 4 -- -i" % self.target,
> "testpmd> ", 120)
> +        self.dut.send_expect("./%s/app/testpmd -c %s -n %d -- -i" %
> + (self.target, self.coremask, self.dut.get_memory_channels()),
> + "testpmd> ", 120)
>          out = self.dut.send_expect("create bonded device 3 0", "testpmd> ", 30)
>          bond_device_id = int(re.search("port \d+", out).group().split(" ")[-1].strip())
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-24 18:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21  3:20 [dts] [PATCH V2] tests/pmdrss_hash:change hard code yaobing
2019-03-22  3:01 ` Zhu, WenhuiX
2019-03-24 18:14 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).