From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5E6D3A05D3 for ; Sun, 24 Mar 2019 19:32:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DAE92956; Sun, 24 Mar 2019 19:32:45 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 413F51DBD for ; Sun, 24 Mar 2019 19:32:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2019 11:32:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="310035913" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 24 Mar 2019 11:32:41 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 24 Mar 2019 11:32:41 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.134]) with mapi id 14.03.0415.000; Mon, 25 Mar 2019 02:32:39 +0800 From: "Tu, Lijuan" To: "Lin, Xueqin" , "dts@dpdk.org" CC: "Lin, Xueqin" Thread-Topic: [dts] [PATCH] tests/vf_offload: correct case grammar and sw checksum test Thread-Index: AQHU3XE5F6R0bBbxhEiVxH/z/ScPraYbJPYw Date: Sun, 24 Mar 2019 18:32:37 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA45BAE@SHSMSX101.ccr.corp.intel.com> References: <1552881479-115103-1-git-send-email-xueqin.lin@intel.com> In-Reply-To: <1552881479-115103-1-git-send-email-xueqin.lin@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNkMDI1ZWUtNzY2MC00NTZjLTg4NzUtYThhY2JlYTAwOWE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU3FrMWRnanlLaFVoSStkUXdGdUF0MHh4ZGtRUUV4c1NKQUZOYXo4NEdnek5GZVZTVUdYWHJTZWxpYTZRTVpUKyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/vf_offload: correct case grammar and sw checksum test X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > Sent: Sunday, March 17, 2019 8:58 PM > To: dts@dpdk.org > Cc: Lin, Xueqin > Subject: [dts] [PATCH] tests/vf_offload: correct case grammar and sw chec= ksum > test >=20 > Signed-off-by: Xueqin Lin >=20 > --- > tests/TestSuite_vf_offload.py | 27 +++++++++++++++------------ > 1 file changed, 15 insertions(+), 12 deletions(-) >=20 > diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.p= y index > cb4b368..8cb0dac 100644 > --- a/tests/TestSuite_vf_offload.py > +++ b/tests/TestSuite_vf_offload.py > @@ -27,7 +27,7 @@ class TestVfOffload(TestCase): > self.vf_driver =3D self.get_suite_cfg()['vf_driver'] > if self.vf_driver is None: > self.vf_driver =3D 'pci-stub' > - self.verify(self.vf_driver in self.supported_vf_driver, "Unsppor= ted vf driver") > + self.verify(self.vf_driver in self.supported_vf_driver, > + "Unsupported vf driver") > if self.vf_driver =3D=3D 'pci-stub': > self.vf_assign_method =3D 'pci-assign' > else: > @@ -126,10 +126,12 @@ class TestVfOffload(TestCase): > dut.send_expect("port start all", "testpmd>") >=20 > def checksum_enablesw(self, port, dut): > + dut.send_expect("port stop all", "testpmd>") > dut.send_expect("csum set ip sw %d" % port, "testpmd>") > dut.send_expect("csum set udp sw %d" % port, "testpmd>") > dut.send_expect("csum set tcp sw %d" % port, "testpmd>") > dut.send_expect("csum set sctp sw %d" % port, "testpmd>") > + dut.send_expect("port start all", "testpmd>") >=20 > def checksum_validate(self, packets_sent, packets_expected): > """ > @@ -202,10 +204,10 @@ class TestVfOffload(TestCase): >=20 > def test_checksum_offload_enable(self): > """ > - Enable HW Checksum offload. > - Send packet with incorrect checksum, > - can rx it and reported the checksum error, > - verify forwarded packets have correct checksum > + Enable HW checksum offload. > + Send packet with incorrect checksum, > + can rx it and report the checksum error, > + verify forwarded packets have correct checksum. > """ > self.vm0_testpmd.start_testpmd(VM_CORES_MASK, "--portmask=3D%s "= % > (self.portMask) + "--enable-rx-cks= um " + "" + @@ -252,8 > +254,7 @@ class TestVfOffload(TestCase): >=20 > def test_checksum_offload_disable(self): > """ > - disable HW checksum offload on tx port, SW Checksum check. > - SW Checksum on by default. > + Enable SW checksum offload. > Send same packet with incorrect checksum and verify checksum is = valid. > """ >=20 > @@ -279,6 +280,8 @@ class TestVfOffload(TestCase): > 'IPv6/UDP': 'Ether(dst=3D"02:00:00:00:00:00", > src=3D"%s")/IPv6(src=3D"%s")/UDP()/("X"*46)' % (mac, expIPv6), > 'IPv6/TCP': 'Ether(dst=3D"02:00:00:00:00:00", > src=3D"%s")/IPv6(src=3D"%s")/TCP()/("X"*46)' % (mac, expIPv6)} >=20 > + self.checksum_enablesw(0, self.vm_dut_0) > + > self.vm0_testpmd.execute_cmd('start') > result =3D self.checksum_validate(sndPkts, expPkts) >=20 > @@ -293,7 +296,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_start_sniffing(self, ifaces=3D[]): > """ > - Starts tcpdump in the background to sniff the tester interface w= here > + Start tcpdump in the background to sniff the tester interface > + where > the packets are transmitted to and from the self.dut. > All the captured packets are going to be stored in a file for a > post-analysis. > @@ -306,7 +309,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_stop_sniff(self): > """ > - Stops the tcpdump process running in the background. > + Stop the tcpdump process running in the background. > """ > self.tester.send_expect('killall tcpdump', '#') > time.sleep(1) > @@ -315,7 +318,7 @@ class TestVfOffload(TestCase): >=20 > def tcpdump_command(self, command): > """ > - Sends a tcpdump related command and returns an integer from the = output > + Send a tcpdump related command and return an integer from the ou= tput. > """ >=20 > result =3D self.tester.send_expect(command, '#') @@ -324,7 +327,= 7 @@ > class TestVfOffload(TestCase): >=20 > def number_of_packets(self, iface): > """ > - By reading the file generated by tcpdump it counts how many pack= ets were > + By reading the file generated by tcpdump it counts how many > + packets are > forwarded by the sample app and received in the self.tester. The= sample > app > will add a known MAC address for the test to look for. > """ > @@ -335,7 +338,7 @@ class TestVfOffload(TestCase): >=20 > def test_tso(self): > """ > - TSO IPv4 TCP, IPv6 TCP, VXLan testing > + TSO IPv4 TCP, IPv6 TCP testing. > """ > tx_interface =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0])) > rx_interface =3D > self.tester.get_interface(self.tester.get_local_port(self.dut_ports[1])) > -- > 2.5.5