test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Peng, Yuan" <yuan.peng@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dts] [PATCH] test_plans: change key and key_len setting
Date: Sun, 24 Mar 2019 19:10:58 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA45CEB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1552973030-68263-1-git-send-email-yuan.peng@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yuan Peng
> Sent: Monday, March 18, 2019 10:24 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH] test_plans: change key and key_len setting
> 
> From: Peng Yuan <yuan.peng@intel.com>
> 
> change key and key_len setting in rss_to_rte_flow_test_plan.rst
> 
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>
> 
> diff --git a/test_plans/rss_to_rte_flow_test_plan.rst
> b/test_plans/rss_to_rte_flow_test_plan.rst
> index dbbaa28..c6158bd 100644
> --- a/test_plans/rss_to_rte_flow_test_plan.rst
> +++ b/test_plans/rss_to_rte_flow_test_plan.rst
> @@ -278,7 +278,7 @@ Only i40e support key and key_len setting.
>      testpmd> set verbose 1
>      testpmd> start
> 
> -2. Set ipv4-udp RSS and show the RSS key::
> +2. Set ipv4-udp RSS and show the default RSS key::
> 
>      testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end /
> end
>      testpmd> show port 0 rss-hash key
> @@ -304,24 +304,26 @@ Only i40e support key and key_len setting.
>  3. Set ipv4-udp key::
> 
>      testpmd> flow flush 0
> -    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key
> 67108863 / end
> +    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key \
> +
> +
> 1234567890123456789012345678901234567890FFFFFFFFFFFF12345678901234
> 5678
> + 9012345678901234567890FFFFFFFFFFFF / end
>      testpmd> show port 0 rss-hash key
>      RSS functions:
>       ipv4-udp udp
>      RSS key:
> -
> 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4
> C05C6FA343958D8557D99583AE138C92E81150366
> +
> +
> 1234567890123456789012345678901234567890FFFFFFFFFFFF12345678901234
> 5678
> + 9012345678901234567890FFFFFFFFFFFF
> 
>     Send the same five packets to port 0,
>     pkt1 is distributed to queue 3.
> -   pkt2 is distributed to queue 3.
> -   pkt3 is distributed to queue 0.
> -   pkt4 is distributed to queue 1.
> -   pkt5 is distributed to queue 0.
> +   pkt2 is distributed to queue 2.
> +   pkt3 is distributed to queue 2.
> +   pkt4 is distributed to queue 0.
> +   pkt5 is distributed to queue 3.
> 
> -4. Set ipv4-udp key_len::
> +4. Set ipv4-udp with truncating key_len::
> 
>      testpmd> flow flush 0
> -    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key_len 3 / end
> +    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key \
> +
> +
> 1234567890123456789012345678901234567890FFFFFFFFFFFF12345678901234
> 5678
> + 9012345678901234567890FFFFFFFFFFFF key_len 50 / end
>      testpmd> show port 0 rss-hash key
>      RSS functions:
>       ipv4-udp udp
> @@ -335,22 +337,30 @@ Only i40e support key and key_len setting.
>     pkt4 is distributed to queue 1.
>     pkt5 is distributed to queue 0.
> 
> -5. Set ipv4-udp key and key_len::
> +   The key length is 52 bytes, if setting it shorter than 52, the key value doesn't
> take effect.
> +   The showed key value is an invalid value, not the default value.
> +   The key length is different among different NIC types.
> +
> +5. Set ipv4-udp with padding key_len::
> 
>      testpmd> flow flush 0
> -    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key
> 67108863 key_len 3 / end
> +    testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end
> key \
> +
> +
> 1234567890123456789012345678901234567890FFFFFFFFFFFF12345678901234
> 5678
> + 9012345678901234567890FFFFFF key_len 52 / end
>      testpmd> show port 0 rss-hash key
>      RSS functions:
>       ipv4-udp udp
>      RSS key:
> -
> 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4
> C05C6FA343958D8557D99583AE138C92E81150366
> +
> +
> 1234567890123456789012345678901234567890FFFFFFFFFFFF12345678901234
> 5678
> + 9012345678901234567890FFFFFF657474
> 
>     Send the same five packets to port 0,
>     pkt1 is distributed to queue 3.
> -   pkt2 is distributed to queue 3.
> -   pkt3 is distributed to queue 0.
> -   pkt4 is distributed to queue 1.
> -   pkt5 is distributed to queue 0.
> +   pkt2 is distributed to queue 2.
> +   pkt3 is distributed to queue 2.
> +   pkt4 is distributed to queue 0.
> +   pkt5 is distributed to queue 3.
> +
> +   The lengh of key is 49 bytes, but the key_len is 52,
> +   so the last three bytes of key is padded by default value.
> 
>  Test case: Flow directory rule and RSS rule combination
> =======================================================
> --
> 2.7.4


      reply	other threads:[~2019-03-24 19:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  5:23 Yuan Peng
2019-03-24 19:10 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA45CEB@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).