Re: [dts] [PATCH V3] test_plans/etag:add hardware informations

["Tu, Lijuan" <lijuan.tu@intel.com>]

Sagepond(X552/X557-AT) is a build-in NIC in SuperMicro 1U Xeon D Broadwell SoC uServer, but Sageville(X550) is a separated NIC that we can install it in any machines, so it doesn't make sense to add your machine type in prerequisites, because it's not a MUST option, but a COULD option. I prefer to remove 'Machine type' and  'Product Name'

> +-  Machine type: SuperMicro 1U Xeon D Broadwell SoC uServer
> +-  Product Name: SYS-5018D-FN4T

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
> Sent: Monday, March 25, 2019 1:37 AM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V3] test_plans/etag:add hardware informations
[Lijuan] typo,  informations -> information
> 
> add hardware informations
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  test_plans/etag_test_plan.rst | 25 ++++++++++++++++++++++---
>  1 file changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/test_plans/etag_test_plan.rst b/test_plans/etag_test_plan.rst
> index 6350d64..43d7121 100644
> --- a/test_plans/etag_test_plan.rst
> +++ b/test_plans/etag_test_plan.rst
> @@ -35,12 +35,12 @@ External Tag (E-tag) Tests
> ==========================
> 
>  In some systems an additional external tag (E-tag) can be present before the
> -VLAN. NIC X550 support VLANs in presence of external tags.
> +VLAN. NIC X550 and X552/X557 support VLANs in presence of external tags.
>  E-tag mode is used for systems where the device adds a tag to identify a
> subsystem (usually a VM) and the near end switch adds a tag indicating the
> destination subsystem.
> 
> -The support of E-tag features by X550 consists in:
> +The support of E-tag features by X550 and X552/X557 consists in:
>  - The filtering of received E-tag packets
>  - E-tag header stripping by VF device in received packets
>  - E-tag header insertion by VF device in transmitted packets @@ -48,6
> +48,25 @@ The support of E-tag features by X550 consists in:
> 
>  Prerequisites
>  =============
> +1. Hardware:
> +
> +-  Machine type: SuperMicro 1U Xeon D Broadwell SoC uServer
> +-  Product Name: SYS-5018D-FN4T
> +-  Nic: Sageville(X550) and Sagepond(X552/X557-AT)
> +
> +   Note: you can use "dmidecode | grep 'Product Name'" command to get
> the product name.
> +
> +2. Bios:
> +
> +-  Enable etag items in BIOS
[Lijuan] it's better to tell where can found the etag items, such as AA->BB->CC->DD
> +
> +3. Software:
> +
> +- DPDK: http://dpdk.org/git/dpdk
> +
> +
> +Set up scenario
> +===============
> 
>  1. Create 2VF devices from PF device::
> 
> @@ -55,7 +74,7 @@ Prerequisites
>        0000:84:00.0 'Device 1563' drv=igb_uio unused=
>        echo 2 > /sys/bus/pci/devices/0000\:84\:00.0/max_vfs
> 
> -2. Detach VFs from the host, bind them to pci-stub driver::
> +2. Detach VFs from the host, bind them to pci-stub or vfio-pci driver::
> 
>        /sbin/modprobe pci-stub
> 
> --
> 2.17.2