test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Wu, ChangqingX" <changqingx.wu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Wu, ChangqingX" <changqingx.wu@intel.com>
Subject: Re: [dts] [PATCH V1] framework/project_dpdk:delete the specified	compiler of freebsd
Date: Wed, 3 Apr 2019 17:04:58 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA5B5CE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1553589140-87124-1-git-send-email-changqingx.wu@intel.com>

If you submit the V2, Could you please change your version tag to v2, I take the patch are the same if there are the same version tag.

Still miss a line of gcc48, 
239:        out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Tuesday, March 26, 2019 1:32 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] framework/project_dpdk:delete the specified
> compiler of freebsd
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  framework/project_dpdk.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> 6035c68..bc26f55 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -236,13 +236,13 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
>          build_time = 120
>          # compile
> -        out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> +        out = self.send_expect("make -j %d install T=%s" %
> + (self.number_of_cores,
>                                                                       target),
>                                 "#", build_time)
>          if("Error" in out or "No rule to make" in out):
>              self.logger.error("ERROR - try without '-j'")
>              # if Error try to execute make without -j option
> -            out = self.send_expect("make install T=%s CC=gcc48" % target,
> +            out = self.send_expect("make install T=%s" % target,
>                                     "#", build_time)
> 
>          assert ("Error" not in out), "Compilation error..."
> --
> 2.17.2


      parent reply	other threads:[~2019-04-03 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26  8:32 changqingxwu
2019-03-26  9:35 ` Zhu, ShuaiX
2019-04-03 17:04 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA5B5CE@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).