From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4EDD6A0679 for ; Wed, 3 Apr 2019 19:27:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FCEB1B515; Wed, 3 Apr 2019 19:27:10 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id ADF001B509 for ; Wed, 3 Apr 2019 19:27:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 10:27:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,305,1549958400"; d="scan'208";a="139708702" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 10:27:07 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:27:06 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:27:06 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Thu, 4 Apr 2019 01:27:04 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions Thread-Index: AQHU5fWHQtaeq++Kv0Omt5EULDEo26YlIYgggADc1wCABLoI8A== Date: Wed, 3 Apr 2019 17:27:04 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA5B7CF@SHSMSX101.ccr.corp.intel.com> References: <1553839799-91625-1-git-send-email-wenhuix.zhu@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA542D4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFkMmQ5NGEtODIyZi00YWNiLWJkZWYtYmY1OGRmM2VkMzk3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHVpMUpUbmlkd2twTzhCemkrUXRPTGhCODllZndwTm1qQlh5N3F4eDU2eUdvVk9nU25DXC9HQXpLazhPa3RQVzUifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: Zhu, WenhuiX > Sent: Sunday, March 31, 2019 6:14 PM > To: Tu, Lijuan ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment > conditions >=20 > Hi lijuan, >=20 > 1. This is not a recent one, it has been there before. > 2. The threshold is 2022. When it is greater than 2022, the open/stop por= t is > required. [Lijuan] Could your kindly to add a static variable to point to the thresho= ld, so that readers could understand why is 2048. Some interpretation will = be great. >=20 > BR, > Wenhui. > -----Original Message----- > From: Tu, Lijuan > Sent: Sunday, March 31, 2019 12:07 PM > To: Zhu, WenhuiX ; dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment > conditions >=20 > Is this a new issue found in 19.05? if the answer is yes, which commit > changed ? >=20 > As your commets, only 2048 require to open/stop port, does other mtu need > to do that? >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > > Sent: Thursday, March 28, 2019 11:10 PM > > To: dts@dpdk.org > > Cc: Zhu, WenhuiX > > Subject: [dts] [PATCH V1] tests/userspace_ethtool Modify judgment > > conditions > > > > Set the mtu to 2048. First "stop port_id", then "open port_id" > > The second package pkt_size needs to be added HEADER_SIZE['eth'] > > > > Signed-off-by: zhuwenhui > > --- > > tests/TestSuite_userspace_ethtool.py | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/tests/TestSuite_userspace_ethtool.py > > b/tests/TestSuite_userspace_ethtool.py > > index 4208e0f..060529e 100644 > > --- a/tests/TestSuite_userspace_ethtool.py > > +++ b/tests/TestSuite_userspace_ethtool.py > > @@ -556,16 +556,18 @@ class TestUserspaceEthtool(TestCase, > > IxiaPacketGenerator): > > self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "= # ") > > for mtu in mtus: > > self.dut.send_expect("mtu %d %d" % (index, mtu), > > "EthApp>") > > + self.dut.send_expect("open %s" % index, "EthApp>") > > ori_rx_pkts, _ =3D self.strip_portstats(index) > > pkt_size =3D mtu + HEADER_SIZE['eth'] > > pkt =3D Packet(pkt_len=3Dpkt_size) > > pkt.send_pkt(tx_port=3Dintf) > > rx_pkts, _ =3D self.strip_portstats(index) > > - self.verify(rx_pkts =3D=3D ori_rx_pkts, "Packet match = mtu not > > forwarded as expected") > > - pkt =3D Packet(pkt_len=3Dmtu + 1) > > + self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Packet ma= tch > > + mtu not > > forwarded as expected") > > + pkt =3D Packet(pkt_len=3Dmtu + 1 + HEADER_SIZE['eth']) > > pkt.send_pkt(tx_port=3Dintf) > > rx_pkts_over, _ =3D self.strip_portstats(index) > > self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over = mtu > > should not be > > forwarded") > > + self.dut.send_expect("stop %s" % index, "EthApp>") > > > > self.tester.send_expect("ifconfig %s mtu %d" % (intf, > > ori_mtu), "# ") > > > > -- > > 2.17.2