test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/checksum offload: add send flow
@ 2019-04-02 15:45 zhaomeijuan
  2019-04-03 18:05 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: zhaomeijuan @ 2019-04-02 15:45 UTC (permalink / raw)
  To: dts; +Cc: zhaomeijuan

add send packet flow

Signed-off-by: zhaomeijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_checksum_offload.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 6541ba5..3933562 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -361,17 +361,21 @@ class TestChecksumOffload(TestCase):
         Pps = dict()
         Pct = dict()
         dmac = self.dut.get_mac_address(self.dut_ports[0])
+        dmac1 = self.dut.get_mac_address(self.dut_ports[1])
 
         result = [2, lcore, ptype, mode]
         for size in size_list:
             flow = flow_format % (dmac, size)
             self.tester.scapy_append('wrpcap("test.pcap", [%s])' % flow)
             self.tester.scapy_execute()
+            flow = flow_format % (dmac1, size)
+            self.tester.scapy_append('wrpcap("test1.pcap", [%s])' % flow)
+            self.tester.scapy_execute()
             tgenInput = []
             tgenInput.append(
                 (self.tester.get_local_port(self.dut_ports[0]), self.tester.get_local_port(self.dut_ports[1]), "test.pcap"))
             tgenInput.append(
-                (self.tester.get_local_port(self.dut_ports[1]), self.tester.get_local_port(self.dut_ports[0]), "test.pcap"))
+                (self.tester.get_local_port(self.dut_ports[1]), self.tester.get_local_port(self.dut_ports[0]), "test1.pcap"))
             Bps[str(size)], Pps[
                 str(size)] = self.tester.traffic_generator_throughput(tgenInput)
             self.verify(Pps[str(size)] > 0, "No traffic detected")
@@ -390,7 +394,7 @@ class TestChecksumOffload(TestCase):
         """
         # Verify that enough ports are available
         self.verify(len(self.dut_ports) >= 2, "Insufficient ports for testing")
-
+        self.dut.send_expect("quit", "#")
         # sizes = [64, 128, 256, 512, 1024]
         sizes = [64, 128]
         pkts = {'IP/UDP': 'Ether(dst="%s", src="52:00:00:00:00:00")/IP()/UDP()/("X"*(%d-46))',
@@ -406,16 +410,19 @@ class TestChecksumOffload(TestCase):
         portMask = utils.create_mask([self.dut_ports[0], self.dut_ports[1]])
         for mode in ["sw", "hw"]:
             self.logger.info("%s performance" % mode)
-            rst.write_text(mode + " Performance" + '\r\n')
+            #rst.write_text(mode + " Performance" + '\r\n')
             tblheader = ["Ports", "S/C/T", "Packet Type", "Mode"]
             for size in sizes:
                 tblheader.append("%sB mpps" % str(size))
                 tblheader.append("%sB %%   " % str(size))
             self.result_table_create(tblheader)
+            #self.pmdout.start_testpmd(
+            #    lcore, "--portmask=%s" % self.portMask, socket=self.ports_socket)
             self.pmdout.start_testpmd(
-                lcore, "--portmask=%s" % self.portMask, socket=self.ports_socket)
+                lcore, "--portmask=%s" % self.portMask + " --enable-rx-cksum " +
+                                  "--port-topology=loop", socket=self.ports_socket)
 
-            self.dut.send_expect("set verbose 1", "testpmd> ")
+            #self.dut.send_expect("set verbose 1", "testpmd> ")
             self.dut.send_expect("set fwd csum", "testpmd> ")
             if mode == "hw":
                 self.checksum_enablehw(self.dut_ports[0])
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] tests/checksum offload: add send flow
  2019-04-02 15:45 [dts] [PATCH V2] tests/checksum offload: add send flow zhaomeijuan
@ 2019-04-03 18:05 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-04-03 18:05 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Could you please remove your useless code.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhaomeijuan
> Sent: Tuesday, April 2, 2019 8:46 AM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V2] tests/checksum offload: add send flow
> 
> add send packet flow
> 
> Signed-off-by: zhaomeijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_checksum_offload.py | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index 6541ba5..3933562 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -361,17 +361,21 @@ class TestChecksumOffload(TestCase):
>          Pps = dict()
>          Pct = dict()
>          dmac = self.dut.get_mac_address(self.dut_ports[0])
> +        dmac1 = self.dut.get_mac_address(self.dut_ports[1])
> 
>          result = [2, lcore, ptype, mode]
>          for size in size_list:
>              flow = flow_format % (dmac, size)
>              self.tester.scapy_append('wrpcap("test.pcap", [%s])' % flow)
>              self.tester.scapy_execute()
> +            flow = flow_format % (dmac1, size)
> +            self.tester.scapy_append('wrpcap("test1.pcap", [%s])' % flow)
> +            self.tester.scapy_execute()
>              tgenInput = []
>              tgenInput.append(
>                  (self.tester.get_local_port(self.dut_ports[0]),
> self.tester.get_local_port(self.dut_ports[1]), "test.pcap"))
>              tgenInput.append(
> -                (self.tester.get_local_port(self.dut_ports[1]),
> self.tester.get_local_port(self.dut_ports[0]), "test.pcap"))
> +                (self.tester.get_local_port(self.dut_ports[1]),
> + self.tester.get_local_port(self.dut_ports[0]), "test1.pcap"))
>              Bps[str(size)], Pps[
>                  str(size)] = self.tester.traffic_generator_throughput(tgenInput)
>              self.verify(Pps[str(size)] > 0, "No traffic detected") @@ -390,7 +394,7
> @@ class TestChecksumOffload(TestCase):
>          """
>          # Verify that enough ports are available
>          self.verify(len(self.dut_ports) >= 2, "Insufficient ports for testing")
> -
> +        self.dut.send_expect("quit", "#")
>          # sizes = [64, 128, 256, 512, 1024]
>          sizes = [64, 128]
>          pkts = {'IP/UDP': 'Ether(dst="%s",
> src="52:00:00:00:00:00")/IP()/UDP()/("X"*(%d-46))',
> @@ -406,16 +410,19 @@ class TestChecksumOffload(TestCase):
>          portMask = utils.create_mask([self.dut_ports[0], self.dut_ports[1]])
>          for mode in ["sw", "hw"]:
>              self.logger.info("%s performance" % mode)
> -            rst.write_text(mode + " Performance" + '\r\n')
> +            #rst.write_text(mode + " Performance" + '\r\n')
>              tblheader = ["Ports", "S/C/T", "Packet Type", "Mode"]
>              for size in sizes:
>                  tblheader.append("%sB mpps" % str(size))
>                  tblheader.append("%sB %%   " % str(size))
>              self.result_table_create(tblheader)
> +            #self.pmdout.start_testpmd(
> +            #    lcore, "--portmask=%s" % self.portMask, socket=self.ports_socket)
>              self.pmdout.start_testpmd(
> -                lcore, "--portmask=%s" % self.portMask, socket=self.ports_socket)
> +                lcore, "--portmask=%s" % self.portMask + " --enable-rx-cksum " +
> +                                  "--port-topology=loop",
> + socket=self.ports_socket)
> 
> -            self.dut.send_expect("set verbose 1", "testpmd> ")
> +            #self.dut.send_expect("set verbose 1", "testpmd> ")
>              self.dut.send_expect("set fwd csum", "testpmd> ")
>              if mode == "hw":
>                  self.checksum_enablehw(self.dut_ports[0])
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-03 18:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 15:45 [dts] [PATCH V2] tests/checksum offload: add send flow zhaomeijuan
2019-04-03 18:05 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).