From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D8F5AA0096 for ; Fri, 12 Apr 2019 18:55:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBD731B2B3; Fri, 12 Apr 2019 18:55:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D096E1B2AD for ; Fri, 12 Apr 2019 18:55:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2019 09:55:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,342,1549958400"; d="scan'208";a="142282618" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 12 Apr 2019 09:55:16 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 12 Apr 2019 09:54:28 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 12 Apr 2019 09:54:28 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Sat, 13 Apr 2019 00:54:26 +0800 From: "Tu, Lijuan" To: "Wu, ChangqingX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid Thread-Index: AQHU7qO/flf//Gi6gUSPETrvWZmp3aY3NyTwgAAFrYCAAYYsIA== Date: Fri, 12 Apr 2019 16:54:25 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA60C8E@SHSMSX101.ccr.corp.intel.com> References: <1554794115-14839-1-git-send-email-changqingx.wu@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BA60548@SHSMSX101.ccr.corp.intel.com> <7F81DD3887C58F49A6B2EFEC3C28E22E0B6CD085@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F81DD3887C58F49A6B2EFEC3C28E22E0B6CD085@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzAyYmVjYWEtMWRmYS00MzcyLWIwZjctZTYzZDNiYjQ5NDRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNnhoUFdwdmp3SFJzeUJqN2ZuSjdRZ2FpOVBnbEZoQWdLQ1hrQU5mUWo2RmNndFpcLzQwdkQrNmhuQWJ1d3lzMTUifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Could you please also send your reason while you commit a patch. So you should also remove the definition of self.l4err_num if it's never us= ed at all. > -----Original Message----- > From: Wu, ChangqingX > Sent: Thursday, April 11, 2019 6:36 PM > To: Tu, Lijuan ; dts@dpdk.org > Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid >=20 > Dpdk made some code changes in the > commit:53324971a14e02f5f710d6e73fe475650e9a9802, which effects > method that tests the number of "Bad-l4csum", continuously sends 2 or > more packets between start and stop, the number of "Bad-l4csum" Will > accumulate, if stop, the number of "Bad-l4csum" will be reset, you can ch= eck: > dpdk-11148, Yigit, Ferruh comments >=20 >=20 > Thanks > changqingx >=20 > -----Original Message----- > From: Tu, Lijuan > Sent: Friday, April 12, 2019 1:26 AM > To: Wu, ChangqingX ; dts@dpdk.org > Cc: Wu, ChangqingX > Subject: RE: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid >=20 > I am not quit catch your reason, I think when it catch "Bad-l4csum", and = the > number increases. So what is your consideration that remove the statement= . >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu > > Sent: Tuesday, April 9, 2019 12:15 AM > > To: dts@dpdk.org > > Cc: Wu, ChangqingX > > Subject: [dts] [PATCH V1] vxlan:Optimization check inner l4 invalid > > > > Signed-off-by: changqingxwu > > --- > > tests/TestSuite_vxlan.py | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index > > 8de8384..34297e0 100644 > > --- a/tests/TestSuite_vxlan.py > > +++ b/tests/TestSuite_vxlan.py > > @@ -469,7 +469,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator): > > if "inner_l4_invalid" in kwargs: > > self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out) > > =3D=3D self.l4err_num + 1, "Failed to count in= ner l4 chksum > error") > > - self.l4err_num +=3D 1 > > > > # verify detected l3 invalid checksum > > if "ip_invalid" in kwargs: > > -- > > 2.17.2