From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 300EAA00E6 for ; Mon, 15 Apr 2019 21:55:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 236C31B3B8; Mon, 15 Apr 2019 21:55:14 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 76B341B3B5 for ; Mon, 15 Apr 2019 21:55:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 12:55:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,354,1549958400"; d="scan'208";a="149657166" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 15 Apr 2019 12:55:11 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 12:55:11 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 15 Apr 2019 12:55:11 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 03:55:09 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions Thread-Index: AQHU7oVKTIP4jCNEQkGqsasnNNvDXqY9rRiQ Date: Mon, 15 Apr 2019 19:55:08 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA61AFA@SHSMSX101.ccr.corp.intel.com> References: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1554781169-14153-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTFmOTgzMWMtNDZlZi00Y2NjLTlmZjMtMWVlYmIwZTFhMmU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9jUDBjQVNQXC9DdlRyRDFcL2ZIZ2FpeEoyeTJrQ0N1YVlCSEFYS3MwQmswYUdoK2trd2FvWEVDbUhoU25Dc2E3RCJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment conditions X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thaks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Monday, April 8, 2019 8:39 PM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V2] tests/userspace_ethtool Modify judgment > conditions >=20 > The second package pkt_size needs to be added HEADER_SIZE['eth']. > The mtu threshold is 2022, when mtu is over 2022,require to open/stop por= t >=20 >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_userspace_ethtool.py | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 4208e0f..f8428ea 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -547,6 +547,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > """ > self.dut.send_expect(self.cmd, "EthApp>", 60) > mtus =3D [1519, 2048] > + mtu_threshold =3D 2022 > for index in range(len(self.ports)): > port =3D self.ports[index] > # change mtu > @@ -555,14 +556,19 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > ori_mtu =3D self.strip_mtu(intf) > self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# = ") > for mtu in mtus: > + # The mtu threshold is 2022,When it is greater than 2022= , the > open/stop port is required. > + if mtu > mtu_threshold: > + self.dut.send_expect("stop %s" % index, "EthApp>") > + self.dut.send_expect("mtu %d %d" % (index, mtu), "Et= hApp>") > + self.dut.send_expect("open %s" % index, "EthApp>") > self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp= >") > ori_rx_pkts, _ =3D self.strip_portstats(index) > pkt_size =3D mtu + HEADER_SIZE['eth'] > pkt =3D Packet(pkt_len=3Dpkt_size) > pkt.send_pkt(tx_port=3Dintf) > rx_pkts, _ =3D self.strip_portstats(index) > - self.verify(rx_pkts =3D=3D ori_rx_pkts, "Packet match mt= u not > forwarded as expected") > - pkt =3D Packet(pkt_len=3Dmtu + 1) > + self.verify(rx_pkts =3D=3D ori_rx_pkts + 1, "Packet matc= h mtu not > forwarded as expected") > + pkt =3D Packet(pkt_len=3Dmtu + 1 + HEADER_SIZE['eth']) > pkt.send_pkt(tx_port=3Dintf) > rx_pkts_over, _ =3D self.strip_portstats(index) > self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over mt= u should not be > forwarded") > -- > 2.17.2