test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Wu, ChangqingX" <changqingx.wu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Wu, ChangqingX" <changqingx.wu@intel.com>
Subject: Re: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
Date: Mon, 15 Apr 2019 20:39:41 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA6244E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1555322164-25653-1-git-send-email-changqingx.wu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Monday, April 15, 2019 2:56 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
> 
> resetting 'rx_bad_*' stats after stop, this is consistent behavior with rest of
> the stats. It is not necessary to accumulate the results of Bad-l4csum after
> each stop.
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..b4b852f 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -468,8 +468,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          # verify detected l4 invalid checksum
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
> -                        == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> -            self.l4err_num += 1
> +                        == 1, "Failed to count inner l4 chksum error")
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> @@ -649,7 +648,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>                                'PORT': self.portMask}
>          self.dut.send_expect(pmd_cmd, "testpmd>", 30)
>          self.iperr_num = 0
> -        self.l4err_num = 0
> 
>          # disable vlan filter
>          self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> @@ -724,7 +722,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>                                'PORT': self.portMask}
>          self.dut.send_expect(pmd_cmd, "testpmd>", 30)
>          self.iperr_num = 0
> -        self.l4err_num = 0
> 
>          # disable vlan filter
>          self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> --
> 2.17.2


      reply	other threads:[~2019-04-15 20:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  9:56 changqingxwu
2019-04-15 20:39 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA6244E@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=changqingx.wu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).