[dts] [PATCH V2] vxlan:Optimization check inner l4 invalid

[dts] [PATCH V2] vxlan:Optimization check inner l4 invalid

[changqingxwu]

resetting 'rx_bad_*' stats after stop, this is consistent behavior
with rest of the stats. It is not necessary to accumulate the results 
of Bad-l4csum after each stop.

Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
 tests/TestSuite_vxlan.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 8de8384..b4b852f 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -468,8 +468,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         # verify detected l4 invalid checksum
         if "inner_l4_invalid" in kwargs:
             self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
-                        == self.l4err_num + 1, "Failed to count inner l4 chksum error")
-            self.l4err_num += 1
+                        == 1, "Failed to count inner l4 chksum error")
 
         # verify detected l3 invalid checksum
         if "ip_invalid" in kwargs:
@@ -649,7 +648,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
                               'PORT': self.portMask}
         self.dut.send_expect(pmd_cmd, "testpmd>", 30)
         self.iperr_num = 0
-        self.l4err_num = 0
 
         # disable vlan filter
         self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
@@ -724,7 +722,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
                               'PORT': self.portMask}
         self.dut.send_expect(pmd_cmd, "testpmd>", 30)
         self.iperr_num = 0
-        self.l4err_num = 0
 
         # disable vlan filter
         self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
-- 
2.17.2

Re: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid

[Tu, Lijuan]

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Monday, April 15, 2019 2:56 AM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V2] vxlan:Optimization check inner l4 invalid
> 
> resetting 'rx_bad_*' stats after stop, this is consistent behavior with rest of
> the stats. It is not necessary to accumulate the results of Bad-l4csum after
> each stop.
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_vxlan.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py index
> 8de8384..b4b852f 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -468,8 +468,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>          # verify detected l4 invalid checksum
>          if "inner_l4_invalid" in kwargs:
>              self.verify(self.pmdout.get_pmd_value("Bad-l4csum:", out)
> -                        == self.l4err_num + 1, "Failed to count inner l4 chksum error")
> -            self.l4err_num += 1
> +                        == 1, "Failed to count inner l4 chksum error")
> 
>          # verify detected l3 invalid checksum
>          if "ip_invalid" in kwargs:
> @@ -649,7 +648,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>                                'PORT': self.portMask}
>          self.dut.send_expect(pmd_cmd, "testpmd>", 30)
>          self.iperr_num = 0
> -        self.l4err_num = 0
> 
>          # disable vlan filter
>          self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> @@ -724,7 +722,6 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>                                'PORT': self.portMask}
>          self.dut.send_expect(pmd_cmd, "testpmd>", 30)
>          self.iperr_num = 0
> -        self.l4err_num = 0
> 
>          # disable vlan filter
>          self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> --
> 2.17.2