From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9F087A00E6 for ; Wed, 17 Apr 2019 01:23:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5787D1B554; Wed, 17 Apr 2019 01:23:53 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E44BC1B54F for ; Wed, 17 Apr 2019 01:23:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 16:23:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,359,1549958400"; d="scan'208";a="141270525" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 16 Apr 2019 16:23:50 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 16:23:50 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 16:23:50 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 07:23:48 +0800 From: "Tu, Lijuan" To: Rami Rosen , "dts@dpdk.org" Thread-Topic: test_plans/pmdrssreta: make RSS RETA test plan generic Thread-Index: AdT0HE6Svmh0tcOnQwKnIm69w7J0IgAjwlwA Date: Tue, 16 Apr 2019 23:23:46 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA62F10@SHSMSX101.ccr.corp.intel.com> References: <5151E1D101B7B04382075E3B0EF69373EBD4CC@lhreml503-mbs> In-Reply-To: <5151E1D101B7B04382075E3B0EF69373EBD4CC@lhreml503-mbs> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzY3NjQ1NzItNDY1YS00NWUwLWFjZGYtOTQzYWNjY2I4YWQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieUY3bkhkc3IyVWhzdUl6NkZyYlZIRjhyN2kyeXloTlR1RUhMamswcVVxR0tlUm1Mam1LT0ZOR3ZpV1IzdEdpMyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] test_plans/pmdrssreta: make RSS RETA test plan generic X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Could you please rework your patch, applied failed as below: Applying patch test_plans/pmdrssreta_test_plan.rst with 2 rejects... Rejected hunk #1. Rejected hunk #2. Hunk #3 applied cleanly. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen > Sent: Monday, April 15, 2019 11:20 PM > To: dts@dpdk.org > Cc: Rami Rosen > Subject: [dts] test_plans/pmdrssreta: make RSS RETA test plan generic >=20 > Following a patch which was applied recently, the RSS RETA Test Suite > (tests/TestSuite_pmdrssreta.py) runs also on Huawei hinic PMD, and is no > longer specific to Niantic PMD. > See: http://mails.dpdk.org/archives/dts/2019-April/005653.html > This patch fixes the RSS RETA test plan accordingly. >=20 > Signed-off-by: Rami Rosen > --- > test_plans/pmdrssreta_test_plan.rst | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) >=20 > diff --git a/test_plans/pmdrssreta_test_plan.rst > b/test_plans/pmdrssreta_test_plan.rst > index 09f69c1..82b2203 > --- a/test_plans/pmdrssreta_test_plan.rst > +++ b/test_plans/pmdrssreta_test_plan.rst > @@ -31,12 +31,11 @@ > OF THE POSSIBILITY OF SUCH DAMAGE. >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -Niantic Reta (Redirection table) Tests > +Network PMD Reta (Redirection table) Tests > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > This document provides test plan for benchmarking of Rss reta(Redirectio= n > -table) updating for the Intel(r) 82599 10 Gigabit Ethernet Controller > -(Niantic) Poll Mode Driver (PMD) in userland runtime configurations. > +table) updating for a network Poll Mode Driver (PMD) in userland runtime > configurations. > The content of Rss Redirection table are not defined following reset of= the > Memory Configuration registers. System software must initialize the tabl= e > prior to enabling multiple receive queues .It can also update @@ -46,11 > +45,7 @@ not synchronized with the arrival time of received packets. > Prerequisites > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > -2x Intel(r) 82599 (Niantic) NICs (2x 10GbE full duplex optical ports per= NIC) - > plugged into the available PCIe Gen2 8-lane slots. To avoid PCIe bandwidt= h - > bottlenecks at high packet rates, a single optical port from each NIC is = - > connected to the traffic generator. > - > +2x NICs plugged into the available PCIe Gen2 or Gen3 slots. >=20 > Network Traffic > --------------- > @@ -59,16 +54,16 @@ The RSS feature is designed to improve networking > performance by load balancing the packets received from a NIC port to > multiple NIC RX queues, with each queue handled by a different logical c= ore. >=20 > -#. The receive packet is parsed into the header fields used by the hash > +#. The received packet is parsed into the header fields used by the > +hash > operation (such as IP addresses, TCP port, etc.) >=20 > -#. A hash calculation is performed. The 82599 supports a single hash > function, > +#. A hash calculation is performed. In the case of 82599 PMD, it > +supports a single hash function, > as defined by MSFT RSS. The 82599 therefore does not indicate to the > device > - driver which hash function is used. The 32-bit result is fed into the > + driver whose hash function is used. The 32-bit result is fed into > + the > packet receive descriptor. >=20 > -#. The seven LSBs of the hash result are used as an index into a 128-ent= ry > - 'redirection table'. Each entry provides a 4-bit RSS output index. > +#. In the case of 82599 PMD, the seven LSBs of the hash result are used > +as an index into a 128-entry 'redirection table'. Each entry provides a = 4-bit > RSS output index. >=20 > The RSS RETA update feature is designed to make RSS more flexible by > allowing users to define the correspondence between the seven LSBs of > hash result and > -- > 1.8.3.1